Skip to contentSkip to conversation

rdma: Move RDMA UAPI header file to be under RDMA responsibility

PATCH Applied Leon Romanovsky 3 participants 5 messages Mar 25, 2018 – Mar 26, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rdma: Move RDMA UAPI header file to be under RDMA responsibility

From: Leon Romanovsky <[email protected]>

In iproute2 package, the updates of UAPIs files are performed after the needed feature lands in kernel's net-next tree.

Such development flow created delays to the rdma tool developers, who uses rdma-next tree as a basis for their work.

Move RDMA UAPI file to be under rdma/ folder, so whole responsibility of syncing this file will be on them.

---
 rdma/Makefile                                      | 1 +
 {include => rdma/include}/uapi/rdma/rdma_netlink.h | 0
 2 files changed, 1 insertion(+)
 rename {include => rdma/include}/uapi/rdma/rdma_netlink.h (100%)
rdma/Makefile +1 -0
index 360f09b2..819fcbe3 100644
@@ -4,6 +4,7 @@ include ../config.mk
 TARGETS :=
 
 ifeq ($(HAVE_MNL),y)
+CFLAGS += -I./include/uapi/
 
 RDMA_OBJ = rdma.o utils.o dev.o link.o res.o
 
rdma/include/uapi/rdma/rdma_netlink.h renamed from include/uapi/rdma/rdma_netlink.h +0 -0
similarity index 100%
rename from include/uapi/rdma/rdma_netlink.h
rename to rdma/include/uapi/rdma/rdma_netlink.h
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines

Subject: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility

From: Leon Romanovsky <[email protected]>

In iproute2 package, the updates of UAPIs files are performed after the needed feature lands in kernel's net-next tree.

Quoted 7 lines

Such development flow created delays to the rdma tool developers, who uses rdma-next tree as a basis for their work.

Move RDMA UAPI file to be under rdma/ folder, so whole responsibility of syncing this file will be on them.

Applied
#2 lore raw
In reply to Leon Romanovsky
Quoted 11 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

In iproute2 package, the updates of UAPIs files are performed after the needed feature lands in kernel's net-next tree.

Such development flow created delays to the rdma tool developers, who uses rdma-next tree as a basis for their work.

Move RDMA UAPI file to be under rdma/ folder, so whole responsibility of syncing this file will be on them.

Quoted 6 lines
---
 rdma/Makefile                                      | 1 +
 {include => rdma/include}/uapi/rdma/rdma_netlink.h | 0
 2 files changed, 1 insertion(+)
 rename {include => rdma/include}/uapi/rdma/rdma_netlink.h (100%)

applied to iproute2-next

#3 lore raw
Quoted 12 lines · David Ahern
Quoted 11 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

In iproute2 package, the updates of UAPIs files are performed after the needed feature lands in kernel's net-next tree.

Such development flow created delays to the rdma tool developers, who uses rdma-next tree as a basis for their work.

Move RDMA UAPI file to be under rdma/ folder, so whole responsibility of syncing this file will be on them.

Quoted 8 lines
Quoted 6 lines
---
 rdma/Makefile                                      | 1 +
 {include => rdma/include}/uapi/rdma/rdma_netlink.h | 0
 2 files changed, 1 insertion(+)
 rename {include => rdma/include}/uapi/rdma/rdma_netlink.h (100%)

applied to iproute2-next

Hey Leon, so how do I change rdma/include/uapi/rdma_netlink.h now for my series [1]?  Do I just make the changes?  Or is there some other process?

[1] https://www.spinics.net/lists/linux-rdma/msg61419.html

Steve.

#4 lore raw
Quoted 21 lines · Steve Wise
Quoted 18 lines · David Ahern
Quoted 17 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

In iproute2 package, the updates of UAPIs files are performed after the needed feature lands in kernel's net-next tree.

Such development flow created delays to the rdma tool developers, who uses rdma-next tree as a basis for their work.

Move RDMA UAPI file to be under rdma/ folder, so whole responsibility of syncing this file will be on them.

---
 rdma/Makefile                                      | 1 +
 {include => rdma/include}/uapi/rdma/rdma_netlink.h | 0
 2 files changed, 1 insertion(+)
 rename {include => rdma/include}/uapi/rdma/rdma_netlink.h (100%)
Quoted 5 lines
Quoted 2 lines

applied to iproute2-next

Hey Leon, so how do I change rdma/include/uapi/rdma_netlink.h now for my series [1]?  Do I just make the changes?  Or is there some other process?

I don't think that we need "process" yet, simply copy from kernel.

Quoted 4 lines

[1] https://www.spinics.net/lists/linux-rdma/msg61419.html

Steve.