Skip to contentSkip to conversation

efi_loader: initialize device path on alloc

PATCH Applied Patrick Wildt 3 participants 3 messages Mar 25, 2018 – Apr 4, 2018

lore
Share & tools
lore

Patrick Wildt

author
#0 lore raw

PATCH 1/1 efi_loader: initialize device path on alloc

Since the backing memory for a new device path can contain stale data we have to make sure that we zero the buffer. Otherwise some code paths that don't set all fields in a structure backed by this device path might contain unwanted stale data.

Signed-off-by Patrick Wildt <[email protected]>
---
 lib/efi_loader/efi_device_path.c | 1 +
 1 file changed, 1 insertion(+)
lib/efi_loader/efi_device_path.c +1 -0
index 3c735e60d3..20f5c83219 100644
@@ -66,6 +66,7 @@ static void *dp_alloc(size_t sz)
 		return NULL;
 	}
 
+	memset(buf, 0, sz);
 	return buf;
 }
Signature · 1 line
2.14.3 (Apple Git-98)
#1 lore raw

PATCH 1/1 efi_loader: initialize device path on alloc

Quoted 6 lines · Patrick Wildt

Since the backing memory for a new device path can contain stale data we have to make sure that we zero the buffer. Otherwise some code paths that don't set all fields in a structure backed by this device path might contain unwanted stale data.

Signed-off-by Patrick Wildt <[email protected]>

Thank you for the patch.

Reviewed-by Heinrich Schuchardt <[email protected]>
Quoted 17 lines
---
 lib/efi_loader/efi_device_path.c | 1 +
 1 file changed, 1 insertion(+)
lib/efi_loader/efi_device_path.c +1 -0
index 3c735e60d3..20f5c83219 100644
@@ -66,6 +66,7 @@ static void *dp_alloc(size_t sz)
 		return NULL;
 	}
 
+	memset(buf, 0, sz);
 	return buf;
 }