Makefile: fix build break in sdk target
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 Makefile: fix build break in sdk target
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Stefan" == Stefan Becker <[email protected]> writes:
After commit
6729050f3a49dba42d2d881d31dbefd6b82b8dadnothing creates $(HOST_DIR)/share/buildroot anymore, causing sdk to fail with:
/bin/bash: .../output/host/share/buildroot/sdk-location: No such file or directoryAdd creation of that directory to the "sdk" build steps itself.
Signed-off-by Stefan Becker <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 Makefile: fix build break in sdk target
In reply to a message not in the archiveHello,
Quoted 17 lines · Stefan Becker
After commit
6729050f3a49dba42d2d881d31dbefd6b82b8dadnothing creates $(HOST_DIR)/share/buildroot anymore, causing sdk to fail with:
/bin/bash: .../output/host/share/buildroot/sdk-location: No such file or directoryAdd creation of that directory to the "sdk" build steps itself.
Signed-off-by Stefan Becker <[email protected]>--- Makefile | 1 + 1 file changed, 1 insertion(+)Makefile +0
-0
Makefile sdk: world · line 577
Quoted 4 lines
Makefile +1
-0@@ -574,6 +574,7 @@ sdk: world $(TOPDIR)/support/scripts/fix-rpath host $(TOPDIR)/support/scripts/fix-rpath staging $(INSTALL) -m 755 $(TOPDIR)/support/misc/relocate-sdk.sh $(HOST_DIR)/relocate-sdk.sh + mkdir -p $(HOST_DIR)/share/buildroot
While this is OK, I am still not sure to understand why you are seeing this problem. My commit 6729050f3a49dba42d2d881d31dbefd6b82b8dad moved the creation of the $(HOST_DIR)/share/buildroot folder from a dependency of the toolchain package, to a post-install staging hook of the toolchain package.
But in both cases, the logic should be executed way before the sdk target is called.
So, I'm puzzled.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
A message that is not in the archive (sent off-list or not yet received): CAOJ2eMcc6TuND32UFt_TLQA1atMNGNrPshqjREWgo4VO71iapg@mail.gmail.com
PATCH 1/1 Makefile: fix build break in sdk target
Hi,
Quoted 12 lines · Stefan Becker
Quoted 8 lines · Thomas Petazzoni
Hello,
While this is OK, I am still not sure to understand why you are seeing this problem. My commit
6729050f3a49dba42d2d881d31dbefd6b82b8dadmoved the creation of the $(HOST_DIR)/share/buildroot folder from a dependency of the toolchain package, to a post-install staging hook of the toolchain package.
Quoted 7 lines
The top-level buildroot build steps executed are (a) "
xyz_deconfig" and
(b) "all sdk".Could be that you do not see the problem if you execute "all" and then "sdk". But then it would mean that some dependency is missing on the "sdk" target, which I agree would be worse.
I guess the real problem with commit 6729050f3a49dba42d2d881d31dbefd6b82b8dad is that it adds a script to toolchain install staging hooks, but does not set TOOLCHAIN_INSTALL_STAGING to YES. Thus after that change the script is no longer executed during the build.
I've submitted another patch to fix the root cause.
Regards, Stefan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180326/13d47d64/attachment.html>