Skip to contentSkip to conversation

watchdog: w83977f_wdt: Mark expected switch fall-through

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Mar 27, 2018 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: w83977f_wdt: Mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that in this particular case I replaced "Fall" with a proper "Fall through" comment, which is what GCC is expecting to find.

---
 drivers/watchdog/w83977f_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/w83977f_wdt.c +1 -1
index 20e2bba..672b61a 100644
@@ -427,7 +427,7 @@ static long wdt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 			return -EINVAL;
 
 		wdt_keepalive();
-		/* Fall */
+		/* Fall through */
 
 	case WDIOC_GETTIMEOUT:
 		return put_user(timeout, uarg.i);
Signature · 1 line
2.7.4
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that in this particular case I replaced "Fall" with a proper "Fall through" comment, which is what GCC is expecting to find.

Quoted 18 lines
---
  drivers/watchdog/w83977f_wdt.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/w83977f_wdt.c +1 -1
index 20e2bba..672b61a 100644
@@ -427,7 +427,7 @@ static long wdt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
  			return -EINVAL;
 
  		wdt_keepalive();
-		/* Fall */
+		/* Fall through */
 
  	case WDIOC_GETTIMEOUT:
  		return put_user(timeout, uarg.i);