watchdog: wafer5823wdt: Mark expected switch fall-through

PATCH In review Gustavo A. R. Silva 2 participants 3 messages Mar 27, 2018 Watchdog device drivers

lore

Share & tools

lore

Gustavo A. R. Silva

author

2018-03-27 19:33 UTC #0 lore raw

PATCH 1/1 watchdog: wafer5823wdt: Mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that in this particular case I replaced "Fall" with a proper "Fall through" comment, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/watchdog/wafer5823wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/watchdog/wafer5823wdt.c +1 -1

index db0da7e..93c5b61 100644
@@ -178,7 +178,7 @@ static long wafwdt_ioctl(struct file *file, unsigned int cmd,
 		timeout = new_timeout;
 		wafwdt_stop();
 		wafwdt_start();
-		/* Fall */
+		/* Fall through */
 	case WDIOC_GETTIMEOUT:
 		return put_user(timeout, p);

Signature · 1 line

2.7.4

Guenter Roeck

maintainer Reviewed-by on v1 1/1

2018-03-27 21:05 UTC #1 lore raw

Quoted 7 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case I replaced "Fall" with a proper "Fall through" comment, which is what GCC is expecting to find.
Signed-off-by Gustavo A. R. Silva <[email protected]>

Reviewed-by Guenter Roeck <[email protected]>

Quoted 18 lines

---
  drivers/watchdog/wafer5823wdt.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/watchdog/wafer5823wdt.c +1 -1

index db0da7e..93c5b61 100644
@@ -178,7 +178,7 @@ static long wafwdt_ioctl(struct file *file, unsigned int cmd,
  		timeout = new_timeout;
  		wafwdt_stop();
  		wafwdt_start();
-		/* Fall */
+		/* Fall through */
  	case WDIOC_GETTIMEOUT:
  		return put_user(timeout, p);

Gustavo A. R. Silva

author

2018-03-27 21:14 UTC #2 lore raw

Quoted 11 lines · Guenter Roeck

Quoted 7 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case I replaced "Fall" with a proper "Fall through" comment, which is what GCC is expecting to find.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>

Thanks, Guenter.
--
Gustavo