Skip to contentSkip to conversation

vfio: remove DPRINTF() definition from vfio-common.h

PATCH In review Tiwei Bie 3 participants 3 messages Mar 28, 2018

lore
Share & tools
lore

Tiwei Bie

author
#0 lore raw

PATCH 1/1 vfio: remove DPRINTF() definition from vfio-common.h

This macro isn't used by any VFIO code. And its name is too generic. The vfio-common.h (in include/hw/vfio) can be included by other modules in QEMU. It can introduce conflicts.

Signed-off-by Tiwei Bie <[email protected]>
---
 include/hw/vfio/vfio-common.h | 9 ---------
 1 file changed, 9 deletions(-)
include/hw/vfio/vfio-common.h +0 -9
index d9360148e6..cecbd4e386 100644
@@ -34,15 +34,6 @@
 #define ERR_PREFIX "vfio error: %s: "
 #define WARN_PREFIX "vfio warning: %s: "
 
-/*#define DEBUG_VFIO*/
-#ifdef DEBUG_VFIO
-#define DPRINTF(fmt, ...) \
-    do { fprintf(stderr, "vfio: " fmt, ## __VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
-    do { } while (0)
-#endif
-
 enum {
     VFIO_DEVICE_TYPE_PCI = 0,
     VFIO_DEVICE_TYPE_PLATFORM = 1,
Signature · 1 line
2.11.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Tiwei Bie

This macro isn't used by any VFIO code. And its name is too generic. The vfio-common.h (in include/hw/vfio) can be included by other modules in QEMU. It can introduce conflicts.

Signed-off-by Tiwei Bie <[email protected]>
Reviewed-by Michael S. Tsirkin <[email protected]>
Quoted 26 lines
---
 include/hw/vfio/vfio-common.h | 9 ---------
 1 file changed, 9 deletions(-)
include/hw/vfio/vfio-common.h +0 -9
index d9360148e6..cecbd4e386 100644
@@ -34,15 +34,6 @@
 #define ERR_PREFIX "vfio error: %s: "
 #define WARN_PREFIX "vfio warning: %s: "
 
-/*#define DEBUG_VFIO*/
-#ifdef DEBUG_VFIO
-#define DPRINTF(fmt, ...) \
-    do { fprintf(stderr, "vfio: " fmt, ## __VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
-    do { } while (0)
-#endif
-
 enum {
     VFIO_DEVICE_TYPE_PCI = 0,
     VFIO_DEVICE_TYPE_PLATFORM = 1,
Signature · 1 line
2.11.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Tiwei Bie

Hi,

Quoted 6 lines · Tiwei Bie

This macro isn't used by any VFIO code. And its name is too generic. The vfio-common.h (in include/hw/vfio) can be included by other modules in QEMU. It can introduce conflicts.

Signed-off-by Tiwei Bie <[email protected]>
Reviewed-by Eric Auger <[email protected]>

Thanks

Eric

Quoted 25 lines
---
 include/hw/vfio/vfio-common.h | 9 ---------
 1 file changed, 9 deletions(-)
include/hw/vfio/vfio-common.h +0 -9
index d9360148e6..cecbd4e386 100644
@@ -34,15 +34,6 @@
 #define ERR_PREFIX "vfio error: %s: "
 #define WARN_PREFIX "vfio warning: %s: "
 
-/*#define DEBUG_VFIO*/
-#ifdef DEBUG_VFIO
-#define DPRINTF(fmt, ...) \
-    do { fprintf(stderr, "vfio: " fmt, ## __VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
-    do { } while (0)
-#endif
-
 enum {
     VFIO_DEVICE_TYPE_PCI = 0,
     VFIO_DEVICE_TYPE_PLATFORM = 1,