drm/amdgpu/sdma: fix mask in emit_pipeline_sync
Subsystems (3)
PATCH 1/1 drm/amdgpu/sdma: fix mask in emit_pipeline_sync
Needs to be a 32 bit mask.
--- drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/cik_sdma.c +1 -1
@@ -859,7 +859,7 @@ static void cik_sdma_ring_emit_pipeline_sync(struct amdgpu_ring *ring)amdgpu_ring_write (ring, addr &0xfffffffc );amdgpu_ring_write (ring,upper_32_bits (addr) &0xffffffff );amdgpu_ring_write (ring, seq);/* reference */ -amdgpu_ring_write (ring,0xfffffff );/* mask */ +amdgpu_ring_write (ring,0xffffffff );/* mask */ amdgpu_ring_write (ring, (0xfff <<16 ) |4 );/* retry count, poll interval */ }
drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c +1 -1
@@ -837,7 +837,7 @@ static void sdma_v2_4_ring_emit_pipeline_sync(struct amdgpu_ring *ring)amdgpu_ring_write (ring, addr &0xfffffffc );amdgpu_ring_write (ring,upper_32_bits (addr) &0xffffffff );amdgpu_ring_write (ring, seq);/* reference */ -amdgpu_ring_write (ring,0xfffffff );/* mask */ +amdgpu_ring_write (ring,0xffffffff );/* mask */ amdgpu_ring_write (ring,SDMA_PKT_POLL_REGMEM_DW5_RETRY_COUNT (0xfff ) |SDMA_PKT_POLL_REGMEM_DW5_INTERVAL (4 ));/* retry count, poll interval */ }
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +1 -1
@@ -1105,7 +1105,7 @@ static void sdma_v3_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)amdgpu_ring_write (ring, addr &0xfffffffc );amdgpu_ring_write (ring,upper_32_bits (addr) &0xffffffff );amdgpu_ring_write (ring, seq);/* reference */ -amdgpu_ring_write (ring,0xfffffff );/* mask */ +amdgpu_ring_write (ring,0xffffffff );/* mask */ amdgpu_ring_write (ring,SDMA_PKT_POLL_REGMEM_DW5_RETRY_COUNT (0xfff ) |SDMA_PKT_POLL_REGMEM_DW5_INTERVAL (4 ));/* retry count, poll interval */ }
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +1 -1
@@ -1121,7 +1121,7 @@ static void sdma_v4_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)amdgpu_ring_write (ring, addr &0xfffffffc );amdgpu_ring_write (ring,upper_32_bits (addr) &0xffffffff );amdgpu_ring_write (ring, seq);/* reference */ -amdgpu_ring_write (ring,0xfffffff );/* mask */ +amdgpu_ring_write (ring,0xffffffff );/* mask */ amdgpu_ring_write (ring,SDMA_PKT_POLL_REGMEM_DW5_RETRY_COUNT (0xfff ) |SDMA_PKT_POLL_REGMEM_DW5_INTERVAL (4 ));/* retry count, poll interval */ }
Signature · 1 line
2.13.6
A message that is not in the archive (sent off-list or not yet received): 20180327213355.18249-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org
Huang Rui
Acked-byQuoted 4 lines · Alex Deucher
Needs to be a 32 bit mask.
Signed-off-by Alex Deucher <[email protected]>
Nice catch!
Quoted 66 lines
--- drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/cik_sdma.c +1
-1@@ -859,7 +859,7 @@ static void cik_sdma_ring_emit_pipeline_sync(struct amdgpu_ring *ring)amdgpu_ring_write (ring, addr &0xfffffffc );amdgpu_ring_write (ring,upper_32_bits (addr) &0xffffffff );amdgpu_ring_write (ring, seq);/* reference */ -amdgpu_ring_write (ring,0xfffffff );/* mask */ +amdgpu_ring_write (ring,0xffffffff );/* mask */ amdgpu_ring_write (ring, (0xfff <<16 ) |4 );/* retry count, poll interval */ }drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c +1
-1@@ -837,7 +837,7 @@ static void sdma_v2_4_ring_emit_pipeline_sync(struct amdgpu_ring *ring)amdgpu_ring_write (ring, addr &0xfffffffc );amdgpu_ring_write (ring,upper_32_bits (addr) &0xffffffff );amdgpu_ring_write (ring, seq);/* reference */ -amdgpu_ring_write (ring,0xfffffff );/* mask */ +amdgpu_ring_write (ring,0xffffffff );/* mask */ amdgpu_ring_write (ring,SDMA_PKT_POLL_REGMEM_DW5_RETRY_COUNT (0xfff ) |SDMA_PKT_POLL_REGMEM_DW5_INTERVAL (4 ));/* retry count, poll interval */ }drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +1
-1@@ -1105,7 +1105,7 @@ static void sdma_v3_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)amdgpu_ring_write (ring, addr &0xfffffffc );amdgpu_ring_write (ring,upper_32_bits (addr) &0xffffffff );amdgpu_ring_write (ring, seq);/* reference */ -amdgpu_ring_write (ring,0xfffffff );/* mask */ +amdgpu_ring_write (ring,0xffffffff );/* mask */ amdgpu_ring_write (ring,SDMA_PKT_POLL_REGMEM_DW5_RETRY_COUNT (0xfff ) |SDMA_PKT_POLL_REGMEM_DW5_INTERVAL (4 ));/* retry count, poll interval */ }drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +1
-1@@ -1121,7 +1121,7 @@ static void sdma_v4_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)amdgpu_ring_write (ring, addr &0xfffffffc );amdgpu_ring_write (ring,upper_32_bits (addr) &0xffffffff );amdgpu_ring_write (ring, seq);/* reference */ -amdgpu_ring_write (ring,0xfffffff );/* mask */ +amdgpu_ring_write (ring,0xffffffff );/* mask */ amdgpu_ring_write (ring,SDMA_PKT_POLL_REGMEM_DW5_RETRY_COUNT (0xfff ) |SDMA_PKT_POLL_REGMEM_DW5_INTERVAL (4 ));/* retry count, poll interval */ }Signature · 6 lines
2.13.6 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Am 28.03.2018 um 05:24 schrieb Huang Rui:
Quoted 7 lines · Alex Deucher
Quoted 4 lines
Needs to be a 32 bit mask.
Signed-off-by Alex Deucher <[email protected]>Nice catch!
Acked-by Huang Rui <[email protected]>
Indeed good catch!
Patch is Reviewed-by: Christian König <[email protected]> as well.
Quoted 63 lines
Quoted 63 lines
--- drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/cik_sdma.c +1
-1@@ -859,7 +859,7 @@ static void cik_sdma_ring_emit_pipeline_sync(struct amdgpu_ring *ring)amdgpu_ring_write (ring, addr &0xfffffffc );amdgpu_ring_write (ring,upper_32_bits (addr) &0xffffffff );amdgpu_ring_write (ring, seq);/* reference */ -amdgpu_ring_write (ring,0xfffffff );/* mask */ +amdgpu_ring_write (ring,0xffffffff );/* mask */ amdgpu_ring_write (ring, (0xfff <<16 ) |4 );/* retry count, poll interval */ }drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c +1
-1@@ -837,7 +837,7 @@ static void sdma_v2_4_ring_emit_pipeline_sync(struct amdgpu_ring *ring)amdgpu_ring_write (ring, addr &0xfffffffc );amdgpu_ring_write (ring,upper_32_bits (addr) &0xffffffff );amdgpu_ring_write (ring, seq);/* reference */ -amdgpu_ring_write (ring,0xfffffff );/* mask */ +amdgpu_ring_write (ring,0xffffffff );/* mask */ amdgpu_ring_write (ring,SDMA_PKT_POLL_REGMEM_DW5_RETRY_COUNT (0xfff ) |SDMA_PKT_POLL_REGMEM_DW5_INTERVAL (4 ));/* retry count, poll interval */ }drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +1
-1@@ -1105,7 +1105,7 @@ static void sdma_v3_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)amdgpu_ring_write (ring, addr &0xfffffffc );amdgpu_ring_write (ring,upper_32_bits (addr) &0xffffffff );amdgpu_ring_write (ring, seq);/* reference */ -amdgpu_ring_write (ring,0xfffffff );/* mask */ +amdgpu_ring_write (ring,0xffffffff );/* mask */ amdgpu_ring_write (ring,SDMA_PKT_POLL_REGMEM_DW5_RETRY_COUNT (0xfff ) |SDMA_PKT_POLL_REGMEM_DW5_INTERVAL (4 ));/* retry count, poll interval */ }drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +1
-1@@ -1121,7 +1121,7 @@ static void sdma_v4_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)amdgpu_ring_write (ring, addr &0xfffffffc );amdgpu_ring_write (ring,upper_32_bits (addr) &0xffffffff );amdgpu_ring_write (ring, seq);/* reference */ -amdgpu_ring_write (ring,0xfffffff );/* mask */ +amdgpu_ring_write (ring,0xffffffff );/* mask */ amdgpu_ring_write (ring,SDMA_PKT_POLL_REGMEM_DW5_RETRY_COUNT (0xfff ) |SDMA_PKT_POLL_REGMEM_DW5_INTERVAL (4 ));/* retry count, poll interval */ }Signature · 1 line
2.13.6
Quoted 8 lines
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx