Skip to contentSkip to conversation

dt-bindings: mtd-physmap: Add endianness supports

PATCH New Prabhakar Kushwaha 2 participants 4 messages Mar 28, 2018 – Mar 29, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v7 1/2 dt-bindings: mtd-physmap: Add endianness supports

Connection between flash and controller is not necessary to be always of same type. It may varies from platform to platform.

Adding endianness (optional) property to provide connection type information.

---
Changes for v2: updated subject
Changes for v3: fixed typo for "big-endian"
Changes for v4: Moved binding definition in mtd-physmap.txt as discussed at https://patchwork.ozlabs.org/patch/842543/
Changes for v5: Sending as it is
Changes for v6: Updated binding when endianness property is absent Changes for v7: Updated binding details

 Documentation/devicetree/bindings/mtd/mtd-physmap.txt | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/mtd/mtd-physmap.txt +7 -0
index 4a0a48bf4ecb..232fa12e90ef 100644
@@ -41,6 +41,13 @@ additional (optional) property is defined:
 
  - erase-size : The chip's physical erase block size in bytes.
 
+ The device tree may optionally contain endianness property.
+ little-endian or big-endian : It Represents the endianness that should be used
+                               by the controller to  properly read/write data
+			       from/to the flash. If this property is missing,
+			       the endianness is chosen by the system
+			       (potentially based on extra configuration options).
+
 The device tree may optionally contain sub-nodes describing partitions of the
 address space. See partition.txt for more detail.
 
Signature · 1 line
2.14.1
#1 lore raw

PATCH v7 1/2 dt-bindings: mtd-physmap: Add endianness supports

Quoted 5 lines · On Wed, 28 Mar 2018 11:14:43 +0530 Prabhakar Kushwaha…

Connection between flash and controller is not necessary to be always of same type. It may varies from platform to platform.

Adding endianness (optional) property to provide connection type information.

You forgot to adjust your commit message.

If you're okay, I'll replace your message by:

"
Provides a way to specify the endianness to use when accessing a memory-mapped flash.
"

Quoted 33 lines

---
Changes for v2: updated subject
Changes for v3: fixed typo for "big-endian"
Changes for v4: Moved binding definition in mtd-physmap.txt as discussed at https://patchwork.ozlabs.org/patch/842543/
Changes for v5: Sending as it is
Changes for v6: Updated binding when endianness property is absent Changes for v7: Updated binding details

 Documentation/devicetree/bindings/mtd/mtd-physmap.txt | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/mtd/mtd-physmap.txt +7 -0
index 4a0a48bf4ecb..232fa12e90ef 100644
@@ -41,6 +41,13 @@ additional (optional) property is defined:
 
  - erase-size : The chip's physical erase block size in bytes.
 
+ The device tree may optionally contain endianness property.
+ little-endian or big-endian : It Represents the endianness that should be used
+                               by the controller to  properly read/write data
+			       from/to the flash. If this property is missing,
+			       the endianness is chosen by the system
+			       (potentially based on extra configuration options).
+
 The device tree may optionally contain sub-nodes describing partitions of the
 address space. See partition.txt for more detail.
 
Signature · 3 lines
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v7 1/2 dt-bindings: mtd-physmap: Add endianness supports

Hi Boris,

Quoted 21 lines

-----Original Message-----
From: Boris Brezillon [mailto:boris.brezillon at bootlin.com]
Sent: Wednesday, March 28, 2018 2:00 PM
To: Prabhakar Kushwaha <[email protected]>
Cc: linux-mtd at lists.infradead.org; devicetree at vger.kernel.org; mark.rutland at arm.com; robh at kernel.org; boris.brezillon at free-electrons.com; Poonam Aggrwal <[email protected]>; Leo Li <[email protected]>; oss at buserror.net; computersforpeace at gmail.com; shawnguo at kernel.org; linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH 1/2][v7] dt-bindings: mtd-physmap: Add endianness supports

Quoted 5 lines · On Wed, 28 Mar 2018 11:14:43 +0530 Prabhakar Kushwaha…

Connection between flash and controller is not necessary to be always of same type. It may varies from platform to platform.

Adding endianness (optional) property to provide connection type information.

Quoted 9 lines

You forgot to adjust your commit message.

If you're okay, I'll replace your message by:

"
Provides a way to specify the endianness to use when accessing a memory- mapped flash.
"

Thanks for catching this. Please adjust as you suggested.

--prabhakar

#3 lore raw

PATCH v7 1/2 dt-bindings: mtd-physmap: Add endianness supports

Quoted 27 lines · On Wed, 28 Mar 2018 09:48:08 +0000 Prabhakar Kushwaha…

Hi Boris,

Quoted 25 lines

-----Original Message-----
From: Boris Brezillon [mailto:boris.brezillon at bootlin.com]
Sent: Wednesday, March 28, 2018 2:00 PM
To: Prabhakar Kushwaha <[email protected]>
Cc: linux-mtd at lists.infradead.org; devicetree at vger.kernel.org; mark.rutland at arm.com; robh at kernel.org; boris.brezillon at free-electrons.com; Poonam Aggrwal <[email protected]>; Leo Li <[email protected]>; oss at buserror.net; computersforpeace at gmail.com; shawnguo at kernel.org; linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH 1/2][v7] dt-bindings: mtd-physmap: Add endianness supports

Quoted 5 lines · On Wed, 28 Mar 2018 11:14:43 +0530 Prabhakar Kushwaha…

Connection between flash and controller is not necessary to be always of same type. It may varies from platform to platform.

Adding endianness (optional) property to provide connection type information.

You forgot to adjust your commit message.

If you're okay, I'll replace your message by:

Quoted 7 lines
Quoted 5 lines

"
Provides a way to specify the endianness to use when accessing a memory- mapped flash.
"

Thanks for catching this. Please adjust as you suggested.

Applied.

Thanks,

Boris

Quoted 4 lines

--prabhakar

Signature · 3 lines
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com