Skip to contentSkip to conversation

staging: rtl8723bs: Replace yield() call with cond_resched()

PATCH New Thomas Avery 1 participant 1 message Mar 28, 2018 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 staging: rtl8723bs: Replace yield() call with cond_resched()

Remove yield call(). yield does not guarantee progress, and should not be used. cond_resched() is a safe alternative.

---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +1 -1
index 7d7756e40bcb..fdcc5b28af22 100644
@@ -4263,7 +4263,7 @@ unsigned int send_beacon(struct adapter *padapter)
 		issue_beacon(padapter, 100);
 		issue++;
 		do {
-			yield();
+			cond_resched();
 			rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bxmitok));
 			poll++;
 		} while ((poll%10) != 0 && false == bxmitok && !padapter->bSurpriseRemoved && !padapter->bDriverStopped);
Signature · 6 lines
2.11.0

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel