fuzz: wrappers.c depends on x86_emulate.h
PATCH 1/1 fuzz: wrappers.c depends on x86_emulate.h
In my automated SLE_11 builds I often see failures like that:
[ 74s] wrappers.c:5:25: error: x86-emulate.h: No such file or directory
[ 74s] make[6]: *** [wrappers.o] Error 1
--- tools/fuzz/x86_instruction_emulator/Makefile | 2 ++ 1 file changed, 2 insertions(+)
tools/fuzz/x86_instruction_emulator/Makefile +2 -0
@@ -18,6 +18,8 @@ asm: asm/%: asm ; +wrappers.o: $(x86_emulate.h) + x86-emulate.c x86-emulate.h wrappers.c: %: [ -L $* ] || ln -sf $(XEN_ROOT)/tools/tests/x86_emulator/$*
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
tools/fuzz/x86_instruction_emulator/Makefile asm: · line 24
Quoted 11 lines
Quoted 1 line
Quoted 1 line · On 29.03.18 at 14:01, <[email protected]> wrote:
tools/fuzz/x86_instruction_emulator/Makefile +2
-0@@ -18,6 +18,8 @@ asm: asm/%: asm ; +wrappers.o: $(x86_emulate.h) + x86-emulate.c x86-emulate.h wrappers.c: %: [ -L $* ] || ln -sf $(XEN_ROOT)/tools/tests/x86_emulator/$*
It certainly feels odd to request a v2 on this simple a change, but the addition shouldn't be put in a random place. Instead we already have
# x86-emulate.c will be implicit for both x86-emulate.o x86-emulate-cov.o: x86_emulate/x86_emulate.c $(x86_emulate.h)
fuzz-emul.o fuzz-emulate-cov.o: $(x86_emulate.h)
which the new one should be grouped with. Otoh maybe I should just move the line while committing.
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel