Skip to contentSkip to conversation

net: mvneta: fix enable of all initialized RXQs

PATCH Applied Gregory CLEMENT 3 participants 3 messages Mar 30, 2018

Subsystems (3)
Networking Network drivers Marvell mvneta Ethernet driver
lore
Share & tools
lore

Gregory CLEMENT

author
#0 lore raw

PATCH 1/1 net: mvneta: fix enable of all initialized RXQs

From: Yelena Krivosheev <[email protected]>

In mvneta_port_up() we enable relevant RX and TX port queues by write queues bit map to an appropriate register.

q_map must be ZERO in the beginning of this process.

Signed-off-by Yelena Krivosheev <[email protected]>
Signed-off-by Gregory CLEMENT <[email protected]>
---
 drivers/net/ethernet/marvell/mvneta.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/marvell/mvneta.c +1 -0
index 25e9a551cc8c..3f6fb635738c 100644
@@ -1132,6 +1132,7 @@ static void mvneta_port_up(struct mvneta_port *pp)
 	}
 	mvreg_write(pp, MVNETA_TXQ_CMD, q_map);
 
+	q_map = 0;
 	/* Enable all initialized RXQs. */
 	for (queue = 0; queue < rxq_number; queue++) {
 		struct mvneta_rx_queue *rxq = &pp->rxqs[queue];
Signature · 1 line
2.16.2
Acked-by on v1 1/1
#1 lore raw

Hello,

Quoted 9 lines · Gregory CLEMENT

From: Yelena Krivosheev <[email protected]>

In mvneta_port_up() we enable relevant RX and TX port queues by write queues bit map to an appropriate register.

q_map must be ZERO in the beginning of this process.

Signed-off-by Yelena Krivosheev <[email protected]>
Signed-off-by Gregory CLEMENT <[email protected]>
Acked-by Thomas Petazzoni <[email protected]>

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
maintainer Applied
#2 lore raw
In reply to Gregory CLEMENT

From: Gregory CLEMENT <[email protected]>
Date: Fri, 30 Mar 2018 12:05:31 +0200

Quoted 9 lines

From: Yelena Krivosheev <[email protected]>

In mvneta_port_up() we enable relevant RX and TX port queues by write queues bit map to an appropriate register.

q_map must be ZERO in the beginning of this process.

Signed-off-by Yelena Krivosheev <[email protected]>
Signed-off-by Gregory CLEMENT <[email protected]>

Applied, thank you.