Skip to contentSkip to conversation

ISDN: eicon: message: remove redundant check

PATCH In review Gustavo A. R. Silva 2 participants 3 messages Mar 30, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ISDN: eicon: message: remove redundant check

Check on plci->internal_command is unnecessary.

Addresses-Coverity-ID: 1268778 ("Identical code for different branches")

---
 drivers/isdn/hardware/eicon/message.c | 2 --
 1 file changed, 2 deletions(-)
drivers/isdn/hardware/eicon/message.c +0 -2
index def7992..0ac18fc 100644
@@ -13886,8 +13886,6 @@ static void adjust_b_restore(dword Id, PLCI *plci, byte Rc)
 			dbug(1, dprintf("[%06lx] %s,%d: Adjust B restore failed",
 					UnMapId(Id), (char *)(FILE_), __LINE__));
 		}
-		if (plci->internal_command)
-			break;
 		break;
 	}
 }
Signature · 1 line
2.7.4
#1 lore raw
Quoted 1 line · Gustavo A. R. Silva

Check on plci->internal_command is unnecessary.

Probably all of these are unnecessary too:

$ for length in {7..2} ; do \
    grep-2.5.4 -rP --include=*.[ch] -n "^\t{$length,$length}break;\n\t{$(($length-1)),$(($length-1))}break;" * ; \
  done
drivers/staging/wilc1000/wilc_wlan.c:691:				break;
			break;
drivers/media/dvb-frontends/drxd_hard.c:2261:				break;
			break;
drivers/media/dvb-frontends/drxd_hard.c:2266:				break;
			break;
drivers/media/usb/gspca/sn9c20x.c:1860:			break;
		break;
drivers/isdn/i4l/isdn_common.c:624:			break;
		break;
drivers/isdn/i4l/isdn_common.c:642:			break;
		break;
drivers/isdn/i4l/isdn_common.c:654:			break;
		break;
drivers/isdn/hardware/eicon/message.c:13890:			break;
		break;
sound/usb/mixer_quirks.c:1832:			break;
		break;
#2 lore raw
Quoted 18 lines · Joe Perches
Quoted 1 line · Gustavo A. R. Silva

Check on plci->internal_command is unnecessary.

Probably all of these are unnecessary too:

$ for length in {7..2} ; do \
     grep-2.5.4 -rP --include=*.[ch] -n "^\t{$length,$length}break;\n\t{$(($length-1)),$(($length-1))}break;" * ; \
   done
drivers/staging/wilc1000/wilc_wlan.c:691:				break;
			break;
drivers/media/dvb-frontends/drxd_hard.c:2261:				break;
			break;
drivers/media/dvb-frontends/drxd_hard.c:2266:				break;
			break;
drivers/media/usb/gspca/sn9c20x.c:1860:			break;
		break;
drivers/isdn/i4l/isdn_common.c:624:			break;
		break;
Quoted 9 lines
drivers/isdn/i4l/isdn_common.c:642:			break;
		break;
drivers/isdn/i4l/isdn_common.c:654:			break;
		break;
drivers/isdn/hardware/eicon/message.c:13890:			break;
		break;
sound/usb/mixer_quirks.c:1832:			break;
		break;

Oh, cool.

I'll take a look at them.

Thanks, Joe.