wine: Depend on shared libraries
PATCH 1/1 wine: Depend on shared libraries
--- package/wine/Config.in | 1 + 1 file changed, 1 insertion(+)
package/wine/Config.in +1 -0
@@ -1,5 +1,6 @@ config BR2_PACKAGE_WINE bool "wine" + depends on !BR2_STATIC_LIBS # Wine only builds on certain architectures depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" || \ BR2_HOSTARCH = "powerpc" || BR2_HOSTARCH = "arm" || \
Signature · 1 line
2.7.4
PATCH 1/1 wine: Depend on shared libraries
Hi Andr?,
package/wine/Config.in line 3
Quoted 13 lines · Andr? Hentschel
Signed-off-by Andr? Hentschel <[email protected]>--- package/wine/Config.in | 1 + 1 file changed, 1 insertion(+)package/wine/Config.in +1
-0@@ -1,5 +1,6 @@ config BR2_PACKAGE_WINE bool "wine" + depends on !BR2_STATIC_LIBS
A dependency comment would be nice.
baruch
Quoted 3 lines
package/wine/Config.in +0
-0# Wine only builds on certain architectures depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" || \ BR2_HOSTARCH = "powerpc" || BR2_HOSTARCH = "arm" || \
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -PATCH 1/1 wine: Depend on shared libraries
In reply to André HentschelHello,
package/wine/Config.in line 3
Quoted 13 lines · Andr? Hentschel
Signed-off-by Andr? Hentschel <[email protected]>--- package/wine/Config.in | 1 + 1 file changed, 1 insertion(+)package/wine/Config.in +1
-0@@ -1,5 +1,6 @@ config BR2_PACKAGE_WINE bool "wine" + depends on !BR2_STATIC_LIBS
It would be good to explain in the commit log why you're adding this, and perhaps add a comment on top of this line to explain why we have this dependency.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com
PATCH 1/1 wine: Depend on shared libraries
Hello Andr?,
Quoted 6 lines · Thomas Petazzoni
Quoted 5 lines · Andr? Hentschel
Signed-off-by Andr? Hentschel <[email protected]>--- package/wine/Config.in | 1 + 1 file changed, 1 insertion(+)
Quoted 12 lines
package/wine/Config.in line 3
Quoted 8 lines
package/wine/Config.in +1
-0@@ -1,5 +1,6 @@ config BR2_PACKAGE_WINE bool "wine" + depends on !BR2_STATIC_LIBSIt would be good to explain in the commit log why you're adding this, and perhaps add a comment on top of this line to explain why we have this dependency.
Ping ? :-)
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 wine: Depend on shared libraries
In reply to André HentschelHello,
Quoted 1 line · Andr? Hentschel
Signed-off-by Andr? Hentschel <[email protected]>
I did a test build, and indeed discovered that wine tries to unconditionally build a shared library.
I've added a Config.in comment, which required adding a BR2_PACKAGE_WINE_ARCH_SUPPORTS hidden boolean, and extended the commit log significantly to explain why we do this change.
And then I've applied.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 wine: Depend on shared libraries
Am 31.03.2018 um 22:43 schrieb Thomas Petazzoni:
Quoted 12 lines
Hello,
Quoted 1 line · Andr? Hentschel
Signed-off-by Andr? Hentschel <[email protected]>I did a test build, and indeed discovered that wine tries to unconditionally build a shared library.
I've added a Config.in comment, which required adding a
BR2_PACKAGE_WINE_ARCH_SUPPORTShidden boolean, and extended the commit log significantly to explain why we do this change.
Quoted 6 lines
And then I've applied.
Thanks,
Thomas
Thanks for that! Had no time for it yet