Skip to contentSkip to conversation

check-package: Flag usage of '\t \\$'.

PATCH New Nicolas Cavallari 3 participants 3 messages Mar 7, 2018 – Mar 31, 2018

lore
Share & tools
lore

Nicolas Cavallari

author
#0 lore raw

PATCH 1/1 check-package: Flag usage of '\t \\$'.

check-package would flag tabs before a backslash ('\t\\'),
two spaces before a backslash (' \\') but would not flag a tab before space before backslash ('\t \\'), allowing someone to bypass the check.

Signed-off-by Nicolas Cavallari <[email protected]>

---
There is no occurence of this in buildroot.

 utils/checkpackagelib/lib_mk.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
utils/checkpackagelib/lib_mk.py +1 -1
index 2df2e1a884..cfd4d05117 100644
@@ -123,7 +123,7 @@ class RemoveDefaultPackageSourceVariable(_CheckFunction):
 
 
 class SpaceBeforeBackslash(_CheckFunction):
-    TAB_OR_MULTIPLE_SPACES_BEFORE_BACKSLASH = re.compile(r"^.*(  |\t)\\$")
+    TAB_OR_MULTIPLE_SPACES_BEFORE_BACKSLASH = re.compile(r"^.*(  |\t ?)\\$")
 
     def check_line(self, lineno, text):
         if self.TAB_OR_MULTIPLE_SPACES_BEFORE_BACKSLASH.match(text.rstrip()):
Signature · 1 line
2.16.2
Applied
#2 lore raw

PATCH 1/1 check-package: Flag usage of '\t \\$'.

In reply to Nicolas Cavallari

Hello,

Quoted 10 lines · Nicolas Cavallari

check-package would flag tabs before a backslash ('\t\\'),
two spaces before a backslash (' \\') but would not flag a tab before space before backslash ('\t \\'), allowing someone to bypass the check.

Signed-off-by Nicolas Cavallari <[email protected]>

---
There is no occurence of this in buildroot.

 utils/checkpackagelib/lib_mk.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com