Skip to contentSkip to conversation

package/apache: fix lua detection

PATCH New Bernd Kuhls 2 participants 2 messages Apr 1, 2018

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/apache: fix lua detection

Patch suggested by Thomas: Adding a path to --with-lua disables pkgconf-based detection of lua, which in some cases needs libdl.

This patch removes --with-lua which fixes
http://autobuild.buildroot.net/results/cc1/cc13f4cef9cf6f18615d58f1d83b233812f19fa0/

---
v2: rely on pkgconf (Thomas)

 package/apache/apache.mk | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
package/apache/apache.mk +1 -3
index 3b39be4a40..23414fe44d 100644
@@ -57,9 +57,7 @@ APACHE_CONF_OPTS += \
 endif
 
 ifeq ($(BR2_PACKAGE_LUA),y)
-APACHE_CONF_OPTS += \
-	--enable-lua \
-	--with-lua=$(STAGING_DIR)/usr
+APACHE_CONF_OPTS += --enable-lua
 APACHE_DEPENDENCIES += lua
 else
 APACHE_CONF_OPTS += --disable-lua
Signature · 1 line
2.14.2
#1 lore raw

PATCH v2 1/1 package/apache: fix lua detection

Hello,

Quoted 9 lines · Bernd Kuhls

Patch suggested by Thomas: Adding a path to --with-lua disables pkgconf-based detection of lua, which in some cases needs libdl.

This patch removes --with-lua which fixes
http://autobuild.buildroot.net/results/cc1/cc13f4cef9cf6f18615d58f1d83b233812f19fa0/

---
v2: rely on pkgconf (Thomas)

Ah, see how this solution is much simpler and logical? Thanks for checking that it was indeed working. Applied!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com