Remove Kodi ADSP packages

PATCH New Bernd Kuhls 2 participants 4 messages Apr 1, 2018

lore

Share & tools

lore

Bernd Kuhls

author

2018-04-01 13:58 UTC #0 lore raw

PATCH 1/1 Remove Kodi ADSP packages

They are unmaintained and not in a working state, for details see Kodi PR 13723.

Signed-off-by Bernd Kuhls <[email protected]>

---
 Config.in.legacy                                          | 15 +++++++++++++++
 package/kodi-adsp-basic/Config.in                         | 12 ------------
 package/kodi-adsp-basic/kodi-adsp-basic.hash              |  2 --
 package/kodi-adsp-basic/kodi-adsp-basic.mk                | 15 ---------------
 package/kodi-adsp-freesurround/Config.in                  | 11 -----------
 .../kodi-adsp-freesurround/kodi-adsp-freesurround.hash    |  2 --
 package/kodi-adsp-freesurround/kodi-adsp-freesurround.mk  | 15 ---------------
 package/kodi/Config.in                                    |  5 -----
 8 files changed, 15 insertions(+), 62 deletions(-)
 delete mode 100644 package/kodi-adsp-basic/Config.in
 delete mode 100644 package/kodi-adsp-basic/kodi-adsp-basic.hash
 delete mode 100644 package/kodi-adsp-basic/kodi-adsp-basic.mk
 delete mode 100644 package/kodi-adsp-freesurround/Config.in
 delete mode 100644 package/kodi-adsp-freesurround/kodi-adsp-freesurround.hash
 delete mode 100644 package/kodi-adsp-freesurround/kodi-adsp-freesurround.mk

Config.in.legacy +15 -0

index fa083eaf79..2e3b1b6001 100644
@@ -142,6 +142,21 @@ comment "unpredictable ways.                                 "
 comment "----------------------------------------------------"
 endif
 
+###############################################################################
+comment "Legacy options removed in 2018.05"
+
+config BR2_PACKAGE_KODI_ADSP_BASIC
+	bool "kodi-adsp-basic package removed"
+	select BR2_LEGACY
+	help
+	  kodi-adsp-basic is unmaintained
+
+config BR2_PACKAGE_KODI_ADSP_FREESURROUND
+	bool "kodi-adsp-freesurround package removed"
+	select BR2_LEGACY
+	help
+	  kodi-adsp-freesurround is unmaintained
+
 ###############################################################################
 comment "Legacy options removed in 2018.02"

package/kodi-adsp-basic/Config.in deleted +0 ~~-12~~

deleted file mode 100644
index 87bdd1973c..0000000000
@@ -1,12 +0,0 @@
-config BR2_PACKAGE_KODI_ADSP_BASIC
-	bool "kodi-adsp-basic"
-	select BR2_PACKAGE_LIBPLATFORM
-	select BR2_PACKAGE_KODI_PLATFORM
-	help
-	  This add-on contains basic dsp related parts to handle
-	  speaker delays, channel related volume amplification. As
-	  mode it supports a Dolby Pro Logic II compatible
-	  multichannel downmix to stereo, which becomes available if
-	  only 2 channel output on Kodi is selected.
-
-	  https://github.com/kodi-adsp/adsp.basic

package/kodi-adsp-basic/kodi-adsp-basic.hash deleted +0 -2

deleted file mode 100644
index 10dd773c1e..0000000000
@@ -1,2 +0,0 @@
-# Locally computed
-sha256 d6ef031157ceb825a6e6ba114fb20c622ef7f396ddd17ae8bf1954aab25bc2af  kodi-adsp-basic-2ae604e591346741324663260696cfa231931870.tar.gz

package/kodi-adsp-basic/kodi-adsp-basic.mk deleted +0 ~~-15~~

deleted file mode 100644
index bb114a41ea..0000000000
@@ -1,15 +0,0 @@
-################################################################################
-#
-# kodi-adsp-basic
-#
-################################################################################
-
-# This cset is on the branch 'Krypton'
-# When Kodi is updated, then this should be updated to the corresponding branch
-KODI_ADSP_BASIC_VERSION = 2ae604e591346741324663260696cfa231931870
-KODI_ADSP_BASIC_SITE = $(call github,kodi-adsp,adsp.basic,$(KODI_ADSP_BASIC_VERSION))
-KODI_ADSP_BASIC_LICENSE = GPL-3.0+
-KODI_ADSP_BASIC_LICENSE_FILES = LICENSE.md
-KODI_ADSP_BASIC_DEPENDENCIES = libplatform kodi-platform
-
-$(eval $(cmake-package))

package/kodi-adsp-freesurround/Config.in deleted +0 ~~-11~~

deleted file mode 100644
index 80aadf1d40..0000000000
@@ -1,11 +0,0 @@
-config BR2_PACKAGE_KODI_ADSP_FREESURROUND
-	bool "kodi-adsp-freesurround"
-	select BR2_PACKAGE_LIBPLATFORM
-	select BR2_PACKAGE_KODI_PLATFORM
-	help
-	  FreeSurround is meant to be the KODI equivalent of your
-	  hi-fi receiver's Dolby ProLogic II button. It's purpose is
-	  to decode surround information from your stereo music and to
-	  produce multichannel output from it.
-
-	  https://github.com/kodi-adsp/adsp.freesurround

package/kodi-adsp-freesurround/kodi-adsp-freesurround.hash deleted +0 -2

deleted file mode 100644
index 2649bbdcbf..0000000000
@@ -1,2 +0,0 @@
-# Locally computed
-sha256 cf6985be6839530027861b54e2146693d05e802363281ef6f8c1f352dbf94b5c  kodi-adsp-freesurround-34f50406bcba22e364711562e5b9205e57ae844b.tar.gz

package/kodi-adsp-freesurround/kodi-adsp-freesurround.mk deleted +0 ~~-15~~

deleted file mode 100644
index 927af74da7..0000000000
@@ -1,15 +0,0 @@
-################################################################################
-#
-# kodi-adsp-freesurround
-#
-################################################################################
-
-# This cset is on the branch 'Krypton'
-# When Kodi is updated, then this should be updated to the corresponding branch
-KODI_ADSP_FREESURROUND_VERSION = 34f50406bcba22e364711562e5b9205e57ae844b
-KODI_ADSP_FREESURROUND_SITE = $(call github,kodi-adsp,adsp.freesurround,$(KODI_ADSP_FREESURROUND_VERSION))
-KODI_ADSP_FREESURROUND_LICENSE = GPL-3.0+
-KODI_ADSP_FREESURROUND_LICENSE_FILES = LICENSE.md
-KODI_ADSP_FREESURROUND_DEPENDENCIES = libplatform kodi-platform
-
-$(eval $(cmake-package))

package/kodi/Config.in +0 -5

index 071c03d640..d96d546bf9 100644
@@ -280,11 +280,6 @@ menu "Audio decoder addons"
 	source "package/kodi-audiodecoder-vgmstream/Config.in"
 endmenu
 
-menu "Audio DSP addons"
-	source "package/kodi-adsp-basic/Config.in"
-	source "package/kodi-adsp-freesurround/Config.in"
-endmenu
-
 menu "Audio encoder addons"
 	source "package/kodi-audioencoder-flac/Config.in"
 	source "package/kodi-audioencoder-lame/Config.in"

Signature · 1 line

2.14.2

Thomas Petazzoni

2018-04-01 14:21 UTC #1 lore raw

PATCH 1/1 Remove Kodi ADSP packages

Hello,

The title should have been:

package/kodi-adsp-*: remove packages

Quoted 2 lines · Bernd Kuhls

They are unmaintained and not in a working state, for details see Kodi PR 13723.

"Kodi PR 13723" is not very useful. A link is much better, so I've replaced this by a link instead. Please use links when you refer to Kodi PRs in your other patches. Thanks!

Applied with those changes, thanks.

Best regards,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Bernd Kuhls

author

2018-04-01 14:31 UTC #2 lore raw

PATCH 1/1 Remove Kodi ADSP packages

Am Sun, 01 Apr 2018 16:21:14 +0200 schrieb Thomas Petazzoni:

Quoted 3 lines

"Kodi PR 13723" is not very useful. A link is much better, so I've replaced this by a link instead. Please use links when you refer to Kodi PRs in your other patches. Thanks!

Hi Thomas,

I did not post a link on purpose because it will spam the original pull request ( https://github.com/xbmc/xbmc/pull/13723 ), like you did right now ;)

Regards, Bernd

Thomas Petazzoni

2018-04-01 14:42 UTC #3 lore raw

PATCH 1/1 Remove Kodi ADSP packages

Hello,

Quoted 3 lines · Bernd Kuhls

I did not post a link on purpose because it will spam the original pull request ( https://github.com/xbmc/xbmc/pull/13723 ), like you did right now ;)

Meh. Links are really much, much more practical. I think in this case, what Github does is really a mis-feature, it should be normal for projects to reference PRs from other projects by link.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com