Skip to contentSkip to conversation

remoteproc: fix null pointer dereference on glink only platforms

PATCH In review Sibi Sankar 2 participants 2 messages Apr 3, 2018 – Apr 6, 2018

Subsystems (2)
Arm Qualcomm mailing list Remote processor (remoteproc)
lore
Share & tools
lore

Sibi Sankar

author
#0 lore raw

PATCH 1/1 remoteproc: fix null pointer dereference on glink only platforms

Currently calling list_del on smd subdev remove path results in null pointer dereference on glink only platforms. Fix this by adding safety checks in glink/smd subdev remove paths.

Signed-off-by Sibi Sankar <[email protected]>
---
 drivers/remoteproc/qcom_common.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/remoteproc/qcom_common.c +6 -0
index 00602499713f..a0cd6a50913f 100644
@@ -74,6 +74,9 @@ EXPORT_SYMBOL_GPL(qcom_add_glink_subdev);
  */
 void qcom_remove_glink_subdev(struct rproc *rproc, struct qcom_rproc_glink *glink)
 {
+	if (!glink->node)
+		return;
+
 	rproc_remove_subdev(rproc, &glink->subdev);
 	of_node_put(glink->node);
 }

@@ -121,6 +124,9 @@ EXPORT_SYMBOL_GPL(qcom_add_smd_subdev);
  */
 void qcom_remove_smd_subdev(struct rproc *rproc, struct qcom_rproc_subdev *smd)
 {
+	if (!smd->node)
+		return;
+
 	rproc_remove_subdev(rproc, &smd->subdev);
 	of_node_put(smd->node);
 }
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#1 lore raw
Quoted 5 lines · Sibi Sankar

Currently calling list_del on smd subdev remove path results in null pointer dereference on glink only platforms. Fix this by adding safety checks in glink/smd subdev remove paths.

Signed-off-by Sibi Sankar <[email protected]>

Thanks Sibi.

Regards,
Bjorn