Skip to contentSkip to conversation

ARM: s3c24xx: mini2440: use device properties for at24 eeprom

PATCH Applied Bartosz Golaszewski 2 participants 3 messages Apr 4, 2018 – Apr 16, 2018

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Bartosz Golaszewski

author
#0 lore raw

PATCH 1/1 ARM: s3c24xx: mini2440: use device properties for at24 eeprom

We want to work towards phasing out the at24_platform_data structure. There are few users and its contents can be represented using generic device properties. Using device properties only will allow us to significantly simplify the at24 configuration code.

Remove the at24_platform_data structure and replace it with an array of property entries. Drop the byte_len/size property, as the model name already implies the EEPROM's size.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 arch/arm/mach-s3c24xx/mach-mini2440.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm/mach-s3c24xx/mach-mini2440.c +5 -5
index 95753e0bc073..f9fc1f8d2b28 100644
@@ -20,7 +20,7 @@
 #include <linux/serial_core.h>
 #include <linux/serial_s3c.h>
 #include <linux/dm9000.h>
-#include <linux/platform_data/at24.h>
+#include <linux/property.h>
 #include <linux/platform_device.h>
 #include <linux/gpio_keys.h>
 #include <linux/i2c.h>

@@ -481,15 +481,15 @@ static struct platform_device mini2440_audio = {
 /*
  * I2C devices
  */
-static struct at24_platform_data at24c08 = {
-	.byte_len	= SZ_8K / 8,
-	.page_size	= 16,
+static const struct property_entry mini2440_at24_properties[] = {
+	PROPERTY_ENTRY_U32("pagesize", 16),
+	{ }
 };
 
 static struct i2c_board_info mini2440_i2c_devs[] __initdata = {
 	{
 		I2C_BOARD_INFO("24c08", 0x50),
-		.platform_data = &at24c08,
+		.properties = mini2440_at24_properties,
 	},
 };
Signature · 1 line
2.16.3
maintainer
#1 lore raw
Quoted 10 lines · Bartosz Golaszewski

We want to work towards phasing out the at24_platform_data structure. There are few users and its contents can be represented using generic device properties. Using device properties only will allow us to significantly simplify the at24 configuration code.

Remove the at24_platform_data structure and replace it with an array of property entries. Drop the byte_len/size property, as the model name already implies the EEPROM's size.

Signed-off-by Bartosz Golaszewski <[email protected]>

Looks ok, I will take it after merge window.

Best regards,
Krzysztof

maintainer Applied
#2 lore raw
In reply to Bartosz Golaszewski
Quoted 5 lines · Bartosz Golaszewski

We want to work towards phasing out the at24_platform_data structure. There are few users and its contents can be represented using generic device properties. Using device properties only will allow us to significantly simplify the at24 configuration code.

Quoted 9 lines

Remove the at24_platform_data structure and replace it with an array of property entries. Drop the byte_len/size property, as the model name already implies the EEPROM's size.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 arch/arm/mach-s3c24xx/mach-mini2440.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Thanks, applied.

Best regards,
Krzysztof