qtwebkit: Update to latest on 5.9 branch
PATCH 1/2 qtwebkit: Update to latest on 5.9 branch
--- recipes-qt/qt5/qtwebkit_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt/qt5/qtwebkit_git.bb +1 -1
@@ -89,4 +89,4 @@ export RUBYLIB="${STAGING_DATADIR_NATIVE}/rubygems:${STAGING_LIBDIR_NATIVE}/ruby QT_MODULE_BRANCH = "5.9" -SRCREV = "97c4a80a1282c8c3eaa343011286b76fd4838c5f" +SRCREV = "bd0657f98aff85b9f06d85a8cf4da6a27f61a56e"
Signature · 1 line
2.16.3
PATCH v2 2/2 qtwebkit: Fix build on armv7ve (rpi)
---
v1 -> v2:
- Drop disabling GI
recipes-qt/qt5/qtwebkit_git.bb | 8 ++++++++ 1 file changed, 8 insertions(+)
recipes-qt/qt5/qtwebkit_git.bb +8 -0
@@ -18,6 +18,14 @@ DEPENDS += "qtbase qtdeclarative icu ruby-native sqlite3 glib-2.0 libxslt gperf- ARM_INSTRUCTION_SET_armv4 = "arm" ARM_INSTRUCTION_SET_armv5 = "arm" +# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474 +# https://bugs.webkit.org/show_bug.cgi?id=159880 +# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime. +# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 (-mthumb). +ARM_INSTRUCTION_SET_armv7a = "thumb" +ARM_INSTRUCTION_SET_armv7r = "thumb" +ARM_INSTRUCTION_SET_armv7ve = "thumb" + # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10 # 5.10.meta-qt5.1 SRC_URI += "\
Signature · 1 line
2.16.3
Re: [meta-qt5][PATCH V2 2/2] qtwebkit: Fix build on armv7ve (rpi)
Quoted 28 lines · Khem Raj
Signed-off-by Khem Raj <[email protected]>---
v1 -> v2:
- Drop disabling GIrecipes-qt/qt5/qtwebkit_git.bb | 8 ++++++++ 1 file changed, 8 insertions(+)recipes-qt/qt5/qtwebkit_git.bb +8
-1@@ -18,6 +18,14 @@ DEPENDS += "qtbase qtdeclarative icu ruby-native sqlite3 glib-2.0 libxslt gperf- ARM_INSTRUCTION_SET_armv4 = "arm" ARM_INSTRUCTION_SET_armv5 = "arm" +# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474 +# https://bugs.webkit.org/show_bug.cgi?id=159880 +# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime. +# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 (-mthumb). +ARM_INSTRUCTION_SET_armv7a = "thumb" +ARM_INSTRUCTION_SET_armv7r = "thumb" +ARM_INSTRUCTION_SET_armv7ve = "thumb" + # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10 # 5.10.meta-qt5.1 SRC_URI += "\ --
Quoted 2 lines
2.16.3
I've checked the links you are referring: Both
* are related to webkit and from 2016
* deal with runtime errors not build errors as referred in patch description.
So what do you want to fix exactly?
Andreas
Re: [meta-qt5][PATCH V2 2/2] qtwebkit: Fix build on armv7ve (rpi)
Quoted 33 lines · Andreas Müller
Quoted 28 lines · Khem Raj
Signed-off-by Khem Raj <[email protected]>---
v1 -> v2:
- Drop disabling GIrecipes-qt/qt5/qtwebkit_git.bb | 8 ++++++++ 1 file changed, 8 insertions(+)recipes-qt/qt5/qtwebkit_git.bb +8
-1@@ -18,6 +18,14 @@ DEPENDS += "qtbase qtdeclarative icu ruby-native sqlite3 glib-2.0 libxslt gperf- ARM_INSTRUCTION_SET_armv4 = "arm" ARM_INSTRUCTION_SET_armv5 = "arm" +# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474 +# https://bugs.webkit.org/show_bug.cgi?id=159880 +# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime. +# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 (-mthumb). +ARM_INSTRUCTION_SET_armv7a = "thumb" +ARM_INSTRUCTION_SET_armv7r = "thumb" +ARM_INSTRUCTION_SET_armv7ve = "thumb" + # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10 # 5.10.meta-qt5.1 SRC_URI += "\ --Quoted 2 lines
2.16.3
I've checked the links you are referring: Both
Quoted 5 lines
* are related to webkit and from 2016
* deal with runtime errors not build errors as referred in patch description.So what do you want to fix exactly?
I have looked into this further and found that I stumbled for same
commit 511a3764506ce6bbdc5e9441a8f4e9d862ea1102
Author: Andreas Müller <[email protected]> Date: Mon Jan 4 11:04:16 2016 +0100
qtscript/qtwebkit: disable thumb for armv4 and armv5 only to fix
segfault on armv7
Curently recipe has
ARM_INSTRUCTION_SET_armv4 = "arm"ARM_INSTRUCTION_SET_armv5 = "arm"
Isn't thumb default any more?
Andreas
Re: [meta-qt5][PATCH V2 2/2] qtwebkit: Fix build on armv7ve (rpi)
Quoted 48 lines · Andreas Müller
Quoted 33 lines · Andreas Müller
Quoted 28 lines · Khem Raj
Signed-off-by Khem Raj <[email protected]>---
v1 -> v2:
- Drop disabling GIrecipes-qt/qt5/qtwebkit_git.bb | 8 ++++++++ 1 file changed, 8 insertions(+)recipes-qt/qt5/qtwebkit_git.bb +8
-1@@ -18,6 +18,14 @@ DEPENDS += "qtbase qtdeclarative icu ruby-native sqlite3 glib-2.0 libxslt gperf- ARM_INSTRUCTION_SET_armv4 = "arm" ARM_INSTRUCTION_SET_armv5 = "arm" +# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474 +# https://bugs.webkit.org/show_bug.cgi?id=159880 +# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime. +# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 (-mthumb). +ARM_INSTRUCTION_SET_armv7a = "thumb" +ARM_INSTRUCTION_SET_armv7r = "thumb" +ARM_INSTRUCTION_SET_armv7ve = "thumb" + # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10 # 5.10.meta-qt5.1 SRC_URI += "\ --Quoted 2 lines
2.16.3
I've checked the links you are referring: Both
Quoted 5 lines
* are related to webkit and from 2016
* deal with runtime errors not build errors as referred in patch description.So what do you want to fix exactly?
I have looked into this further and found that I stumbled for same
commit
511a3764506ce6bbdc5e9441a8f4e9d862ea1102Author: Andreas Müller <[email protected]> Date: Mon Jan 4 11:04:16 2016 +0100qtscript/qtwebkit: disable thumb for armv4 and armv5 only to fix
segfault on armv7
Quoted 7 lines
Curently recipe has
ARM_INSTRUCTION_SET_armv4= "arm"ARM_INSTRUCTION_SET_armv5= "arm"Isn't thumb default any more?
Thumb-1 doesn't really work since it shows up with register allocation errors with gcc.
thumb2 is fine for armv6+
Quoted 1 line
Andreas
Re: [meta-qt5][PATCH V2 2/2] qtwebkit: Fix build on armv7ve (rpi)
Quoted 54 lines · Khem Raj
Quoted 53 lines · Andreas Müller
Quoted 33 lines · Andreas Müller
Quoted 28 lines · Khem Raj
Signed-off-by Khem Raj <[email protected]>---
v1 -> v2:
- Drop disabling GIrecipes-qt/qt5/qtwebkit_git.bb | 8 ++++++++ 1 file changed, 8 insertions(+)recipes-qt/qt5/qtwebkit_git.bb +8
-1@@ -18,6 +18,14 @@ DEPENDS += "qtbase qtdeclarative icu ruby-native sqlite3 glib-2.0 libxslt gperf- ARM_INSTRUCTION_SET_armv4 = "arm" ARM_INSTRUCTION_SET_armv5 = "arm" +# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474 +# https://bugs.webkit.org/show_bug.cgi?id=159880 +# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime. +# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 (-mthumb). +ARM_INSTRUCTION_SET_armv7a = "thumb" +ARM_INSTRUCTION_SET_armv7r = "thumb" +ARM_INSTRUCTION_SET_armv7ve = "thumb" + # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10 # 5.10.meta-qt5.1 SRC_URI += "\ --Quoted 2 lines
2.16.3
I've checked the links you are referring: Both
Quoted 5 lines
* are related to webkit and from 2016
* deal with runtime errors not build errors as referred in patch description.So what do you want to fix exactly?
I have looked into this further and found that I stumbled for same
commit
511a3764506ce6bbdc5e9441a8f4e9d862ea1102Author: Andreas Müller <[email protected]> Date: Mon Jan 4 11:04:16 2016 +0100qtscript/qtwebkit: disable thumb for armv4 and armv5 only to fix
segfault on armv7Curently recipe has
ARM_INSTRUCTION_SET_armv4= "arm"ARM_INSTRUCTION_SET_armv5= "arm"
Quoted 7 lines
Quoted 2 lines
Isn't thumb default any more?
Thumb-1 doesn't really work since it shows up with register allocation errors with gcc.
thumb2 is fine for armv6+
Sorry for causing confusion - what I meant: Isn't thumb2 default for armv7 anymore (particularly RasPI > 1). If thumb2 is still default for armv7 there is no need to add it explicitly here. It does not do any harm but it is not necessary.
Andreas
Re: [meta-qt5][PATCH V2 2/2] qtwebkit: Fix build on armv7ve (rpi)
Quoted 64 lines · Andreas Müller
Quoted 1 line · Khem Raj
On Wed, Apr 4, 2018 at 1:45 PM, Andreas Müller <[email protected]>
Quoted 1 line · wrote:
Quoted 1 line
On Wed, Apr 4, 2018 at 10:25 PM, Andreas Müller <
Quoted 10 lines · [email protected]> wrote:
Quoted 10 lines
Quoted 10 lines · Khem Raj
recipes-qt/qt5/
Quoted 9 lines
Signed-off-by Khem Raj <[email protected]>---
v1 -> v2:
- Drop disabling GIrecipes-qt/qt5/qtwebkit_git.bb | 8 ++++++++ 1 file changed, 8 insertions(+)recipes-qt/qt5/ renamed from recipes-qt/qt5/qtwebkit_git.bb +0
-0qtwebkit_git.bb
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
recipes-qt/qt5/qtwebkit_git.bb DEPENDS += "qtbase qtdeclarative icu ruby-native
Quoted 4 lines
index e8c0868..c8e8328 100644
recipes-qt/qt5/qtwebkit_git.bb +0
-0@@ -18,6 +18,14 @@ DEPENDS += "qtbase qtdeclarative icu ruby-nativesqlite3 glib-2.0 libxslt gperf-
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
recipes-qt/qt5/qtwebkit_git.bb DEPENDS += "qtbase qtdeclarative icu ruby-native sqlite3 glib-2.0 libxslt gperf-
Quoted 7 lines
recipes-qt/qt5/qtwebkit_git.bb +4
-0ARM_INSTRUCTION_SET_armv4 = "arm" ARM_INSTRUCTION_SET_armv5 = "arm" +# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474 +# https://bugs.webkit.org/show_bug.cgi?id=159880 +# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime. +# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2(-mthumb).
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 10 lines
recipes-qt/qt5/qtwebkit_git.bb +4
-1+ARM_INSTRUCTION_SET_armv7a = "thumb" +ARM_INSTRUCTION_SET_armv7r = "thumb" +ARM_INSTRUCTION_SET_armv7ve = "thumb" + # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10 # 5.10.meta-qt5.1 SRC_URI += "\ --2.16.3
I've checked the links you are referring: Both
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
* are related to webkit and from 2016
* deal with runtime errors not build errors as referred in patchdescription.
Quoted 20 lines
Quoted 19 lines
Quoted 3 lines
So what do you want to fix exactly?
I have looked into this further and found that I stumbled for same
commit
511a3764506ce6bbdc5e9441a8f4e9d862ea1102Author: Andreas Müller <[email protected]> Date: Mon Jan 4 11:04:16 2016 +0100qtscript/qtwebkit: disable thumb for armv4 and armv5 only to fix
segfault on armv7Curently recipe has
ARM_INSTRUCTION_SET_armv4= "arm"ARM_INSTRUCTION_SET_armv5= "arm"Isn't thumb default any more?
Quoted 8 lines
Quoted 4 lines
Thumb-1 doesn't really work since it shows up with register allocation errors with gcc.
thumb2 is fine for armv6+Sorry for causing confusion - what I meant: Isn't thumb2 default for armv7 anymore (particularly RasPI > 1). If thumb2 is still default for armv7 there is no need to add it explicitly here. It does not do any harm but it is not necessary.
Distros are free to choose ISA so we really can not rely on the fact when default tune was to use thumb 2 moreover it’s not default
Quoted 4 lines
Andreas
Re: [meta-qt5][PATCH V2 2/2] qtwebkit: Fix build on armv7ve (rpi)
Quoted 80 lines · Khem Raj
Quoted 66 lines · Andreas Müller
Quoted 64 lines · Khem Raj
Quoted 61 lines · Andreas Müller
Quoted 37 lines · Andreas Müller
Quoted 32 lines · Khem Raj
Signed-off-by Khem Raj <[email protected]>---
v1 -> v2:
- Drop disabling GIrecipes-qt/qt5/qtwebkit_git.bb | 8 ++++++++ 1 file changed, 8 insertions(+)recipes-qt/qt5/qtwebkit_git.bb +0
-0@@ -18,6 +18,14 @@ DEPENDS += "qtbase qtdeclarative icu ruby-nativesqlite3 glib-2.0 libxslt gperf-
ARM_INSTRUCTION_SET_armv4= "arm"
ARM_INSTRUCTION_SET_armv5= "arm"recipes-qt/qt5/qtwebkit_git.bb +3
-0+# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474 +# https://bugs.webkit.org/show_bug.cgi?id=159880 +# JSC JIT can build on ARMv7 with -marm, but doesn't work onruntime.
+# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 (-mthumb).recipes-qt/qt5/qtwebkit_git.bb +4
-1+ARM_INSTRUCTION_SET_armv7a = "thumb" +ARM_INSTRUCTION_SET_armv7r = "thumb" +ARM_INSTRUCTION_SET_armv7ve = "thumb" + # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10 # 5.10.meta-qt5.1 SRC_URI += "\ --Quoted 2 lines
2.16.3
I've checked the links you are referring: Both
Quoted 6 lines
* are related to webkit and from 2016
* deal with runtime errors not build errors as referred in patch description.So what do you want to fix exactly?
I have looked into this further and found that I stumbled for same
commit
511a3764506ce6bbdc5e9441a8f4e9d862ea1102Author: Andreas Müller <[email protected]> Date: Mon Jan 4 11:04:16 2016 +0100qtscript/qtwebkit: disable thumb for armv4 and armv5 only to fix
segfault on armv7Curently recipe has
ARM_INSTRUCTION_SET_armv4= "arm"ARM_INSTRUCTION_SET_armv5= "arm"Isn't thumb default any more?
Quoted 8 lines
Quoted 4 lines
Thumb-1 doesn't really work since it shows up with register allocation errors with gcc.
thumb2 is fine for armv6+Sorry for causing confusion - what I meant: Isn't thumb2 default for armv7 anymore (particularly RasPI > 1). If thumb2 is still default for armv7 there is no need to add it explicitly here. It does not do any harm but it is not necessary.
Quoted 3 lines
Distros are free to choose ISA so we really can not rely on the fact when default tune was to use thumb 2 moreover it’s not default
Quoted 1 line
Got it - but with a bit more love on patch description I wouldn't have wasted your time:)
Andreas
Re: [meta-qt5][PATCH V2 2/2] qtwebkit: Fix build on armv7ve (rpi)
ARM_INSTRUCTION_SET isn't set to thumb in default config, so even with thumb in TUNE_FEATURES it's not actually used anywhere in default config.
Quoted 96 lines · Andreas Müller
Quoted 6 lines · Khem Raj
Quoted 3 lines · Andreas Müller
Quoted 1 line · Khem Raj
On Wed, Apr 4, 2018 at 1:45 PM, Andreas Müller <
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines · wrote:
Quoted 1 line · Andreas Müller
On Wed, Apr 4, 2018 at 9:10 PM, Khem Raj <[email protected]>
Quoted 70 lines · wrote:
Quoted 59 lines
Quoted 59 lines
Quoted 58 lines
Quoted 36 lines
Quoted 32 lines
Signed-off-by Khem Raj <[email protected]>---
v1 -> v2:
- Drop disabling GIrecipes-qt/qt5/qtwebkit_git.bb | 8 ++++++++ 1 file changed, 8 insertions(+)recipes-qt/qt5/qtwebkit_git.bb +0
-0@@ -18,6 +18,14 @@ DEPENDS += "qtbase qtdeclarative icu ruby-nativesqlite3 glib-2.0 libxslt gperf-
ARM_INSTRUCTION_SET_armv4= "arm"
ARM_INSTRUCTION_SET_armv5= "arm"recipes-qt/qt5/qtwebkit_git.bb +3
-0+# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474 +# https://bugs.webkit.org/show_bug.cgi?id=159880 +# JSC JIT can build on ARMv7 with -marm, but doesn't work onruntime.
+# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 (-mthumb).recipes-qt/qt5/qtwebkit_git.bb +4
-1+ARM_INSTRUCTION_SET_armv7a = "thumb" +ARM_INSTRUCTION_SET_armv7r = "thumb" +ARM_INSTRUCTION_SET_armv7ve = "thumb" + # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10 # 5.10.meta-qt5.1 SRC_URI += "\ --Quoted 2 lines
2.16.3
I've checked the links you are referring: Both
Quoted 6 lines
* are related to webkit and from 2016
* deal with runtime errors not build errors as referred in patch description.So what do you want to fix exactly?
I have looked into this further and found that I stumbled for same
commit
511a3764506ce6bbdc5e9441a8f4e9d862ea1102Author: Andreas Müller <[email protected]> Date: Mon Jan 4 11:04:16 2016 +0100qtscript/qtwebkit: disable thumb for armv4 and armv5 only to fix
segfault on armv7Curently recipe has
ARM_INSTRUCTION_SET_armv4= "arm"ARM_INSTRUCTION_SET_armv5= "arm"Isn't thumb default any more?
Quoted 8 lines
Quoted 4 lines
Thumb-1 doesn't really work since it shows up with register allocation errors with gcc.
thumb2 is fine for armv6+Sorry for causing confusion - what I meant: Isn't thumb2 default for armv7 anymore (particularly RasPI > 1). If thumb2 is still default for armv7 there is no need to add it explicitly here. It does not do any harm but it is not necessary.
Quoted 3 lines
Distros are free to choose ISA so we really can not rely on the fact when default tune was to use thumb 2 moreover it’s not default
Quoted 1 line
Got it - but with a bit more love on patch description I wouldn't have wasted your time:)
Andreas
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel