Skip to contentSkip to conversation

perf: riscv: Preliminary Perf Event Support on RISC-V

PATCH Alan Kao 2 participants 2 messages Apr 5, 2018 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): mhng-9b55b1b6-08a7-499d-a645-ada1ef5f9df1@palmer-si-x1c4

Alan Kao

author
#2 lore raw
Quoted 34 lines · Palmer Dabbelt
Quoted 33 lines · alankao at andestech.com
Quoted 31 lines · Palmer Dabbelt
Quoted 14 lines · alankao at andestech.com

This implements the baseline PMU for RISC-V platforms.

To ease future PMU portings, a guide is also written, containing perf concepts, arch porting practices and some hints.

Changes in v2:
- Fix the bug reported by Alex, which was caused by not sufficient initialization. Check https://lkml.org/lkml/2018/3/31/251 for the discussion.

Alan Kao (2):
perf: riscv: preliminary RISC-V support
perf: riscv: Add Document for Future Porting Guide

Quoted 8 lines
Documentation/riscv/pmu.txt         | 249 +++++++++++++++++++
arch/riscv/Kconfig                  |  12 +
arch/riscv/include/asm/perf_event.h |  76 +++++-
arch/riscv/kernel/Makefile          |   1 +
arch/riscv/kernel/perf_event.c      | 468 ++++++++++++++++++++++++++++++++++++
5 files changed, 802 insertions(+), 4 deletions(-)

create mode 100644 Documentation/riscv/pmu.txt
create mode 100644 arch/riscv/kernel/perf_event.c

I'm having some trouble pulling this into my tree. I think you might have another patch floating around somewhere, as I don't have any arch/riscv/include/asm/perf_event.h right now.

Do you mind rebasing this on top of linux-4.16 so I can look properly?

Thanks!

Quoted 8 lines
Quoted 5 lines

Sorry for the inconvenience, but this patch was based on Alex's patch at
https://github.com/riscv/riscv-linux/pull/124/files. I thought that one had already been picked into your tree.

Any ideas?

Thanks, it applies on top of that. I'm going to play around with this a bit, but it looks generally good.

Note that to make it work better when wraparound occurs, you should change the value of *.counter_width* into the width of real hardware counters. This is because this patch does not handle wraparound checking, so using a wider bit mask may sometimes report a extremely large number.

Ideally this should be done by adding a Kconfig option called "Hifive Unleashed PMU" which automatically sets the width an reuses most of the baseline codes. What do you think about this?

Thanks.

#3 lore raw
Quoted 44 lines · alankao at andestech.com
Quoted 34 lines · Palmer Dabbelt
Quoted 33 lines · alankao at andestech.com
Quoted 31 lines · Palmer Dabbelt
Quoted 14 lines · alankao at andestech.com

This implements the baseline PMU for RISC-V platforms.

To ease future PMU portings, a guide is also written, containing perf concepts, arch porting practices and some hints.

Changes in v2:
- Fix the bug reported by Alex, which was caused by not sufficient initialization. Check https://lkml.org/lkml/2018/3/31/251 for the discussion.

Alan Kao (2):
perf: riscv: preliminary RISC-V support
perf: riscv: Add Document for Future Porting Guide

Quoted 8 lines
Documentation/riscv/pmu.txt         | 249 +++++++++++++++++++
arch/riscv/Kconfig                  |  12 +
arch/riscv/include/asm/perf_event.h |  76 +++++-
arch/riscv/kernel/Makefile          |   1 +
arch/riscv/kernel/perf_event.c      | 468 ++++++++++++++++++++++++++++++++++++
5 files changed, 802 insertions(+), 4 deletions(-)

create mode 100644 Documentation/riscv/pmu.txt
create mode 100644 arch/riscv/kernel/perf_event.c

I'm having some trouble pulling this into my tree. I think you might have another patch floating around somewhere, as I don't have any arch/riscv/include/asm/perf_event.h right now.

Do you mind rebasing this on top of linux-4.16 so I can look properly?

Thanks!

Quoted 8 lines
Quoted 5 lines

Sorry for the inconvenience, but this patch was based on Alex's patch at
https://github.com/riscv/riscv-linux/pull/124/files. I thought that one had already been picked into your tree.

Any ideas?

Thanks, it applies on top of that. I'm going to play around with this a bit, but it looks generally good.

Quoted 8 lines

Note that to make it work better when wraparound occurs, you should change the value of *.counter_width* into the width of real hardware counters. This is because this patch does not handle wraparound checking, so using a wider bit mask may sometimes report a extremely large number.

Ideally this should be done by adding a Kconfig option called "Hifive Unleashed PMU" which automatically sets the width an reuses most of the baseline codes. What do you think about this?

We're working through this now :)