Skip to contentSkip to conversation

qt5base: remove use of QT5BASE_EXTRA_CFLAGS

PATCH New Joshua Henderson 3 participants 3 messages Apr 4, 2018 – Apr 9, 2018

lore
Share & tools
lore

Joshua Henderson

author
#0 lore raw

PATCH 1/1 qt5base: remove use of QT5BASE_EXTRA_CFLAGS

This variable was added as part of an EGL i.MX6 workaround in commit (7e9f459adf), but appears to currently be abandonded and unused. Remove the use of the variable.

Signed-off-by Joshua Henderson <[email protected]>
---
 package/qt5/qt5base/qt5base.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/qt5/qt5base/qt5base.mk +2 -2
index a7eb0ec..750830a 100644
@@ -296,8 +296,8 @@ define QT5BASE_CONFIGURE_CMDS
 		-nomake tests \
 		-device buildroot \
 		-device-option CROSS_COMPILE="$(TARGET_CROSS)" \
-		-device-option BR_COMPILER_CFLAGS="$(TARGET_CFLAGS) $(QT5BASE_EXTRA_CFLAGS)" \
-		-device-option BR_COMPILER_CXXFLAGS="$(TARGET_CXXFLAGS) $(QT5BASE_EXTRA_CFLAGS)" \
+		-device-option BR_COMPILER_CFLAGS="$(TARGET_CFLAGS)" \
+		-device-option BR_COMPILER_CXXFLAGS="$(TARGET_CXXFLAGS)" \
 		$(QT5BASE_CONFIGURE_OPTS) \
 	)
 endef
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 qt5base: remove use of QT5BASE_EXTRA_CFLAGS

Joshua, All,

On 2018-04-04 15:30 -0700, Joshua Henderson spake thusly:

Quoted 5 lines

This variable was added as part of an EGL i.MX6 workaround in commit (7e9f459adf), but appears to currently be abandonded and unused. Remove the use of the variable.

Signed-off-by Joshua Henderson <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/qt5/qt5base/qt5base.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/qt5/qt5base/qt5base.mk +2 -2
index a7eb0ec..750830a 100644
@@ -296,8 +296,8 @@ define QT5BASE_CONFIGURE_CMDS
 		-nomake tests \
 		-device buildroot \
 		-device-option CROSS_COMPILE="$(TARGET_CROSS)" \
-		-device-option BR_COMPILER_CFLAGS="$(TARGET_CFLAGS) $(QT5BASE_EXTRA_CFLAGS)" \
-		-device-option BR_COMPILER_CXXFLAGS="$(TARGET_CXXFLAGS) $(QT5BASE_EXTRA_CFLAGS)" \
+		-device-option BR_COMPILER_CFLAGS="$(TARGET_CFLAGS)" \
+		-device-option BR_COMPILER_CXXFLAGS="$(TARGET_CXXFLAGS)" \
 		$(QT5BASE_CONFIGURE_OPTS) \
 	)
 endef
Signature · 6 lines
2.7.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH 1/1 qt5base: remove use of QT5BASE_EXTRA_CFLAGS

In reply to Joshua Henderson

Hello,

Quoted 8 lines · Joshua Henderson

This variable was added as part of an EGL i.MX6 workaround in commit (7e9f459adf), but appears to currently be abandonded and unused. Remove the use of the variable.

Signed-off-by Joshua Henderson <[email protected]>
---
 package/qt5/qt5base/qt5base.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com