staging: greybus: Fix warning to limit chars per line
Subsystems (3)
PATCH v2 1/1 staging: greybus: Fix warning to limit chars per line
---
Changes in v2:
- use correct format for multiline comment
--- drivers/staging/greybus/audio_codec.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/staging/greybus/audio_codec.h +4 -1
@@ -23,7 +23,10 @@ enum { NUM_CODEC_DAIS, }; -/* device_type should be same as defined in audio.h (Android media layer) */ +/* +* device_type should be same as defined in audio.h +* (Android media layer) +*/ enum {GBAUDIO_DEVICE_NONE =0x0 ,/* reserved bits */
Signature · 6 lines
1.9.1 _______________________________________________ greybus-dev mailing list [email protected] https://lists.linaro.org/mailman/listinfo/greybus-dev
On Fri, Apr 6, 2018 at 3:39 PM, Gaurav Dhingra
<[email protected]> wrote:
Why did you remove the commit log? You had the right one in v1.
Quoted 14 lines
Signed-off-by Gaurav Dhingra <[email protected]>---
Changes in v2:
- use correct format for multiline comment--- drivers/staging/greybus/audio_codec.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/staging/greybus/audio_codec.h +0
-0@@ -23,7 +23,10 @@ enum { NUM_CODEC_DAIS,
drivers/staging/greybus/audio_codec.h enum { · line 32
Quoted 10 lines
drivers/staging/greybus/audio_codec.h +4
-1}; -/* device_type should be same as defined in audio.h (Android media layer) */ +/* +* device_type should be same as defined in audio.h +* (Android media layer) +*/ enum {GBAUDIO_DEVICE_NONE =0x0 ,/* reserved bits */
This looks ok.
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi,
Quoted 5 lines · Viresh Kumar
On Fri, Apr 6, 2018 at 3:39 PM, Gaurav Dhingra
<[email protected]> wrote:Why did you remove the commit log? You had the right one in v1.
I didn't realize that it would be necessary to add it to this patch set. I thought you guys will do squashing of the commits (v2 and v1) and using just one commit message (and will take it from last commit), seems like I was wrong. Now I've understood it.
Quoted 16 lines
Quoted 16 lines
Signed-off-by Gaurav Dhingra <[email protected]>---
Changes in v2:
- use correct format for multiline comment--- drivers/staging/greybus/audio_codec.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/staging/greybus/audio_codec.h +0
-0@@ -23,7 +23,10 @@ enum { NUM_CODEC_DAIS, };
Quoted 9 lines
drivers/staging/greybus/audio_codec.h enum { · line 32
Quoted 8 lines
drivers/staging/greybus/audio_codec.h +4
-1-/* device_type should be same as defined in audio.h (Android media layer) */ +/* +* device_type should be same as defined in audio.h +* (Android media layer) +*/ enum {GBAUDIO_DEVICE_NONE =0x0 ,/* reserved bits */ This looks ok.
Do I now need to send v3 with these exact changes, since I missed the 'commit log' in this one?
Signature · 7 lines
Gaurav Dhingra (sent from Thunderbird email client) _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Quoted 4 lines · Gaurav Dhingra
I didn't realize that it would be necessary to add it to this patch set. I thought you guys will do squashing of the commits (v2 and v1) and using just one commit message (and will take it from last commit), seems like I was wrong. Now I've understood it.
:)
When you send V2, it doesn't have any dependency on V1 and V1 is discarded after that point. V2 is the full patch which should be applied alone, we mention V2 in subject so that it is easier to track the versions.
Quoted 26 lines
Quoted 16 lines
Quoted 16 lines
Signed-off-by Gaurav Dhingra <[email protected]>---
Changes in v2:
- use correct format for multiline comment--- drivers/staging/greybus/audio_codec.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/staging/greybus/audio_codec.h +0
-0@@ -23,7 +23,10 @@ enum { NUM_CODEC_DAIS, };Quoted 9 lines
drivers/staging/greybus/audio_codec.h enum { · line 32
Quoted 8 lines
drivers/staging/greybus/audio_codec.h +4
-1-/* device_type should be same as defined in audio.h (Android media layer) */ +/* +* device_type should be same as defined in audio.h +* (Android media layer) +*/ enum {GBAUDIO_DEVICE_NONE =0x0 ,/* reserved bits */ This looks ok.
Quoted 2 lines
Do I now need to send v3 with these exact changes, since I missed the 'commit log' in this one?
Yes please.
Signature · 5 lines
viresh _______________________________________________ greybus-dev mailing list [email protected] https://lists.linaro.org/mailman/listinfo/greybus-dev