Skip to contentSkip to conversation

fs: Add MODULE_SOFTDEP declarations for hard-coded crypto drivers

PATCH In review Mathieu Malaterre 2 participants 3 messages Apr 6, 2018 – May 2, 2018

Subsystems (2)
Stable branch ext4 file system
lore
Share & tools
lore

Mathieu Malaterre

author
#0 lore raw

PATCH 1/1 fs: Add MODULE_SOFTDEP declarations for hard-coded crypto drivers

This helps initramfs builders and other tools to find the full dependencies of a module.

Debian on powerpc (ppc32) still uses yaboot as default boot loader. Using a default installation (debian-installer) 64bit and metadata_csum feature are not setup in ext4. This is discussed in more details at:

https://bugs.debian.org/825110#81

and implemented here:

https://anonscm.debian.org/cgit/d-i/partman-ext3.git/patch/?id=f87dc92157262de1ad8dd3f2343436f08271b4dc

This means that building the kernel as default debian package:

make ARCH=powerpc XYZ_defconfig
make -j8 ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- bindeb-pkg

Will lead to the following boot failure (initramfs prompt):

/dev/sda3: clean, 127679/305216 files, 11128559/1220703 blocks done.

  [    5.592819] EXT4-fs (sda3): Cannot load crc32c driver.
  mount: mounting /dev/sda3 on /root failed: No such file or directory
Link https://bugs.debian.org/819725
Link https://salsa.debian.org/kernel-team/linux/blob/master/debian/patches/bugfix/all/fs-add-module_softdep-declarations-for-hard-coded-cr.patch
Suggested-by Ben Hutchings <[email protected]>
Cc Milan Kupcevic <[email protected]>
Signed-off-by Mathieu Malaterre <[email protected]>
---
 fs/ext4/super.c | 1 +
 1 file changed, 1 insertion(+)
fs/ext4/super.c +1 -0
index 185f7e61f4cf..10bda040e78f 100644
@@ -5886,5 +5886,6 @@ static void __exit ext4_exit_fs(void)
 MODULE_AUTHOR("Remy Card, Stephen Tweedie, Andrew Morton, Andreas Dilger, Theodore Ts'o and others");
 MODULE_DESCRIPTION("Fourth Extended Filesystem");
 MODULE_LICENSE("GPL");
+MODULE_SOFTDEP("pre: crypto-crc32c");
 module_init(ext4_init_fs)
 module_exit(ext4_exit_fs)
Signature · 1 line
2.11.0
#1 lore raw

Hi,

[This is an automated email]

This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 6.5796)

The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127.

v4.16.1: Build OK!
v4.15.16: Build OK!
v4.14.33: Build OK!
v4.9.93: Build OK!
v4.4.127: Build OK!

Please let us know if you'd like to have this patch included in a stable tree.

--
Thanks,
Sasha

author
#2 lore raw
In reply to Mathieu Malaterre
Quoted 2 lines · Mathieu Malaterre

This helps initramfs builders and other tools to find the full dependencies of a module.

Replaced by:

https://github.com/torvalds/linux/commit/7ef79ad521367

Quoted 44 lines

Debian on powerpc (ppc32) still uses yaboot as default boot loader. Using a default installation (debian-installer) 64bit and metadata_csum feature are not setup in ext4. This is discussed in more details at:

https://bugs.debian.org/825110#81

and implemented here:

https://anonscm.debian.org/cgit/d-i/partman-ext3.git/patch/?id=f87dc92157262de1ad8dd3f2343436f08271b4dc

This means that building the kernel as default debian package:

make ARCH=powerpc XYZ_defconfig
make -j8 ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- bindeb-pkg

Will lead to the following boot failure (initramfs prompt):

/dev/sda3: clean, 127679/305216 files, 11128559/1220703 blocks done.

  [    5.592819] EXT4-fs (sda3): Cannot load crc32c driver.
  mount: mounting /dev/sda3 on /root failed: No such file or directory
Link https://bugs.debian.org/819725
Link https://salsa.debian.org/kernel-team/linux/blob/master/debian/patches/bugfix/all/fs-add-module_softdep-declarations-for-hard-coded-cr.patch
Suggested-by Ben Hutchings <[email protected]>
Cc Milan Kupcevic <[email protected]>
Signed-off-by Mathieu Malaterre <[email protected]>
---
 fs/ext4/super.c | 1 +
 1 file changed, 1 insertion(+)
fs/ext4/super.c +1 -1
index 185f7e61f4cf..10bda040e78f 100644
@@ -5886,5 +5886,6 @@ static void __exit ext4_exit_fs(void)
 MODULE_AUTHOR("Remy Card, Stephen Tweedie, Andrew Morton, Andreas Dilger, Theodore Ts'o and others");
 MODULE_DESCRIPTION("Fourth Extended Filesystem");
 MODULE_LICENSE("GPL");
+MODULE_SOFTDEP("pre: crypto-crc32c");
 module_init(ext4_init_fs)
 module_exit(ext4_exit_fs)
--

2.11.0