iqvlinux: remove package
PATCH 1/1 iqvlinux: remove package
This package contains a kernel module from Intel, which could only be used together with Intel userspace tools provided under NDA, which also come with the same kernel module. The copy of the kernel module available on SourceForge is only provided only to comply with the GPLv2 requirement. Intel engineers were even surprised it even built and were not willing to make any effort to fix their tarball naming to contain a version number. Therefore, it does not make sense for Buildroot to provide such a package.
See https://sourceforge.net/p/e1000/bugs/589/ for the discussion.
--- Config.in.legacy | 18 ++++++ DEVELOPERS | 1 - package/Config.in | 1 - .../0001-Support-Linux-kernel-4.12-and-later.patch | 66 ---------------------- package/iqvlinux/Config.in | 21 ------- package/iqvlinux/iqvlinux.hash | 6 -- package/iqvlinux/iqvlinux.mk | 25 -------- 7 files changed, 18 insertions(+), 120 deletions(-) delete mode 100644 package/iqvlinux/0001-Support-Linux-kernel-4.12-and-later.patch delete mode 100644 package/iqvlinux/Config.in delete mode 100644 package/iqvlinux/iqvlinux.hash delete mode 100644 package/iqvlinux/iqvlinux.mk
Config.in.legacy +18 -0
@@ -145,6 +145,24 @@ endif ############################################################################### comment "Legacy options removed in 2018.05" +config BR2_PACKAGE_IQVLINUX + bool "iqvlinux packaged removed" + select BR2_LEGACY + help + This package contained a kernel module from Intel, which + could only be used together with Intel userspace tools + provided under NDA, which also come with the same kernel + module. The copy of the kernel module available on + SourceForge is only provided only to comply with the GPLv2 + requirement. Intel engineers were even surprised it even + built and were not willing to make any effort to fix their + tarball naming to contain a version number. Therefore, it + does not make sense for Buildroot to provide such a package. + + See https://sourceforge.net/p/e1000/bugs/589/ for the + discussion. + + config BR2_PACKAGE_KODI_ADSP_BASIC bool "kodi-adsp-basic package removed" select BR2_LEGACY
DEVELOPERS +0 -1
@@ -1582,7 +1582,6 @@ F: package/bullet/ F: package/efl/ F: package/enlightenment/ F: package/expedite/ -F: package/iqvlinux/ F: package/irrlicht/ F: package/liblinear/ F: package/lensfun/
package/Config.in +0 -1
@@ -437,7 +437,6 @@ endmenu source "package/iostat/Config.in" source "package/ipmitool/Config.in" source "package/ipmiutil/Config.in" - source "package/iqvlinux/Config.in" source "package/irda-utils/Config.in" source "package/iucode-tool/Config.in" source "package/kbd/Config.in"
package/iqvlinux/0001-Support-Linux-kernel-4.12-and-later.patch deleted +0 -66
66 lines not on this page · raw message
package/iqvlinux/Config.in deleted +0 -21
@@ -1,21 +0,0 @@ -config BR2_PACKAGE_IQVLINUX - bool "iqvlinux" - depends on BR2_LINUX_KERNEL - help - Intel Ethernet Adapter Debug Driver for Linux (iqvlinux). - - Officially supports kernel versions 2.6.x up through 4.0.x but - the Buildroot package contains a patch to allow it to be built - on newer kernel versions. - - This debug driver supports all Intel's networking Tools based - on the SDK version 2.19.36.0 or higher which support Intel - Ethernet chip including e1000, e1000e, i210... - - Note: This driver requires PCI support to be enabled - (i.e. CONFIG_PCI). - - https://sourceforge.net/projects/e1000/files/iqvlinux/ - -comment "iqvlinux needs a Linux kernel to be built" - depends on !BR2_LINUX_KERNEL
package/iqvlinux/iqvlinux.hash deleted +0 -6
@@ -1,6 +0,0 @@ -# locally computed -sha256 4020a661940ba6d50f24654b90a41280eb8eccf00061fe6d105c654d3d97d551 iqvlinux-1.2.0.3.tar.gz -sha256 386086e232db4708770f717595d4f83188f776aa6e7313cd12fb039e869f494b COPYING -sha256 beded926a8f18aad5d911daf581759e2b25697588034d2b29033ae1a929506ff src/linux/driver/files.txt -sha256 ecf93b9b739fc82f7b87b34f8c6411dfdd271234af2fe45212293d9df2b654b3 inc/linux/files.txt -sha256 0a309350c1b32be72479e8fe08f7f6bbbad2e8c3d9a1cbcad3d482ea48a236ad inc/files.txt
package/iqvlinux/iqvlinux.mk deleted +0 -25
@@ -1,25 +0,0 @@ -################################################################################ -# -# iqvlinux -# -################################################################################ - -# The upstream tarball is just named iqvlinux.tar.gz, which we cannot -# use because it doesn't contain a version number. Therefore, the -# download from the upstream site will fail, and fallback to the -# backup mirror, where we have added an iqvlinux-1.2.0.3.tar.gz -# tarball. -IQVLINUX_VERSION = 1.2.0.3 -IQVLINUX_SITE = https://downloads.sourceforge.net/project/e1000/iqvlinux/$(IQVLINUX_VERSION) - -IQVLINUX_LICENSE = GPL-2.0, BSD-3-Clause -IQVLINUX_LICENSE_FILES = \ - COPYING src/linux/driver/files.txt \ - inc/linux/files.txt inc/files.txt - -IQVLINUX_MODULE_MAKE_OPTS = NALDIR=$(@D) KSRC=$(LINUX_DIR) CC=$(TARGET_CC) - -IQVLINUX_MODULE_SUBDIRS = src/linux/driver - -$(eval $(kernel-module)) -$(eval $(generic-package))
Signature · 1 line
2.14.3
PATCH 1/1 iqvlinux: remove package
Quoted 11 lines
From: "Thomas Petazzoni" <[email protected]>
To: "Buildroot List" <[email protected]>
Cc: "Romain Naour" <[email protected]>, "Carlos Santos" <[email protected]>, "Thomas Petazzoni" <[email protected]>
Sent: Wednesday, April 4, 2018 1:00:09 PM
Subject: [PATCH] iqvlinux: remove packageThis package contains a kernel module from Intel, which could only be used together with Intel userspace tools provided under NDA, which also come with the same kernel module. The copy of the kernel module available on SourceForge is only provided only to comply with the
,^^^^
"only" is repeated here ------
Quoted 31 lines
GPLv2 requirement. Intel engineers were even surprised it even built and were not willing to make any effort to fix their tarball naming to contain a version number. Therefore, it does not make sense for Buildroot to provide such a package.
See https://sourceforge.net/p/e1000/bugs/589/ for the discussion.
Signed-off-by Thomas Petazzoni <[email protected]>---
Config.in.legacy | 18 ++++++ DEVELOPERS | 1 - package/Config.in | 1 - .../0001-Support-Linux-kernel-4.12-and-later.patch | 66 ---------------------- package/iqvlinux/Config.in | 21 ------- package/iqvlinux/iqvlinux.hash | 6 -- package/iqvlinux/iqvlinux.mk | 25 -------- 7 files changed, 18 insertions(+), 120 deletions(-)delete mode 100644
package/iqvlinux/0001-Support-Linux-kernel-4.12-and-later.patchdelete mode 100644 package/iqvlinux/Config.in
delete mode 100644 package/iqvlinux/iqvlinux.hash delete mode 100644package/iqvlinux/iqvlinux.mkConfig.in.legacy +0
-0@@ -145,6 +145,24 @@ endif ###############################################################################comment "Legacy options removed in 2018.05"
Config.in.legacy endif · line 156
Quoted 9 lines
Config.in.legacy +9
-0+config BR2_PACKAGE_IQVLINUX + bool "iqvlinux packaged removed" + select BR2_LEGACY + help + This package contained a kernel module from Intel, which + could only be used together with Intel userspace tools + provided under NDA, which also come with the same kernel + module. The copy of the kernel module available on + SourceForge is only provided only to comply with the GPLv2
,^^^^
and here ---------------
Except by those small details,
Signature · 4 lines
Carlos Santos (Casantos) - DATACOM, P&D ?The greatest triumph that modern PR can offer is the transcendent success of having your words and actions judged by your reputation, rather than the other way about.? ? Christopher Hitchens
PATCH 1/1 iqvlinux: remove package
Hi Thomas, Carlos,
Le 04/04/2018 ? 18:46, Carlos Santos a ?crit?:
Quoted 45 lines
Quoted 11 lines
From: "Thomas Petazzoni" <[email protected]>
To: "Buildroot List" <[email protected]>
Cc: "Romain Naour" <[email protected]>, "Carlos Santos" <[email protected]>, "Thomas Petazzoni" <[email protected]>
Sent: Wednesday, April 4, 2018 1:00:09 PM
Subject: [PATCH] iqvlinux: remove packageThis package contains a kernel module from Intel, which could only be used together with Intel userspace tools provided under NDA, which also come with the same kernel module. The copy of the kernel module available on SourceForge is only provided only to comply with the
,^^^^"only" is repeated here ------
Quoted 31 lines
GPLv2 requirement. Intel engineers were even surprised it even built and were not willing to make any effort to fix their tarball naming to contain a version number. Therefore, it does not make sense for Buildroot to provide such a package.
See https://sourceforge.net/p/e1000/bugs/589/ for the discussion.
Signed-off-by Thomas Petazzoni <[email protected]>---
Config.in.legacy | 18 ++++++ DEVELOPERS | 1 - package/Config.in | 1 - .../0001-Support-Linux-kernel-4.12-and-later.patch | 66 ---------------------- package/iqvlinux/Config.in | 21 ------- package/iqvlinux/iqvlinux.hash | 6 -- package/iqvlinux/iqvlinux.mk | 25 -------- 7 files changed, 18 insertions(+), 120 deletions(-)delete mode 100644
package/iqvlinux/0001-Support-Linux-kernel-4.12-and-later.patchdelete mode 100644 package/iqvlinux/Config.in
delete mode 100644 package/iqvlinux/iqvlinux.hash delete mode 100644package/iqvlinux/iqvlinux.mkConfig.in.legacy +0
-0@@ -145,6 +145,24 @@ endif ###############################################################################comment "Legacy options removed in 2018.05"
Quoted 2 lines
Config.in.legacy endif · line 149
Quoted 2 lines
Config.in.legacy +2
-0+config BR2_PACKAGE_IQVLINUX + bool "iqvlinux packaged removed"
"packaged"
Quoted 8 lines
Config.in.legacy endif · line 156
Quoted 7 lines
Config.in.legacy +7
-0+ select BR2_LEGACY + help + This package contained a kernel module from Intel, which + could only be used together with Intel userspace tools + provided under NDA, which also come with the same kernel + module. The copy of the kernel module available on + SourceForge is only provided only to comply with the GPLv2,^^^^
Quoted 6 lines
and here ---------------
Except by those small details,
Acked-by Carlos Santos <[email protected]>
I'm not using this stuff anymore. Corentin maybe?
Best regards,
Romain
PATCH 1/1 iqvlinux: remove package
In reply to Thomas PetazzoniHello,
Quoted 13 lines
+++ b/Config.in.legacy
Config.in.legacy +0
-0@@ -145,6 +145,24 @@ endif ###############################################################################comment "Legacy options removed in 2018.05"
Config.in.legacy +8
-0+config BR2_PACKAGE_IQVLINUX + bool "iqvlinux packaged removed" + select BR2_LEGACY + help + This package contained a kernel module from Intel, which + could only be used together with Intel userspace tools + provided under NDA, which also come with the same kernel + module. The copy of the kernel module available on
Config.in.legacy endif · line 165
Quoted 10 lines
Config.in.legacy +10
-0+ SourceForge is only provided only to comply with the GPLv2 + requirement. Intel engineers were even surprised it even + built and were not willing to make any effort to fix their + tarball naming to contain a version number. Therefore, it + does not make sense for Buildroot to provide such a package. + + See https://sourceforge.net/p/e1000/bugs/589/ for the + discussion. + +
Could you fix the warning from check-package?
It can be done when applying.
Thanks,
Ricardo
Thomas Petazzoni
AppliedPATCH 1/1 iqvlinux: remove package
In reply to Thomas PetazzoniHello,
Quoted 12 lines · Thomas Petazzoni
This package contains a kernel module from Intel, which could only be used together with Intel userspace tools provided under NDA, which also come with the same kernel module. The copy of the kernel module available on SourceForge is only provided only to comply with the GPLv2 requirement. Intel engineers were even surprised it even built and were not willing to make any effort to fix their tarball naming to contain a version number. Therefore, it does not make sense for Buildroot to provide such a package.
See https://sourceforge.net/p/e1000/bugs/589/ for the discussion.
Signed-off-by Thomas Petazzoni <[email protected]>
Quoted 13 lines
--- Config.in.legacy | 18 ++++++ DEVELOPERS | 1 - package/Config.in | 1 - .../0001-Support-Linux-kernel-4.12-and-later.patch | 66 ---------------------- package/iqvlinux/Config.in | 21 ------- package/iqvlinux/iqvlinux.hash | 6 -- package/iqvlinux/iqvlinux.mk | 25 -------- 7 files changed, 18 insertions(+), 120 deletions(-) delete mode 100644 package/iqvlinux/0001-Support-Linux-kernel-4.12-and-later.patch delete mode 100644 package/iqvlinux/Config.in delete mode 100644 package/iqvlinux/iqvlinux.hash delete mode 100644 package/iqvlinux/iqvlinux.mk
Applied to master after doing the following changes:
[Thomas:
- remove double "only" noticed by Carlos
- fix typo packaged -> package noticed by Romain
- fix check-package warning noticed by Ricardo]
Thanks to everyone who reviewed, and spotted my mistakes!
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com