mm: replace S_IRUGO with 0444
Subsystems (4)
PATCH 1/3 mm: replace S_IRUGO with 0444
Fix checkpatch warnings about S_IRUGO being less readable than providing the permissions octal as '0444'.
Signed-off-by Paul McQuade <[email protected]>
--- mm/cleancache.c | 8 ++++---- mm/cma_debug.c | 12 ++++++------ mm/dmapool.c | 2 +- mm/frontswap.c | 8 ++++---- 4 files changed, 15 insertions(+), 15 deletions(-)
mm/cleancache.c +4 -4
@@ -307,11 +307,11 @@ static int __init init_cleancache(void)struct dentry *root =debugfs_create_dir ("cleancache" ,NULL );if (root ==NULL )return -ENXIO ; -debugfs_create_u64 ("succ_gets" ,S_IRUGO , root, &cleancache_succ_gets); -debugfs_create_u64 ("failed_gets" ,S_IRUGO , +debugfs_create_u64 ("succ_gets" ,0444 , root, &cleancache_succ_gets); +debugfs_create_u64 ("failed_gets" ,0444 , root, &cleancache_failed_gets); -debugfs_create_u64 ("puts" ,S_IRUGO , root, &cleancache_puts); -debugfs_create_u64 ("invalidates" ,S_IRUGO , +debugfs_create_u64 ("puts" ,0444 , root, &cleancache_puts); +debugfs_create_u64 ("invalidates" ,0444 , root, &cleancache_invalidates);#endif return 0 ;
mm/cma_debug.c +6 -6
@@ -178,17 +178,17 @@ static void cma_debugfs_add_one(struct cma *cma, int idx)debugfs_create_file ("free" ,S_IWUSR , tmp, cma, &cma_free_fops); -debugfs_create_file ("base_pfn" ,S_IRUGO , tmp, +debugfs_create_file ("base_pfn" ,0444 , tmp, &cma->base_pfn, &cma_debugfs_fops); -debugfs_create_file ("count" ,S_IRUGO , tmp, +debugfs_create_file ("count" ,0444 , tmp, &cma->count, &cma_debugfs_fops); -debugfs_create_file ("order_per_bit" ,S_IRUGO , tmp, +debugfs_create_file ("order_per_bit" ,0444 , tmp, &cma->order_per_bit, &cma_debugfs_fops); -debugfs_create_file ("used" ,S_IRUGO , tmp, cma, &cma_used_fops); -debugfs_create_file ("maxchunk" ,S_IRUGO , tmp, cma, &cma_maxchunk_fops); +debugfs_create_file ("used" ,0444 , tmp, cma, &cma_used_fops); +debugfs_create_file ("maxchunk" ,0444 , tmp, cma, &cma_maxchunk_fops); u32s =DIV_ROUND_UP (cma_bitmap_maxno (cma),BITS_PER_BYTE *sizeof (u32)); -debugfs_create_u32_array ("bitmap" ,S_IRUGO , tmp, (u32 *)cma->bitmap, u32s); +debugfs_create_u32_array ("bitmap" ,0444 , tmp, (u32 *)cma->bitmap, u32s); }static int __init cma_debugfs_init (void )
mm/dmapool.c +1 -1
@@ -105,7 +105,7 @@ show_pools(struct device *dev, struct device_attribute *attr, char *buf)return PAGE_SIZE - size; } -static DEVICE_ATTR(pools, S_IRUGO, show_pools, NULL); +static DEVICE_ATTR(pools, 0444, show_pools, NULL);/** * dma_pool_create - Creates a pool of consistent memory blocks, for dma.
mm/frontswap.c +4 -4
@@ -486,11 +486,11 @@ static int __init init_frontswap(void)struct dentry *root =debugfs_create_dir ("frontswap" ,NULL );if (root ==NULL )return -ENXIO ; -debugfs_create_u64 ("loads" ,S_IRUGO , root, &frontswap_loads); -debugfs_create_u64 ("succ_stores" ,S_IRUGO , root, &frontswap_succ_stores); -debugfs_create_u64 ("failed_stores" ,S_IRUGO , root, +debugfs_create_u64 ("loads" ,0444 , root, &frontswap_loads); +debugfs_create_u64 ("succ_stores" ,0444 , root, &frontswap_succ_stores); +debugfs_create_u64 ("failed_stores" ,0444 , root, &frontswap_failed_stores); -debugfs_create_u64 ("invalidates" ,S_IRUGO , +debugfs_create_u64 ("invalidates" ,0444 , root, &frontswap_invalidates);#endif return 0 ;
Signature · 1 line
2.16.2
PATCH 2/3 mm: Replace S_IWUSR with 0200
Fix checkpatch warnings about S_IWUSR being less readable than providing the permissions octal as '0200'.
Signed-off-by Paul McQuade <[email protected]>
--- mm/cma_debug.c | 4 ++-- mm/compaction.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
mm/cma_debug.c +2 -2
@@ -172,10 +172,10 @@ static void cma_debugfs_add_one(struct cma *cma, int idx) tmp =debugfs_create_dir (name, cma_debugfs_root); -debugfs_create_file ("alloc" ,S_IWUSR , tmp, cma, +debugfs_create_file ("alloc" ,0200 , tmp, cma, &cma_alloc_fops); -debugfs_create_file ("free" ,S_IWUSR , tmp, cma, +debugfs_create_file ("free" ,0200 , tmp, cma, &cma_free_fops); debugfs_create_file("base_pfn", 0444, tmp,
mm/compaction.c +1 -1
@@ -1900,7 +1900,7 @@ static ssize_t sysfs_compact_node(struct device *dev,return count; } -static DEVICE_ATTR(compact, S_IWUSR, NULL, sysfs_compact_node); +static DEVICE_ATTR(compact, 0200, NULL, sysfs_compact_node);int compaction_register_node (struct node *node) {
Signature · 1 line
2.16.2
PATCH 3/3 mm: replace S_IRUSR | S_IWUSR with 0600
In reply to Paul McQuadeFix checkpatch warnings about S_IRUSR | S_IWUSR being less readable than providing the permissions octal as '0600'.
Signed-off-by Paul McQuade <[email protected]>
--- mm/failslab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/failslab.c +1 -1
@@ -42,7 +42,7 @@ __setup("failslab=", setup_failslab);static int __init failslab_debugfs_init (void ) {struct dentry *dir; -umode_t mode =S_IFREG |S_IRUSR |S_IWUSR ; +umode_t mode =S_IFREG |0600 ; dir =fault_create_debugfs_attr ("failslab" ,NULL , &failslab.attr);if (IS_ERR (dir))
Signature · 1 line
2.16.2
Quoted 2 lines · Paul McQuade
Fix checkpatch warnings about
S_IRUGObeing less readable than providing the permissions octal as '0444'.
Hey Paul.
I sent a cleanup a couple weeks ago to Andrew Morton for the same thing.
https://lkml.org/lkml/2018/3/26/638
Andrew said he'd wait until after -rc1 is out.
btw: checkpatch can do this substitution automatically
cheers, Joe
Cool, thanks! I didn't know that.
Quoted 17 lines · On Sat 7 Apr 2018, 21:11 Joe Perches <[email protected]> wrote:
Quoted 2 lines · Paul McQuade
Fix checkpatch warnings about
S_IRUGObeing less readable than providing the permissions octal as '0444'.Hey Paul.
I sent a cleanup a couple weeks ago to Andrew Morton for the same thing.
https://lkml.org/lkml/2018/3/26/638
Andrew said he'd wait until after -rc1 is out.
btw: checkpatch can do this substitution automatically
cheers, Joe