tools/memory-model: Update required version of herdtools7
Akira Yokosawa
reviewerPATCH 1/1 tools/memory-model: Update required version of herdtools7
Quoted 1 line
From
64542a47acf159d26b8290480c0af9c2a05d20d6Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Sun, 8 Apr 2018 07:44:55 +0900
Subject: [PATCH] tools/memory-model: Update required version of herdtools7
Code generated by klitmus7 version 7.48 doesn't compile with kernel header of 4.15 and later due to the absence of ACCESS_ONCE(). As the issue has been resolved in herdtools7 7.49, bump the required version number in README.
---
Hi Paul,
I think this is a 4.17 matter.
Thoughts?
Thanks, Akira
--
tools/memory-model/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/memory-model/README +1 -1
@@ -20,7 +20,7 @@ that litmus test to be exercised within the Linux kernel. REQUIREMENTS ============ -Version 7.48 of the "herd7" and "klitmus7" tools must be downloaded +Version 7.49 of the "herd7" and "klitmus7" tools must be downloaded separately: https://github.com/herd/herdtools7
Signature · 1 line
2.7.4
Quoted 22 lines · Akira Yokosawa
Quoted 1 line
From
64542a47acf159d26b8290480c0af9c2a05d20d6Mon Sep 17 00:00:00 2001From: Akira Yokosawa <[email protected]>
Date: Sun, 8 Apr 2018 07:44:55 +0900
Subject: [PATCH]tools/memory-model: Update required version of herdtools7Code generated by klitmus7 version 7.48 doesn't compile with kernel header of 4.15 and later due to the absence of
ACCESS_ONCE(). As the issue has been resolved in herdtools7 7.49, bump the required version number in README.Signed-off-by Akira Yokosawa <[email protected]>Cc Alan Stern <[email protected]>Cc Andrea Parri <[email protected]>Cc Will Deacon <[email protected]>Cc Peter Zijlstra <[email protected]>Cc Boqun Feng <[email protected]>Cc Nicholas Piggin <[email protected]>Cc David Howells <[email protected]>Cc Jade Alglave <[email protected]>Cc Luc Maranget <[email protected]>Cc "Paul E. McKenney" <[email protected]>Cc Ingo Molnar <[email protected]>
Quoted 5 lines
---
Hi Paul,I think this is a 4.17 matter.
Thoughts?
Good catch, queued and pushed, thank you!
I don't believe that this needs to go into the current merge window, given that there is an easy workaround and that people running into this will likely find your patch via web-seach, at which point they can update their herdtools. But it should definitely go into v4.18!
Thanx, Paul
Quoted 21 lines
Thanks, Akira
--tools/memory-model/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/memory-model/README +1
-1@@ -20,7 +20,7 @@ that litmus test to be exercised within the Linux kernel. REQUIREMENTS ============ -Version 7.48 of the "herd7" and "klitmus7" tools must be downloaded +Version 7.49 of the "herd7" and "klitmus7" tools must be downloaded separately: https://github.com/herd/herdtools7Signature · 1 line
2.7.4