mpd: add mms support
PATCH 1/1 mpd: add mms support
--- package/mpd/Config.in | 6 ++++++ package/mpd/mpd.mk | 7 +++++++ 2 files changed, 13 insertions(+)
package/mpd/Config.in +6 -0
@@ -180,6 +180,12 @@ config BR2_PACKAGE_MPD_CURL help Enable curl streaming (http) support. +config BR2_PACKAGE_MPD_LIBMMS + bool "mms" + select BR2_PACKAGE_LIBMMS + help + Enable MMS support. + config BR2_PACKAGE_MPD_LIBNFS bool "nfs" # libnfs -> libtirpc
package/mpd/mpd.mk +7 -0
@@ -120,6 +120,13 @@ else MPD_CONF_OPTS += --disable-libmpdclient endif +ifeq ($(BR2_PACKAGE_MPD_LIBMMS),y) +MPD_DEPENDENCIES += libmms +MPD_CONF_OPTS += --enable-mms +else +MPD_CONF_OPTS += --disable-mms +endif + ifeq ($(BR2_PACKAGE_MPD_LIBNFS),y) MPD_DEPENDENCIES += libnfs MPD_CONF_OPTS += --enable-nfs
Signature · 1 line
2.14.1
PATCH 1/1 mpd: add mms support
Hello,
Quoted 11 lines · Fabrice Fontaine
Signed-off-by Fabrice Fontaine <[email protected]>--- package/mpd/Config.in | 6 ++++++ package/mpd/mpd.mk | 7 +++++++ 2 files changed, 13 insertions(+)package/mpd/Config.in +0
-0
package/mpd/Config.in config BR2_PACKAGE_MPD_CURL · line 187
Quoted 8 lines
package/mpd/Config.in +5
-0@@ -180,6 +180,12 @@ config BR2_PACKAGE_MPD_CURL help Enable curl streaming (http) support. +config BR2_PACKAGE_MPD_LIBMMS + bool "mms" + select BR2_PACKAGE_LIBMMS + help + Enable MMS support.
Shouldn't we propagate the dependencies of the libmms package ?
I suppose most (all ?) of them are already covered by the BR2_PACKAGE_MPD option, but shouldn't we propagate them anyway, in case we change the dependencies of BR2_PACKAGE_MPD in the future ?
Do we a clear policy on this ?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 mpd: add mms support
Dear Thomas,
2018-04-09 11:15 GMT+02:00 Thomas Petazzoni <[email protected]>:
Quoted 25 lines
Hello,
Quoted 11 lines · Fabrice Fontaine
Signed-off-by Fabrice Fontaine <[email protected]>--- package/mpd/Config.in | 6 ++++++ package/mpd/mpd.mk | 7 +++++++ 2 files changed, 13 insertions(+)package/mpd/Config.in +0
-0package/mpd/Config.in config BR2_PACKAGE_MPD_CURL · line 187
Quoted 8 lines
package/mpd/Config.in +5
-0@@ -180,6 +180,12 @@ config BR2_PACKAGE_MPD_CURL help Enable curl streaming (http) support. +config BR2_PACKAGE_MPD_LIBMMS + bool "mms" + select BR2_PACKAGE_LIBMMS + help + Enable MMS support.Shouldn't we propagate the dependencies of the libmms package ?
Quoted 6 lines
I suppose most (all ?) of them are already covered by the
BR2_PACKAGE_MPDoption, but shouldn't we propagate them anyway, in case we change the dependencies ofBR2_PACKAGE_MPDin the future ?Do we a clear policy on this ?
All libmms dependencies are already covered by mpd package. It don't know if we have a clear policy for all packages. However, for samba support, BR2_USE_MMU, BR2_USE_WCHAR and BR2_TOOLCHAIN_HAS_THREADS_NPTL have not been propagated to mpd. Same thing for jack support and BR2_USE_MMU / BR2_TOOLCHAIN_HAS_THREADS.
Quoted 7 lines
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com
Best Regards,
Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180417/695ce1ae/attachment.html>
Thomas Petazzoni
AppliedPATCH 1/1 mpd: add mms support
In reply to Fabrice FontaineHello,
Quoted 5 lines · Fabrice Fontaine
Signed-off-by Fabrice Fontaine <[email protected]>--- package/mpd/Config.in | 6 ++++++ package/mpd/mpd.mk | 7 +++++++ 2 files changed, 13 insertions(+)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com