sunxi: A64/H5 devices: enable usb keyboard support

PATCH New Peter Robinson 3 participants 5 messages Apr 9, 2018 – Apr 18, 2018

Share & tools

Peter Robinson

author

2018-04-09 12:15 UTC #0 lore raw

PATCH 1/1 sunxi: A64/H5 devices: enable usb keyboard support

Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.

Tested on Pine64.

Signed-off-by Peter Robinson <[email protected]>

---
 configs/a64-olinuxino_defconfig       | 2 ++
 configs/bananapi_m64_defconfig        | 2 ++
 configs/nanopi_a64_defconfig          | 2 ++
 configs/nanopi_neo2_defconfig         | 2 ++
 configs/nanopi_neo_plus2_defconfig    | 2 ++
 configs/orangepi_pc2_defconfig        | 2 ++
 configs/orangepi_win_defconfig        | 2 ++
 configs/orangepi_zero_plus2_defconfig | 2 ++
 configs/pine64_plus_defconfig         | 2 ++
 configs/sopine_baseboard_defconfig    | 2 ++
 10 files changed, 20 insertions(+)

configs/a64-olinuxino_defconfig +2 -0

index 6edefa4f67..c4cdec4771 100644
@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/bananapi_m64_defconfig +2 -0

index 60cbfd9b2b..4174dd7aac 100644
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/nanopi_a64_defconfig +2 -0

index 122fcc5794..3bef473d48 100644
@@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-nanopi-a64"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/nanopi_neo2_defconfig +2 -0

index f27529d7d4..6622a186f3 100644
@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/nanopi_neo_plus2_defconfig +2 -0

index 5f69799e06..1c6ad4647d 100644
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo-plus2"
 # CONFIG_SPL_EFI_PARTITION is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/orangepi_pc2_defconfig +2 -0

index 893780a0f7..7d01e6f27c 100644
@@ -15,3 +15,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/orangepi_win_defconfig +2 -0

index 0fd297752d..85f0731c3c 100644
@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-orangepi-win"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/orangepi_zero_plus2_defconfig +2 -0

index b48f13e7b1..4f1f008ea8 100644
@@ -15,3 +15,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-zero-plus2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/pine64_plus_defconfig +2 -0

index 23365a57c3..42281a9d7d 100644
@@ -15,3 +15,5 @@ CONFIG_RTL8211E_PINE64_GIGABIT_FIX=y
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/sopine_baseboard_defconfig +2 -0

index 503e3903ca..30cb6b93d0 100644
@@ -19,3 +19,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

Signature · 1 line

2.17.0

Maxime Ripard

2018-04-09 12:53 UTC #1 lore raw

PATCH 1/1 sunxi: A64/H5 devices: enable usb keyboard support

Quoted 6 lines · Peter Robinson

Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.
Tested on Pine64.
Signed-off-by Peter Robinson <[email protected]>

Don't forget any maintainers when you're sending a patch :)

Quoted 18 lines

---
 configs/a64-olinuxino_defconfig       | 2 ++
 configs/bananapi_m64_defconfig        | 2 ++
 configs/nanopi_a64_defconfig          | 2 ++
 configs/nanopi_neo2_defconfig         | 2 ++
 configs/nanopi_neo_plus2_defconfig    | 2 ++
 configs/orangepi_pc2_defconfig        | 2 ++
 configs/orangepi_win_defconfig        | 2 ++
 configs/orangepi_zero_plus2_defconfig | 2 ++
 configs/pine64_plus_defconfig         | 2 ++
 configs/sopine_baseboard_defconfig    | 2 ++
 10 files changed, 20 insertions(+)

configs/a64-olinuxino_defconfig +0 -0

index 6edefa4f67..c4cdec4771 100644

configs/a64-olinuxino_defconfig CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino" · line 17

Quoted 5 lines

configs/a64-olinuxino_defconfig +2 -0

@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

Both are already selected by ARCH_SUNXI if DISTRO_DEFAULTS is set. In turn, DISTRO_DEFAULTS is enabled by default if ARCH_SUNXI is. Why do you need to enable it in the defconfig?

If this doesn't work for some reason, this should be fixed at the Kconfig level, not in the defconfig.

Maxime

Signature · 10 lines

Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180409/b121773c/attachment.sig>

Peter Robinson

author

2018-04-09 13:13 UTC #2 lore raw

PATCH 1/1 sunxi: A64/H5 devices: enable usb keyboard support

Quoted 9 lines · Maxime Ripard

Quoted 6 lines · Peter Robinson
Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.
Tested on Pine64.
Signed-off-by Peter Robinson <[email protected]>
Don't forget any maintainers when you're sending a patch :)

The list in the cc: is what ./scripts/get_maintainer.pl returned when run against the patch

Quoted 37 lines

Quoted 18 lines
---
 configs/a64-olinuxino_defconfig       | 2 ++
 configs/bananapi_m64_defconfig        | 2 ++
 configs/nanopi_a64_defconfig          | 2 ++
 configs/nanopi_neo2_defconfig         | 2 ++
 configs/nanopi_neo_plus2_defconfig    | 2 ++
 configs/orangepi_pc2_defconfig        | 2 ++
 configs/orangepi_win_defconfig        | 2 ++
 configs/orangepi_zero_plus2_defconfig | 2 ++
 configs/pine64_plus_defconfig         | 2 ++
 configs/sopine_baseboard_defconfig    | 2 ++
 10 files changed, 20 insertions(+)
configs/a64-olinuxino_defconfig +0 -0
index 6edefa4f67..c4cdec4771 100644
configs/a64-olinuxino_defconfig CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino" · line 17
Quoted 5 lines
configs/a64-olinuxino_defconfig +2 -0
@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
Both are already selected by ARCH_SUNXI if DISTRO_DEFAULTS is set. In turn, DISTRO_DEFAULTS is enabled by default if ARCH_SUNXI is. Why do you need to enable it in the defconfig?
If this doesn't work for some reason, this should be fixed at the Kconfig level, not in the defconfig.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Antony Antony

2018-04-09 13:50 UTC #3 lore raw

PATCH 1/1 sunxi: A64/H5 devices: enable usb keyboard support

In reply to Peter Robinson

Quoted 4 lines · Peter Robinson

Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.
Tested on Pine64.

Is it usefull on devices without video output(no HDMI, VGA)?

Quoted 17 lines

 configs/nanopi_neo2_defconfig         | 2 ++
 configs/nanopi_neo_plus2_defconfig    | 2 ++

configs/nanopi_neo2_defconfig +2 -0

@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/nanopi_neo_plus2_defconfig +0 -0

index 5f69799e06..1c6ad4647d 100644

configs/nanopi_neo_plus2_defconfig CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo-plus2" · line 18

Quoted 5 lines

configs/nanopi_neo_plus2_defconfig +2 -0

@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo-plus2"
 # CONFIG_SPL_EFI_PARTITION is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

these two devices have no video out. I am not sure all these have HDMI output.

Peter Robinson

author

2018-04-18 11:47 UTC #4 lore raw

PATCH 1/1 sunxi: A64/H5 devices: enable usb keyboard support

Quoted 25 lines · Antony Antony

Quoted 4 lines · Peter Robinson
Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.
Tested on Pine64.
Is it usefull on devices without video output(no HDMI, VGA)?
Quoted 16 lines
 configs/nanopi_neo2_defconfig         | 2 ++
 configs/nanopi_neo_plus2_defconfig    | 2 ++
configs/nanopi_neo2_defconfig +2 -0
@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
configs/nanopi_neo_plus2_defconfig +0 -0
index 5f69799e06..1c6ad4647d 100644

Quoted 8 lines

configs/nanopi_neo_plus2_defconfig CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo-plus2" · line 18
Quoted 6 lines
configs/nanopi_neo_plus2_defconfig +2 -0
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo-plus2"
 # CONFIG_SPL_EFI_PARTITION is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y
these two devices have no video out. I am not sure all these have HDMI output.

Well it's likely a moot point as the HDMI seems enabled on the SoC by default but I'll update to drop those two.