Skip to contentSkip to conversation

net/axgbe: fix an assignment error in axgbe_dev_info_get()

PATCH In review Rami Rosen 3 participants 4 messages Apr 9, 2018 – Apr 12, 2018 Network drivers

lore
Share & tools
lore

Rami Rosen

author
#0 lore raw

PATCH 1/1 net/axgbe: fix an assignment error in axgbe_dev_info_get()

This patch fixes a tirvial error in assigning max Rx/Tx queues in axgbe_dev_info_get() of the axgbe PMD driver.

Signed-off-by Rami Rosen <[email protected]>
---
 drivers/net/axgbe/axgbe_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/axgbe/axgbe_ethdev.c +2 -2
index 07c1337ac..a9a9fb570 100644
@@ -355,8 +355,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
 	struct axgbe_port *pdata = dev->data->dev_private;
 
 	dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
-	dev_info->max_rx_queues = pdata->tx_ring_count;
-	dev_info->max_tx_queues = pdata->rx_ring_count;
+	dev_info->max_rx_queues = pdata->rx_ring_count;
+	dev_info->max_tx_queues = pdata->tx_ring_count;
 	dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
 	dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
 	dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;
Signature · 1 line
2.14.3
#1 lore raw
Quoted 23 lines

This patch fixes a tirvial error in assigning max Rx/Tx queues in axgbe_dev_info_get() of the axgbe PMD driver.

Signed-off-by Rami Rosen <[email protected]>

---
drivers/net/axgbe/axgbe_ethdev.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/axgbe/axgbe_ethdev.c +2 -3
index 07c1337ac..a9a9fb570 100644
@@ -355,8 +355,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
 	struct axgbe_port *pdata = dev->data->dev_private;
 
 	dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
-	dev_info->max_rx_queues = pdata->tx_ring_count;
-	dev_info->max_tx_queues = pdata->rx_ring_count;
+	dev_info->max_rx_queues = pdata->rx_ring_count;
+	dev_info->max_tx_queues = pdata->tx_ring_count;
 	dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
 	dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
 	dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;
--
Quoted 2 lines

2.14.3

Thanks a lot Remi. Wonderful catch.

Regards,
Ravi

Acked-by Ravi Kumar
#2 lore raw
Quoted 14 lines · On 4/9/2018 2:56 PM, Kumar, Ravi1 wrote:
Quoted 14 lines

This patch fixes a tirvial error in assigning max Rx/Tx queues in axgbe_dev_info_get() of the axgbe PMD driver.

Signed-off-by Rami Rosen <[email protected]>

---
drivers/net/axgbe/axgbe_ethdev.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/axgbe/axgbe_ethdev.c +0 -0
index 07c1337ac..a9a9fb570 100644
@@ -355,8 +355,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
 	struct axgbe_port *pdata = dev->data->dev_private;
Quoted 13 lines
Quoted 11 lines
drivers/net/axgbe/axgbe_ethdev.c +2 -3
 	dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
-	dev_info->max_rx_queues = pdata->tx_ring_count;
-	dev_info->max_tx_queues = pdata->rx_ring_count;
+	dev_info->max_rx_queues = pdata->rx_ring_count;
+	dev_info->max_tx_queues = pdata->tx_ring_count;
 	dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
 	dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
 	dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;
--

2.14.3

Thanks a lot Remi. Wonderful catch.

I am adding your explicit ack for the patch:

Acked-by Ravi Kumar <[email protected]>
Quoted 4 lines

Regards,
Ravi

#3 lore raw
Quoted 29 lines · Ferruh Yigit
Quoted 14 lines · On 4/9/2018 2:56 PM, Kumar, Ravi1 wrote:
Quoted 14 lines

This patch fixes a tirvial error in assigning max Rx/Tx queues in axgbe_dev_info_get() of the axgbe PMD driver.

Signed-off-by Rami Rosen <[email protected]>

---
drivers/net/axgbe/axgbe_ethdev.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/axgbe/axgbe_ethdev.c +0 -0
index 07c1337ac..a9a9fb570 100644
@@ -355,8 +355,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
 	struct axgbe_port *pdata = dev->data->dev_private;
Quoted 13 lines
Quoted 11 lines
drivers/net/axgbe/axgbe_ethdev.c +2 -3
 	dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
-	dev_info->max_rx_queues = pdata->tx_ring_count;
-	dev_info->max_tx_queues = pdata->rx_ring_count;
+	dev_info->max_rx_queues = pdata->rx_ring_count;
+	dev_info->max_tx_queues = pdata->tx_ring_count;
 	dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
 	dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
 	dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;
--

2.14.3

Thanks a lot Remi. Wonderful catch.

Quoted 2 lines

I am adding your explicit ack for the patch:

Acked-by Ravi Kumar <[email protected]>

Squashed into relevant commit in next-net, thanks.