Skip to contentSkip to conversation

x86/boot/e820: add new chareater - to free BIOS memory in memmap bootargs

PATCH New [email protected] 3 participants 8 messages Apr 10, 2018 – Apr 17, 2018

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 x86/boot/e820: add new chareater - to free BIOS memory in memmap bootargs

this is useing memmap=0x4101000-0x6aeff000 to free BIOS reserved memory "6aeff000-6effffff : reserved":

	......
	00100000-6aefefff : System RAM
	01000000-0165537a : Kernel code
	0165537b-01a8873f : Kernel data
	01c31000-01f4efff : Kernel bss
	28000000-320fffff : Crash kernel
	6aeff000-6effffff : reserved       --> it is e820 reserved memory
	6f000000-78240fff : System RAM
	......

add bootargs memmap=0x4101000-0x6aeff000, to free memory region: 6aeff000-6effffff then 6aeff000-6effffff will be merged into 00100000-78240fff.

new iomem:

	cat /proc/iomem:
	......
	00100000-78240fff : System RAM
	01000000-0165537a : Kernel code
	0165537b-01a8873f : Kernel data
	01c31000-01f4efff : Kernel bss
	......

V1>V2: fixed the wrong chareaters

zoucao (1):
x86/boot/e820: add new chareater "-" to free BIOS memory in memmap bootargs

 7u/Documentation/kernel-parameters.txt | 6 ++++++
 7u/arch/x86/kernel/e820.c              | 3 +++
 2 files changed, 9 insertions(+)
#1 lore raw

PATCH 1/1 x86/boot/e820: add new chareater "-" to free BIOS memory in memmap bootargs

From: zoucao <[email protected]>

Normally every BIOS reserved memory is used for some features, we can't use them, but in some conditions, users can ensure some BIOS memories are not used and reserved memory is well to free, they have not a good way to free these memories, here add a new chareater "-" in memmap to free reserved memory.

---
 7u/Documentation/kernel-parameters.txt | 6 ++++++
 7u/arch/x86/kernel/e820.c              | 3 +++
 2 files changed, 9 insertions(+)
7u/Documentation/kernel-parameters.txt +6 -0
index 9a1abb99a..dbea75e12 100644
@@ -1677,6 +1677,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
 			         or
 			         memmap=0x10000$0x18690000
 
+	memmap=nn[KMG]-ss[KMG]
+			Free E820 reserved memory, as specified by the user.
+			Region of reserved memory to be free, from ss to ss+nn.
+			Example: free reserved memory from 0x18690000-0x186a0000
+					memmap=0x4101000-0x6aeff000
+
 	memory_corruption_check=0/1 [X86]
 			Some BIOSes seem to corrupt the first 64k of
 			memory when doing things like suspend/resume.
7u/arch/x86/kernel/e820.c +3 -0
index 174da5fc5..b8a042981 100644
@@ -875,6 +875,9 @@ static int __init parse_memmap_one(char *p)
 	} else if (*p == '$') {
 		start_at = memparse(p+1, &p);
 		e820_add_region(start_at, mem_size, E820_RESERVED);
+	} else if (*p == '-') {
+		start_at = memparse(p+1, &p);
+		e820_remove_range(start_at, mem_size, E820_RESERVED, E820_RAM);
 	} else
 		e820_remove_range(mem_size, ULLONG_MAX - mem_size, E820_RAM, 1);
 
Signature · 1 line
2.14.1.40.g8e62ba1
#2 lore raw

Re: [PATCH] x86/boot/e820: add new chareater "-" to free BIOS memory in memmap bootargs

any suggestions?

Quoted 45 lines · On 2018/4/10 上午10:59, [email protected] wrote:

From: zoucao <[email protected]>

Normally every BIOS reserved memory is used for some features, we can't use them, but in some conditions, users can ensure some BIOS memories are not used and reserved memory is well to free, they have not a good way to free these memories, here add a new chareater "-" in memmap to free reserved memory.

---
  7u/Documentation/kernel-parameters.txt | 6 ++++++
  7u/arch/x86/kernel/e820.c              | 3 +++
  2 files changed, 9 insertions(+)
7u/Documentation/kernel-parameters.txt +6 -0
index 9a1abb99a..dbea75e12 100644
@@ -1677,6 +1677,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
  			         or
  			         memmap=0x10000$0x18690000
 
+	memmap=nn[KMG]-ss[KMG]
+			Free E820 reserved memory, as specified by the user.
+			Region of reserved memory to be free, from ss to ss+nn.
+			Example: free reserved memory from 0x18690000-0x186a0000
+					memmap=0x4101000-0x6aeff000
+
  	memory_corruption_check=0/1 [X86]
  			Some BIOSes seem to corrupt the first 64k of
  			memory when doing things like suspend/resume.
7u/arch/x86/kernel/e820.c +3 -0
index 174da5fc5..b8a042981 100644
@@ -875,6 +875,9 @@ static int __init parse_memmap_one(char *p)
  	} else if (*p == '$') {
  		start_at = memparse(p+1, &p);
  		e820_add_region(start_at, mem_size, E820_RESERVED);
+	} else if (*p == '-') {
+		start_at = memparse(p+1, &p);
+		e820_remove_range(start_at, mem_size, E820_RESERVED, E820_RAM);
  	} else
  		e820_remove_range(mem_size, ULLONG_MAX - mem_size, E820_RAM, 1);
 
#3 lore raw

Re: [PATCH] x86/boot/e820: add new chareater "-" to free BIOS memory in memmap bootargs

In reply to [email protected]

ping?

Quoted 45 lines · On 2018/4/10 上午10:59, [email protected] wrote:

From: zoucao <[email protected]>

Normally every BIOS reserved memory is used for some features, we can't use them, but in some conditions, users can ensure some BIOS memories are not used and reserved memory is well to free, they have not a good way to free these memories, here add a new chareater "-" in memmap to free reserved memory.

---
  7u/Documentation/kernel-parameters.txt | 6 ++++++
  7u/arch/x86/kernel/e820.c              | 3 +++
  2 files changed, 9 insertions(+)
7u/Documentation/kernel-parameters.txt +6 -0
index 9a1abb99a..dbea75e12 100644
@@ -1677,6 +1677,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
  			         or
  			         memmap=0x10000$0x18690000
 
+	memmap=nn[KMG]-ss[KMG]
+			Free E820 reserved memory, as specified by the user.
+			Region of reserved memory to be free, from ss to ss+nn.
+			Example: free reserved memory from 0x18690000-0x186a0000
+					memmap=0x4101000-0x6aeff000
+
  	memory_corruption_check=0/1 [X86]
  			Some BIOSes seem to corrupt the first 64k of
  			memory when doing things like suspend/resume.
7u/arch/x86/kernel/e820.c +3 -0
index 174da5fc5..b8a042981 100644
@@ -875,6 +875,9 @@ static int __init parse_memmap_one(char *p)
  	} else if (*p == '$') {
  		start_at = memparse(p+1, &p);
  		e820_add_region(start_at, mem_size, E820_RESERVED);
+	} else if (*p == '-') {
+		start_at = memparse(p+1, &p);
+		e820_remove_range(start_at, mem_size, E820_RESERVED, E820_RAM);
  	} else
  		e820_remove_range(mem_size, ULLONG_MAX - mem_size, E820_RAM, 1);
 
#4 lore raw

Re: [PATCH] x86/boot/e820: add new chareater "-" to free BIOS memory in memmap bootargs

Quoted 1 line · zoucao-ipc

ping?

You already pinged yesterday. Are you going to switch to hourly pings tomorrow?

#5 lore raw

Re: [PATCH] x86/boot/e820: add new chareater "-" to free BIOS memory in memmap bootargs

Hi thomas:

Sorry, i don't receive yesterday email, i think the ping email is lost, so bad me.
Anyway,have you some suggestions for this little patch? i really need your help.

Regards,
czou

Quoted 6 lines · Thomas Gleixner
Quoted 1 line · zoucao-ipc

ping?

You already pinged yesterday. Are you going to switch to hourly pings tomorrow?

#6 lore raw

Re: [PATCH] x86/boot/e820: add new chareater "-" to free BIOS memory in memmap bootargs

In reply to [email protected]
Quoted 1 line · On Tue, 10 Apr 2018, [email protected] wrote:

From: zoucao <[email protected]>

Interesting from ... Please use your real mail address for this.

Quoted 5 lines

Normally every BIOS reserved memory is used for some features, we can't use them, but in some conditions, users can ensure some BIOS memories are not used and reserved memory is well to free, they have not a good way to free these memories, here add a new chareater "-" in memmap to free reserved memory.

I'm not really convinced about this. How should anyone without detailed BIOS knowledge know that this is really reusable?

The person who knows must have access to the BIOS developer, so why can't the BIOS be fixed instead?

Thanks,

tglx

Quoted 41 lines
---
 7u/Documentation/kernel-parameters.txt | 6 ++++++
 7u/arch/x86/kernel/e820.c              | 3 +++
 2 files changed, 9 insertions(+)
7u/Documentation/kernel-parameters.txt +6 -0
index 9a1abb99a..dbea75e12 100644
@@ -1677,6 +1677,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
 			         or
 			         memmap=0x10000$0x18690000
 
+	memmap=nn[KMG]-ss[KMG]
+			Free E820 reserved memory, as specified by the user.
+			Region of reserved memory to be free, from ss to ss+nn.
+			Example: free reserved memory from 0x18690000-0x186a0000
+					memmap=0x4101000-0x6aeff000
+
 	memory_corruption_check=0/1 [X86]
 			Some BIOSes seem to corrupt the first 64k of
 			memory when doing things like suspend/resume.
7u/arch/x86/kernel/e820.c +3 -0
index 174da5fc5..b8a042981 100644
@@ -875,6 +875,9 @@ static int __init parse_memmap_one(char *p)
 	} else if (*p == '$') {
 		start_at = memparse(p+1, &p);
 		e820_add_region(start_at, mem_size, E820_RESERVED);
+	} else if (*p == '-') {
+		start_at = memparse(p+1, &p);
+		e820_remove_range(start_at, mem_size, E820_RESERVED, E820_RAM);
 	} else
 		e820_remove_range(mem_size, ULLONG_MAX - mem_size, E820_RAM, 1);
 
Signature · 1 line
2.14.1.40.g8e62ba1
#7 lore raw

Re: [PATCH] x86/boot/e820: add new chareater "-" to free BIOS memory in memmap bootargs

Quoted 3 lines · Thomas Gleixner
Quoted 1 line · On Tue, 10 Apr 2018, [email protected] wrote:

From: zoucao <[email protected]>

Interesting from ... Please use your real mail address for this.

miss this, i will do it.

Quoted 56 lines
Quoted 5 lines

Normally every BIOS reserved memory is used for some features, we can't use them, but in some conditions, users can ensure some BIOS memories are not used and reserved memory is well to free, they have not a good way to free these memories, here add a new chareater "-" in memmap to free reserved memory.

I'm not really convinced about this. How should anyone without detailed BIOS knowledge know that this is really reusable?

The person who knows must have access to the BIOS developer, so why can't the BIOS be fixed instead?

Thanks,

tglx

Quoted 41 lines
---
  7u/Documentation/kernel-parameters.txt | 6 ++++++
  7u/arch/x86/kernel/e820.c              | 3 +++
  2 files changed, 9 insertions(+)
7u/Documentation/kernel-parameters.txt +6 -0
index 9a1abb99a..dbea75e12 100644
@@ -1677,6 +1677,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
  			         or
  			         memmap=0x10000$0x18690000
 
+	memmap=nn[KMG]-ss[KMG]
+			Free E820 reserved memory, as specified by the user.
+			Region of reserved memory to be free, from ss to ss+nn.
+			Example: free reserved memory from 0x18690000-0x186a0000
+					memmap=0x4101000-0x6aeff000
+
  	memory_corruption_check=0/1 [X86]
  			Some BIOSes seem to corrupt the first 64k of
  			memory when doing things like suspend/resume.
7u/arch/x86/kernel/e820.c +3 -0
index 174da5fc5..b8a042981 100644
@@ -875,6 +875,9 @@ static int __init parse_memmap_one(char *p)
  	} else if (*p == '$') {
  		start_at = memparse(p+1, &p);
  		e820_add_region(start_at, mem_size, E820_RESERVED);
+	} else if (*p == '-') {
+		start_at = memparse(p+1, &p);
+		e820_remove_range(start_at, mem_size, E820_RESERVED, E820_RAM);
  	} else
  		e820_remove_range(mem_size, ULLONG_MAX - mem_size, E820_RAM, 1);
 
Signature · 1 line
2.14.1.40.g8e62ba1