drm/i915: move audio component initialization before audio driver use it
Subsystems (2)
PATCH v2 1/1 drm/i915: move audio component initialization before audio driver use it
From: Yang Shi <[email protected]>
issue: snd_soc_skl meet "failed to add i915 component master (-19)" when platform don't connect any display output.
i915 do initialization before than skl_probe, but if there is no display output connect, in function drm_dp_dpcd_access, there is a 32 retry for aux i2c transactions. It will meet timeout and do usleep. Then skl_probe function will be scheduled. It will call snd_hdac_i915_init, and it will meet "failed to add i915 component master" error.
And whole snd_soc_skl initialization will be failed, audio can't work normally anymore.
So i915 driver need to move intel_audio_init at the beginning of intel_modeset_init. This will make sure i915_audio_component_init process before snd_hdac_i915_init call it.
V2: edit comments more clearly
--- drivers/gpu/drm/i915/i915_drv.c | 2 -- drivers/gpu/drm/i915/intel_display.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +0 -2
@@ -1243,8 +1243,6 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)if (IS_GEN5 (dev_priv))intel_gpu_ips_init (dev_priv); -intel_audio_init (dev_priv); -/* * Some ports require correctly set-up hpd registers for detection to * work properly (leading to ghost connected connector status), e.g. VGA
drivers/gpu/drm/i915/intel_display.c +2 -0
@@ -14468,6 +14468,8 @@ int intel_modeset_init(struct drm_device *dev) dev->mode_config.funcs = &intel_mode_funcs; +intel_audio_init (dev_priv); +init_llist_head (&dev_priv->atomic_helper.free_list);INIT_WORK (&dev_priv->atomic_helper.free_work, intel_atomic_helper_free_state_worker);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915: move audio component initialization before audio driver use it
== Series Details ==
== Series Details ==
Series: drm/i915: move audio component initialization before audio driver use it
URL : https://patchwork.freedesktop.org/series/41428/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 7a227be93975 drm/i915: move audio component initialization before audio driver use it -:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #15: And whole snd_soc_skl initialization will be failed, audio can't work normally
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: move audio component initialization before audio driver use it
In reply to Yang== Series Details ==
== Series Details ==
Series: drm/i915: move audio component initialization before audio driver use it
URL : https://patchwork.freedesktop.org/series/41428/
State : failure
== Summary ==
Series 41428v1 drm/i915: move audio component initialization before audio driver use it
https://patchwork.freedesktop.org/api/1.0/series/41428/revisions/1/mbox/
---- Possible new issues:
Test kms_chamelium:
Subgroup common-hpd-after-suspend:
pass -> INCOMPLETE (fi-skl-6700k2)
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-a:
pass -> DMESG-WARN (fi-glk-j4005)
Subgroup suspend-read-crc-pipe-c:
pass -> DMESG-WARN (fi-glk-j4005)
Test pm_rpm:
Subgroup basic-pci-d3-state:
pass -> DMESG-WARN (fi-glk-j4005)---- Known issues:
Test gem_exec_suspend:
Subgroup basic-s3:
dmesg-warn -> PASS (fi-glk-j4005) fdo#103359
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
fail -> PASS (fi-glk-j4005) fdo#100368fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:440s fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:448s fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:382s fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:538s fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:299s fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:514s fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:524s fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:514s fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:414s fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:565s fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:510s fi-cnl-y3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:576s fi-elk-e7500 total:285 pass:226 dwarn:0 dfail:0 fail:0 skip:59 time:426s fi-gdg-551 total:285 pass:176 dwarn:0 dfail:0 fail:1 skip:108 time:317s fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:540s fi-glk-j4005 total:285 pass:253 dwarn:3 dfail:0 fail:0 skip:29 time:492s fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:404s fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:425s fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:472s fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:433s fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:471s fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:461s fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:509s fi-pnv-d510 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:661s fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:451s fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:535s fi-skl-6700k2 total:207 pass:190 dwarn:0 dfail:0 fail:0 skip:16 fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:491s fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:431s fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:445s fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:593s fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:402s
617cdf0bd4fd2cb0dcc64ddf07fbb56572ba800a drm-tip: 2018y-04m-09d-19h-55m-54s UTC integration manifest 7a227be93975 drm/i915: move audio component initialization before audio driver use it
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8650/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 13 lines · Yang
From: Yang Shi <[email protected]>
issue:
snd_soc_sklmeet "failed to add i915 component master (-19)" when platform don't connect any display output.i915 do initialization before than
skl_probe, but if there is no display output connect, in functiondrm_dp_dpcd_access, there is a 32 retry for aux i2c transactions. It will meet timeout and do usleep. Thenskl_probefunction will be scheduled. It will callsnd_hdac_i915_init, and it will meet "failed to add i915 component master" error.
And wholesnd_soc_sklinitialization will be failed, audio can't work normally anymore.
Quoted 3 lines
So i915 driver need to move
intel_audio_initat the beginning ofintel_modeset_init. This will make surei915_audio_component_initprocess beforesnd_hdac_i915_initcall it.
No. Please don't send updated versions of patches while the discussion is still ongoing in the previous thread. This is not the fix.
BR,
Jani.
Quoted 36 lines
V2: edit comments more clearly
Signed-off-by Bo He <[email protected]>Signed-off-by Yang Shi <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 2 -- drivers/gpu/drm/i915/intel_display.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_drv.c +0
-2@@ -1243,8 +1243,6 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)if (IS_GEN5 (dev_priv))intel_gpu_ips_init (dev_priv); -intel_audio_init (dev_priv); -/* * Some ports require correctly set-up hpd registers for detection to * work properly (leading to ghost connected connector status), e.g. VGA drivers/gpu/drm/i915/intel_display.c +2
-0@@ -14468,6 +14468,8 @@ int intel_modeset_init(struct drm_device *dev) dev->mode_config.funcs = &intel_mode_funcs; +intel_audio_init (dev_priv); +init_llist_head (&dev_priv->atomic_helper.free_list);INIT_WORK (&dev_priv->atomic_helper.free_work, intel_atomic_helper_free_state_worker);
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx