Skip to contentSkip to conversation

ACPI / PM: Blacklist Low Power S0 Idle _DSM for ThinkPad X1 Tablet(2016)

PATCH Applied Yu Chen 2 participants 2 messages Apr 10, 2018 – Apr 24, 2018 ACPI

lore
Share & tools
lore

Yu Chen

author
#0 lore raw

PATCH 1/1 ACPI / PM: Blacklist Low Power S0 Idle _DSM for ThinkPad X1 Tablet(2016)

From: Chen Yu <[email protected]>

ThinkPad X1 Tablet(2016) is reported to have issues with the Low Power S0 Idle _DSM interface and since this machine model generally can do ACPI S3 just fine, and user would like to use S3 as default sleep model, add a blacklist entry to disable that interface for ThinkPad X1 Tablet(2016).

---
 drivers/acpi/sleep.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
drivers/acpi/sleep.c +13 -0
index 46cde0912762..465f33aa0bd8 100644
@@ -364,6 +364,19 @@ static const struct dmi_system_id acpisleep_dmi_table[] __initconst = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
 		},
 	},
+	/*
+	 * https://bugzilla.kernel.org/show_bug.cgi?id=199057
+	 * ThinkPad X1 Tablet(2016) cannot do suspend-to-idle using the Low Power
+	 * S0 Idle firmware interface.
+	 */
+	{
+	.callback = init_no_lps0,
+	.ident = "ThinkPad X1 Tablet(2016)",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "20GGA00L00"),
+		},
+	},
 	{},
 };
 
Signature · 1 line
2.13.6
#1 lore raw
Quoted 29 lines · CEST Yu Chen

From: Chen Yu <[email protected]>

ThinkPad X1 Tablet(2016) is reported to have issues with the Low Power S0 Idle _DSM interface and since this machine model generally can do ACPI S3 just fine, and user would like to use S3 as default sleep model, add a blacklist entry to disable that interface for ThinkPad X1 Tablet(2016).

---
 drivers/acpi/sleep.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
drivers/acpi/sleep.c +6 -0
index 46cde0912762..465f33aa0bd8 100644
@@ -364,6 +364,19 @@ static const struct dmi_system_id acpisleep_dmi_table[] __initconst = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
 		},
 	},
+	/*
+	 * https://bugzilla.kernel.org/show_bug.cgi?id=199057
+	 * ThinkPad X1 Tablet(2016) cannot do suspend-to-idle using the Low Power
+	 * S0 Idle firmware interface.
+	 */
+	{

drivers/acpi/sleep.c static const struct dmi_system_id acpisleep_dmi_table[] __initconst = { · line 382

Quoted 10 lines
drivers/acpi/sleep.c +7 -0
+	.callback = init_no_lps0,
+	.ident = "ThinkPad X1 Tablet(2016)",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "20GGA00L00"),
+		},
+	},
 	{},
 };
 

Applied, thanks!