Skip to contentSkip to conversation

ACPI: add missing newline to printk

PATCH Applied Laszlo Toth 2 participants 2 messages Apr 10, 2018 – May 9, 2018 ACPI

lore
Share & tools
lore

Laszlo Toth

author
#0 lore raw

PATCH 1/1 ACPI: add missing newline to printk

...and restore reverse xmas tree while at it.

Signed-off-by Laszlo Toth <[email protected]>
---
 drivers/acpi/reboot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/acpi/reboot.c +2 -2
index 71769fd..6fa9c2a 100644
@@ -8,8 +8,8 @@ void acpi_reboot(void)
 {
 	struct acpi_generic_address *rr;
 	struct pci_bus *bus0;
-	u8 reset_value;
 	unsigned int devfn;
+	u8 reset_value;
 
 	if (acpi_disabled)
 		return;

@@ -40,7 +40,7 @@ void acpi_reboot(void)
 		/* Form PCI device/function pair. */
 		devfn = PCI_DEVFN((rr->address >> 32) & 0xffff,
 				  (rr->address >> 16) & 0xffff);
-		printk(KERN_DEBUG "Resetting with ACPI PCI RESET_REG.");
+		printk(KERN_DEBUG "Resetting with ACPI PCI RESET_REG.\n");
 		/* Write the value that resets us. */
 		pci_bus_write_config_byte(bus0, devfn,
 				(rr->address & 0xffff), reset_value);
Signature · 1 line
2.7.4
Applied
#1 lore raw
Quoted 23 lines · CEST Laszlo Toth

...and restore reverse xmas tree while at it.

Signed-off-by Laszlo Toth <[email protected]>
---
 drivers/acpi/reboot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/acpi/reboot.c +1 -1
index 71769fd..6fa9c2a 100644
@@ -8,8 +8,8 @@ void acpi_reboot(void)
 {
 	struct acpi_generic_address *rr;
 	struct pci_bus *bus0;
-	u8 reset_value;
 	unsigned int devfn;
+	u8 reset_value;
 
 	if (acpi_disabled)
 		return;

drivers/acpi/reboot.c void acpi_reboot(void) · line 46

Quoted 8 lines
drivers/acpi/reboot.c +1 -1
@@ -40,7 +40,7 @@ void acpi_reboot(void)
 		/* Form PCI device/function pair. */
 		devfn = PCI_DEVFN((rr->address >> 32) & 0xffff,
 				  (rr->address >> 16) & 0xffff);
-		printk(KERN_DEBUG "Resetting with ACPI PCI RESET_REG.");
+		printk(KERN_DEBUG "Resetting with ACPI PCI RESET_REG.\n");
 		/* Write the value that resets us. */
 		pci_bus_write_config_byte(bus0, devfn,
 				(rr->address & 0xffff), reset_value);

Applied, thanks!