misc: tifm: Remove VLA
Subsystems (2)
PATCH v2 1/1 misc: tifm: Remove VLA
There's an ongoing effort to remove VLAs[1] from the kernel to eventually turn on -Wvla. The single VLA can either take a value of 2 or 4 so switch to the upper bound.
[1] https://lkml.org/lkml/2018/3/7/621
Signed-off-by Laura Abbott <[email protected]>
---
v2: Add extra bounds check per request of Arnd
--- drivers/misc/tifm_7xx1.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/misc/tifm_7xx1.c +5 -1
@@ -239,9 +239,13 @@ static int tifm_7xx1_resume(struct pci_dev *dev)unsigned long timeout;unsigned int good_sockets =0 , bad_sockets =0 ;unsigned long flags; -unsigned char new_ids[fm->num_sockets]; +/* Maximum number of entries is 4 */ +unsigned char new_ids[4 ];DECLARE_COMPLETION_ONSTACK (finish_resume); +if (WARN_ON (fm->num_sockets >ARRAY_SIZE (new_ids))) +return -ENXIO ; +pci_set_power_state (dev,PCI_D0 );pci_restore_state (dev); rc =pci_enable_device (dev);
Signature · 1 line
2.14.3
Quoted 7 lines · Laura Abbott
There's an ongoing effort to remove VLAs[1] from the kernel to eventually turn on -Wvla. The single VLA can either take a value of 2 or 4 so switch to the upper bound.
[1] https://lkml.org/lkml/2018/3/7/621
Signed-off-by Laura Abbott <[email protected]>
Thanks for the new version,
Acked-by Arnd Bergmann <[email protected]>