drm/i915/glk: Add MODULE_FIRMWARE for Geminilake

PATCH RESEND Applied [email protected] 7 participants 20 messages Apr 11, 2018 – Apr 30, 2018

Subsystems (3)

Stable branch DRM drivers Intel i915

lore

Share & tools

lore

[email protected]

author

2018-04-11 04:42 UTC #0 lore raw

PATCH RESEND 1/1 drm/i915/glk: Add MODULE_FIRMWARE for Geminilake

From: Ian W MORRISON <[email protected]>

As the Geminilake firmware is now merged to linux-firmware.git use MODUE_FIRMWARE to load the firmware.

This removes the error message in the dmesg log:

    i915 0000:00:02.0: Direct firmware load for 
        i915/glk_dmc_ver1_04.bin failed with error -2
    i915 0000:00:02.0: Failed to load DMC firmware 
        i915/glk_dmc_ver1_04.bin. Disabling runtime power management.
    i915 0000:00:02.0: DMC firmware homepage:
        https://01.org/linuxgraphics/downloads/firmware

and now shows that the firmware has correctly loaded:

    [drm] Finished loading DMC firmware i915/glk_dmc_ver1_04.bin (v1.4)

Cc [email protected]

Signed-off-by Ian W MORRISON <[email protected]>

---
 drivers/gpu/drm/i915/intel_csr.c | 1 +
 1 file changed, 1 insertion(+)

drivers/gpu/drm/i915/intel_csr.c +1 -0

index 41e6c75a7f3c..f9550ea46c26 100644
@@ -35,6 +35,7 @@
  */
 
 #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
+MODULE_FIRMWARE(I915_CSR_GLK);
 #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
 
 #define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"

Signature · 1 line

2.11.0

Jani Nikula

maintainer

2018-04-11 09:24 UTC #1 lore raw

Quoted 14 lines · On Wed, 11 Apr 2018, [email protected] wrote:

From: Ian W MORRISON <[email protected]>
As the Geminilake firmware is now merged to linux-firmware.git use MODUE_FIRMWARE to load the firmware.
This removes the error message in the dmesg log:
    i915 0000:00:02.0: Direct firmware load for 
        i915/glk_dmc_ver1_04.bin failed with error -2
    i915 0000:00:02.0: Failed to load DMC firmware 
        i915/glk_dmc_ver1_04.bin. Disabling runtime power management.
    i915 0000:00:02.0: DMC firmware homepage:
        https://01.org/linuxgraphics/downloads/firmware

Quoted 5 lines

and now shows that the firmware has correctly loaded:
    [drm] Finished loading DMC firmware i915/glk_dmc_ver1_04.bin (v1.4)
Cc [email protected]

NAK on indiscriminate Cc: stable. There are zero guarantees that older kernels will work with whatever firmware you throw at them.

Anusha, Rodrigo, are we even ready to do this in our -next?

BR,
Jani.

PS. How is this a "RESEND"? I haven't seen this before.

Quoted 17 lines

Signed-off-by Ian W MORRISON <[email protected]>

---
 drivers/gpu/drm/i915/intel_csr.c | 1 +
 1 file changed, 1 insertion(+)

drivers/gpu/drm/i915/intel_csr.c +1 -0

index 41e6c75a7f3c..f9550ea46c26 100644
@@ -35,6 +35,7 @@
  */
 
 #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
+MODULE_FIRMWARE(I915_CSR_GLK);
 #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
 
 #define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"

Signature · 1 line

Jani Nikula, Intel Open Source Technology Center

Ian W MORRISON

author

2018-04-11 10:41 UTC #2 lore raw

<snip>

Quoted 4 lines

NAK on indiscriminate Cc: stable. There are zero guarantees that older kernels will work with whatever firmware you throw at them.

I included 'Cc: stable' so the patch would get added to the v4.16 and v4.15 kernels
which I have tested with the patch. I found that earlier kernels didn't support the
'linux-firmware' package required to get wifi working on Intel's new Gemini Lake NUC.

Quoted 3 lines

PS. How is this a "RESEND"? I haven't seen this before.

It is a 'RESEND' for that very reason. I initially sent the patch to the same people as
a similar patch (https://patchwork.kernel.org/patch/10143637/) however after realising
this omitted required addresses I added them and resent the patch.

Best regards,
Ian
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Jani Nikula

maintainer

2018-04-11 12:26 UTC #3 lore raw

Quoted 11 lines · Ian W MORRISON

<snip>
Quoted 4 lines
NAK on indiscriminate Cc: stable. There are zero guarantees that older kernels will work with whatever firmware you throw at them.
I included 'Cc: stable' so the patch would get added to the v4.16 and v4.15 kernels which I have tested with the patch. I found that earlier kernels didn't support the 'linux-firmware' package required to get wifi working on Intel's new Gemini Lake NUC.

You realize that this patch should have nothing to do with wifi?

Rodrigo, Anusha, if you think Cc: stable is appropriate, please indicate the specific versions of stable it is appropriate for.

BR,
Jani.

Quoted 13 lines

Quoted 4 lines
PS. How is this a "RESEND"? I haven't seen this before.
It is a 'RESEND' for that very reason. I initially sent the patch to the same people as
a similar patch (https://patchwork.kernel.org/patch/10143637/) however after realising
this omitted required addresses I added them and resent the patch.
Best regards,
Ian

Signature · 1 line

Jani Nikula, Intel Open Source Technology Center

Ian W MORRISON

author

2018-04-11 13:04 UTC #4 lore raw

Quoted 8 lines · Jani Nikula

Quoted 7 lines · Ian W MORRISON
<snip>
Quoted 4 lines
NAK on indiscriminate Cc: stable. There are zero guarantees that older kernels will work with whatever firmware you throw at them.

Quoted 7 lines

Quoted 4 lines
I included 'Cc: stable' so the patch would get added to the v4.16 and v4.15 kernels which I have tested with the patch. I found that earlier kernels didn't support the 'linux-firmware' package required to get wifi working on Intel's new Gemini Lake NUC.
You realize that this patch should have nothing to do with wifi?

Yes. Runtime power management depends on the patch but when distros such as Ubuntu are installed on a Intel Gemini Lake NUC as an example, wifi/bluetooth depends on Intel Wireless-AC 9462 which in turn depends on v4.15 as a minimum so my logic was to add the patch to 4.15 and later.

Quoted 3 lines

Rodrigo, Anusha, if you think Cc: stable is appropriate, please indicate the specific versions of stable it is appropriate for.

Thanks you..

Best regards,
Ian

Srivatsa, Anusha

2018-04-16 22:47 UTC #5 lore raw

In reply to Jani Nikula

Quoted 28 lines

-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Wednesday, April 11, 2018 5:27 AM
To: Ian W MORRISON <[email protected]>
Cc: Vivi, Rodrigo <[email protected]>; Srivatsa, Anusha <[email protected]>; Wajdeczko, Michal <[email protected]>; Greg KH <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dri- [email protected]
Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
Quoted 11 lines · Ian W MORRISON
<snip>
Quoted 4 lines
NAK on indiscriminate Cc: stable. There are zero guarantees that older kernels will work with whatever firmware you throw at them.
I included 'Cc: stable' so the patch would get added to the v4.16 and v4.15 kernels which I have tested with the patch. I found that earlier kernels didn't support the 'linux-firmware' package required to get wifi working on Intel's new Gemini Lake NUC.

Quoted 4 lines

You realize that this patch should have nothing to do with wifi?
Rodrigo, Anusha, if you think Cc: stable is appropriate, please indicate the specific versions of stable it is appropriate for.

Hi Jani,

The stable kernel version is 4.12 and beyond. It is appropriate to add the CC: stable in my opinion

Anusha

Quoted 18 lines

BR,
Jani.
Quoted 5 lines
Quoted 4 lines
PS. How is this a "RESEND"? I haven't seen this before.
Quoted 7 lines
It is a 'RESEND' for that very reason. I initially sent the patch to the same people as a similar patch
(https://patchwork.kernel.org/patch/10143637/) however after realising this omitted required addresses I added them and resent the patch.
Best regards,
Ian
--
Jani Nikula, Intel Open Source Technology Center

Jani Nikula

maintainer

2018-04-17 09:00 UTC #6 lore raw

Quoted 28 lines · Anusha

Quoted 28 lines
-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Wednesday, April 11, 2018 5:27 AM
To: Ian W MORRISON <[email protected]>
Cc: Vivi, Rodrigo <[email protected]>; Srivatsa, Anusha <[email protected]>; Wajdeczko, Michal <[email protected]>; Greg KH <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dri- [email protected]
Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
Quoted 11 lines · Ian W MORRISON
<snip>
Quoted 4 lines
NAK on indiscriminate Cc: stable. There are zero guarantees that older kernels will work with whatever firmware you throw at them.
I included 'Cc: stable' so the patch would get added to the v4.16 and v4.15 kernels which I have tested with the patch. I found that earlier kernels didn't support the 'linux-firmware' package required to get wifi working on Intel's new Gemini Lake NUC.
You realize that this patch should have nothing to do with wifi?

Quoted 7 lines

Quoted 2 lines
Rodrigo, Anusha, if you think Cc: stable is appropriate, please indicate the specific versions of stable it is appropriate for.
Hi Jani,
The stable kernel version is 4.12 and beyond. It is appropriate to add the CC: stable in my opinion

Who tested the firmware with v4.12 and later? We only have the CI results against *current* drm-tip. We don't even know about v4.16.

I'm not going to ack and take responsibility for the stable backports unless someone actually comes forward with credible Tested-bys.

BR,
Jani.

Quoted 20 lines

Anusha
Quoted 18 lines
BR,
Jani.
Quoted 5 lines
Quoted 4 lines
PS. How is this a "RESEND"? I haven't seen this before.
Quoted 7 lines
It is a 'RESEND' for that very reason. I initially sent the patch to the same people as a similar patch
(https://patchwork.kernel.org/patch/10143637/) however after realising this omitted required addresses I added them and resent the patch.
Best regards,
Ian
--
Jani Nikula, Intel Open Source Technology Center

Signature · 1 line

Jani Nikula, Intel Open Source Technology Center

Joonas Lahtinen

maintainer

2018-04-17 14:14 UTC #7 lore raw

Quoting Jani Nikula (2018-04-17 12:02:52)

Quoted 34 lines · Anusha

Quoted 33 lines
Quoted 26 lines
-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Wednesday, April 11, 2018 5:27 AM
To: Ian W MORRISON <[email protected]>
Cc: Vivi, Rodrigo <[email protected]>; Srivatsa, Anusha <[email protected]>; Wajdeczko, Michal <[email protected]>; Greg KH <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dri- [email protected]
Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
Quoted 11 lines · Ian W MORRISON
<snip>
Quoted 4 lines
NAK on indiscriminate Cc: stable. There are zero guarantees that older kernels will work with whatever firmware you throw at them.
I included 'Cc: stable' so the patch would get added to the v4.16 and v4.15 kernels which I have tested with the patch. I found that earlier kernels didn't support the 'linux-firmware' package required to get wifi working on Intel's new Gemini Lake NUC.
Quoted 4 lines
You realize that this patch should have nothing to do with wifi?
Rodrigo, Anusha, if you think Cc: stable is appropriate, please indicate the specific versions of stable it is appropriate for.
Hi Jani,

Quoted 8 lines

Quoted 2 lines
The stable kernel version is 4.12 and beyond. It is appropriate to add the CC: stable in my opinion
Who tested the firmware with v4.12 and later? We only have the CI results against *current* drm-tip. We don't even know about v4.16.
I'm not going to ack and take responsibility for the stable backports unless someone actually comes forward with credible Tested-bys.

And even then, some distros will be surprised of the new MODULE_FIRMWARE and will need to update the linux-firmware package, too.

Regards, Joonas

Quoted 28 lines

BR,
Jani.
Quoted 20 lines
Anusha
Quoted 18 lines
BR,
Jani.
Quoted 5 lines
Quoted 4 lines
PS. How is this a "RESEND"? I haven't seen this before.
Quoted 7 lines
It is a 'RESEND' for that very reason. I initially sent the patch to the same people as a similar patch
(https://patchwork.kernel.org/patch/10143637/) however after realising this omitted required addresses I added them and resent the patch.
Best regards,
Ian
--
Jani Nikula, Intel Open Source Technology Center
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center

Ian W MORRISON

author

2018-04-20 05:47 UTC #8 lore raw

Quoted 14 lines · Joonas Lahtinen

Quoting Jani Nikula (2018-04-17 12:02:52)
Quoted 13 lines · Anusha
Quoted 12 lines
Quoted 12 lines
-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Wednesday, April 11, 2018 5:27 AM
To: Ian W MORRISON <[email protected]>
Cc: Vivi, Rodrigo <[email protected]>; Srivatsa, Anusha <[email protected]>; Wajdeczko, Michal <[email protected]>; Greg KH <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dri- [email protected]
Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake

<snip>

In summary so far:

Jani:

Quoted 6 lines

NAK on indiscriminate Cc: stable. There are zero guarantees that older kernels will work with whatever firmware you throw at them. Who tested the firmware with v4.12 and later? We only have the CI results against *current* drm-tip. We don't even know about v4.16. I'm not going to ack and take responsibility for the stable backports unless someone actually comes forward with credible Tested-bys.

Anusha:

Quoted 2 lines

The stable kernel version is 4.12 and beyond. It is appropriate to add the CC: stable in my opinion

Joonas:

Quoted 2 lines

And even then, some distros will be surprised of the new MODULE_FIRMWARE and will need to update the linux-firmware package, too.

I've performed backport testing and some additional analysis as follows:

The DMC firmware for GLK was initially included in 4.11
(commit: dbb28b5c3d3cb945a63030fab8d3894cf335ce19).
Then the firmware version was upgraded to 1.03 in 4.12
(commit: f4a791819ed00a749a90387aa139706a507aa690).
However MODULE_FIRMWARE for the GLK DMC firmware was also removed in 4.12
(commit: d9321a03efcda867b3a8c6327e01808516f0acd7)
together with the firmware version being bumped to 1.04
(commit: aebfd1d37194e00d4c417e7be97efeb736cd9c04).

The patch below effectively reverts commit d9321a03 because the GLK firmware is now available in the linux-firmware repository.

To test stable backports I've used Ubuntu 18.04 (Beta 2) userspace with both Ubuntu (generic) and self-compiled mainline (patched) kernels. The conclusion was that the patch works across 4.12 to 4.17-rc1 kernels additionally displaying a 'Possible missing firmware' message when installing a kernel with the expected firmware missing.

The following are abridged backport test results:

Scenario: No DMC (glk_dmc_ver1_04.bin) firmware installed in '/lib/firmware/i915'
Test:Kernel installation ('grep -i dmc' output from 'apt install'):
4.12-generic and 4.15-generic:
No output # as expected
4.12 to 4.17-rc1-patched:
W: Possible missing firmware
/lib/firmware/i915/glk_dmc_ver1_04.bin for module i915
Result: The effect of the patch is to add a 'Possible missing
firmware' message.
Test: Booting ('grep -i dmc' output from 'dmesg'):

    4.12-generic:
      No output # as expected
    4.15-generic:
      i915 0000:00:02.0: Direct firmware load for
i915/glk_dmc_ver1_04.bin failed with error -2
      i915 0000:00:02.0: Failed to load DMC firmware
i915/glk_dmc_ver1_04.bin. Disabling runtime power management.
      i915 0000:00:02.0: DMC firmware homepage:
https://01.org/linuxgraphics/downloads/firmware
    4.12-patched:
      No output # as expected
    4.13 to 4.14-patched:
      i915 0000:00:02.0: Direct firmware load for
i915/glk_dmc_ver1_04.bin failed with error -2
      i915 0000:00:02.0: Failed to load DMC firmware
[https://01.org/linuxgraphics/downloads/firmware], disabling runtime
power management.
    4.15 to 4.17-rc1-patched:
      i915 0000:00:02.0: Direct firmware load for
i915/glk_dmc_ver1_04.bin failed with error -2
      i915 0000:00:02.0: Failed to load DMC firmware
i915/glk_dmc_ver1_04.bin. Disabling runtime power management.
      i915 0000:00:02.0: DMC firmware homepage:

https://01.org/linuxgraphics/downloads/firmware
Result: The effect of the patch does not change existing
(non-patched kernel) messages.

Scenario: DMC (glk_dmc_ver1_04.bin) firmware installed in '/lib/firmware/i915'
Test:Kernel installation ('grep -i dmc' output from 'apt install')
All kernels:
No messages # as expected
Result: The effect of the patch does not change existing messages. Test" Booting ('grep -i dmc' output from 'dmesg'):

    4.12-generic:
      No output # as expected
    4.15-generic:
      i915 0000:00:02.0: Direct firmware load for
i915/glk_dmc_ver1_04.bin failed with error -2
      i915 0000:00:02.0: Failed to load DMC firmware
i915/glk_dmc_ver1_04.bin. Disabling runtime power management.
      i915 0000:00:02.0: DMC firmware homepage:
https://01.org/linuxgraphics/downloads/firmware
    4.12-patched:
      No output # as expected
    4.13 to 4.17-rc1-patched:
      [drm] Finished loading DMC firmware i915/glk_dmc_ver1_04.bin (v1.4)

Result: The effect of the patch is to remove the 'Failed to load' message.

Regards,
Ian

Jani Nikula

maintainer

2018-04-20 07:47 UTC #9 lore raw

Quoted 1 line · Ian W MORRISON

I've performed backport testing and some additional analysis as follows:

What testing did you do beyond booting? Did you run igt?

BR,
Jani.

Signature · 1 line

Jani Nikula, Intel Open Source Technology Center

Ian W MORRISON

author

2018-04-20 08:25 UTC #10 lore raw

Quoted 7 lines · Jani Nikula

Quoted 1 line · Ian W MORRISON
I've performed backport testing and some additional analysis as follows:
What testing did you do beyond booting? Did you run igt?
BR,
Jani.

I did some basic testing including running a 4K video on Chrome whilst running intel_gpu_top. The intel_gpu_top program doesn't display anything on 4.12 either with or without the patch as neither I nor Canonical enabled CONFIG_DRM_I915_ALPHA_SUPPORT. Do you think that the stable tag should exclude 4.12 because of the 'alpha quality support' and if so do you want a V2 of the patch?

Best regards,
Ian
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Rodrigo Vivi

maintainer

2018-04-20 18:03 UTC #11 lore raw

In reply to Jani Nikula

Quoted 32 lines · Jani Nikula

Quoted 31 lines · Anusha
Quoted 30 lines
-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Wednesday, April 11, 2018 5:27 AM
To: Ian W MORRISON <[email protected]>
Cc: Vivi, Rodrigo <[email protected]>; Srivatsa, Anusha <[email protected]>; Wajdeczko, Michal <[email protected]>; Greg KH <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dri- [email protected]
Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
Quoted 11 lines · Ian W MORRISON
<snip>
Quoted 4 lines
NAK on indiscriminate Cc: stable. There are zero guarantees that older kernels will work with whatever firmware you throw at them.
I included 'Cc: stable' so the patch would get added to the v4.16 and v4.15 kernels which I have tested with the patch. I found that earlier kernels didn't support the 'linux-firmware' package required to get wifi working on Intel's new Gemini Lake NUC.
You realize that this patch should have nothing to do with wifi?
Rodrigo, Anusha, if you think Cc: stable is appropriate, please indicate the specific versions of stable it is appropriate for.

Quoted 8 lines

Quoted 4 lines
Hi Jani,
The stable kernel version is 4.12 and beyond. It is appropriate to add the CC: stable in my opinion
Who tested the firmware with v4.12 and later? We only have the CI results against *current* drm-tip. We don't even know about v4.16.

I understand your concerns, but the problem was that our old process was a bit (lot?) messed and there was the unreliable time until the firmware really lands on linux-firmware.git. So MODULE_FIRMWARE call was only added after firmware was really there on firmware repository but it wasn't about the testing.

In other words, the bump version patch was merged after tested, but MODULE_FIRMWARE was left behind because firmware blob took a while to get pulled into linux-firmware.git and we end up forgetting to add it there.

In my opinion it should be safe to add the MODULE_FIRMWARE there based on the tests from when the version was bumped.

Quoted 22 lines

I'm not going to ack and take responsibility for the stable backports unless someone actually comes forward with credible Tested-bys.
BR,
Jani.
Quoted 15 lines
Anusha
Quoted 13 lines
BR,
Jani.
Quoted 10 lines
Quoted 4 lines
PS. How is this a "RESEND"? I haven't seen this before.
It is a 'RESEND' for that very reason. I initially sent the patch to the same people as a similar patch
(https://patchwork.kernel.org/patch/10143637/) however after realising this omitted required addresses I added them and resent the patch.

Quoted 12 lines

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines
Best regards,
Ian
--
Jani Nikula, Intel Open Source Technology Center
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Srivatsa, Anusha

2018-04-20 18:30 UTC #12 lore raw

Quoted 62 lines

-----Original Message-----
From: Vivi, Rodrigo
Sent: Friday, April 20, 2018 11:04 AM
To: Jani Nikula <[email protected]>
Cc: Srivatsa, Anusha <[email protected]>; Ian W MORRISON <[email protected]>; [email protected]; Greg KH <[email protected]>; [email protected]; linux- [email protected]; [email protected]; dri- [email protected]; Wajdeczko, Michal <[email protected]>
Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
Quoted 33 lines · Jani Nikula
Quoted 32 lines · Anusha
Quoted 31 lines
-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Wednesday, April 11, 2018 5:27 AM
To: Ian W MORRISON <[email protected]>
Cc: Vivi, Rodrigo <[email protected]>; Srivatsa, Anusha <[email protected]>; Wajdeczko, Michal <[email protected]>; Greg KH <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dri- [email protected]
Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
Quoted 7 lines · Ian W MORRISON
<snip>
Quoted 4 lines
NAK on indiscriminate Cc: stable. There are zero guarantees that older kernels will work with whatever firmware you throw at them.
Quoted 5 lines
I included 'Cc: stable' so the patch would get added to the v4.16 and
v4.15 kernels which I have tested with the patch. I found that earlier kernels didn't support the 'linux-firmware' package required to get wifi working on Intel's new Gemini Lake NUC.
You realize that this patch should have nothing to do with wifi?
Rodrigo, Anusha, if you think Cc: stable is appropriate, please indicate the specific versions of stable it is appropriate for.
Quoted 8 lines
Quoted 4 lines
Hi Jani,
The stable kernel version is 4.12 and beyond. It is appropriate to add the CC: stable in my opinion
Who tested the firmware with v4.12 and later? We only have the CI results against *current* drm-tip. We don't even know about v4.16.
I understand your concerns, but the problem was that our old process was a bit (lot?) messed and there was the unreliable time until the firmware really lands on linux-firmware.git. So MODULE_FIRMWARE call was only added after firmware was really there on firmware repository but it wasn't about the testing.

Quoted 6 lines

In other words, the bump version patch was merged after tested, but MODULE_FIRMWARE was left behind because firmware blob took a while to get pulled into linux-firmware.git and we end up forgetting to add it there.
In my opinion it should be safe to add the MODULE_FIRMWARE there based on the tests from when the version was bumped.

Luis, Elio, can you guys confirm that this firmware is tested and healthy? And also, give a tested-by to this patch please?

Thanks,
Anusha

Quoted 14 lines

Quoted 14 lines
I'm not going to ack and take responsibility for the stable backports unless someone actually comes forward with credible Tested-bys.
BR,
Jani.
Quoted 7 lines
Anusha
Quoted 5 lines
BR,
Jani.
Quoted 2 lines
Quoted 2 lines

Quoted 21 lines

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines
PS. How is this a "RESEND"? I haven't seen this before.
It is a 'RESEND' for that very reason. I initially sent the patch to the same people as a similar patch
(https://patchwork.kernel.org/patch/10143637/) however after realising this omitted required addresses I added them and resent the
patch.
Quoted 13 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Best regards,
Ian
--
Jani Nikula, Intel Open Source Technology Center
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Botello Ortega, Luis

2018-04-21 01:22 UTC #13 lore raw

Hi all:

We tested GLK DMC 1.04 FW in last week of September 2017, using the latest drm-tip version for that time (4.14.0-rc2) and according to our results we could declare this FW as acceptable and healthy to be used with kernel version 4.14 . However, we cannot guarantee quality and healthy of this FW if it is used in top of current drm-tip kernel (4.17-rc0).

Best Regards
Luis Botello

-----Original Message-----
From: Srivatsa, Anusha
Sent: Friday, April 20, 2018 1:30 PM
To: Vivi, Rodrigo <[email protected]>; Jani Nikula <[email protected]>; Botello Ortega, Luis <[email protected]>; Martinez Monroy, Elio <[email protected]>
Cc: Ian W MORRISON <[email protected]>; [email protected]; Greg KH <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; Wajdeczko, Michal <[email protected]>
Subject: RE: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake

Quoted 62 lines

-----Original Message-----
From: Vivi, Rodrigo
Sent: Friday, April 20, 2018 11:04 AM
To: Jani Nikula <[email protected]>
Cc: Srivatsa, Anusha <[email protected]>; Ian W MORRISON <[email protected]>; [email protected]; Greg KH <[email protected]>; [email protected]; linux- [email protected]; [email protected]; dri- [email protected]; Wajdeczko, Michal <[email protected]>
Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
Quoted 33 lines · Jani Nikula
Quoted 32 lines · Anusha
Quoted 31 lines
-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Wednesday, April 11, 2018 5:27 AM
To: Ian W MORRISON <[email protected]>
Cc: Vivi, Rodrigo <[email protected]>; Srivatsa, Anusha <[email protected]>; Wajdeczko, Michal <[email protected]>; Greg KH <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dri- [email protected]
Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
Quoted 7 lines · Ian W MORRISON
<snip>
Quoted 4 lines
NAK on indiscriminate Cc: stable. There are zero guarantees that older kernels will work with whatever firmware you throw at them.
Quoted 5 lines
I included 'Cc: stable' so the patch would get added to the v4.16 and
v4.15 kernels which I have tested with the patch. I found that earlier kernels didn't support the 'linux-firmware' package required to get wifi working on Intel's new Gemini Lake NUC.
You realize that this patch should have nothing to do with wifi?
Rodrigo, Anusha, if you think Cc: stable is appropriate, please indicate the specific versions of stable it is appropriate for.
Quoted 8 lines
Quoted 4 lines
Hi Jani,
The stable kernel version is 4.12 and beyond. It is appropriate to add the CC: stable in my opinion
Who tested the firmware with v4.12 and later? We only have the CI results against *current* drm-tip. We don't even know about v4.16.
I understand your concerns, but the problem was that our old process
was a bit
(lot?) messed and there was the unreliable time until the firmware
really lands on linux-firmware.git. So MODULE_FIRMWARE call was only
added after firmware was really there on firmware repository but it wasn't about the testing.

Quoted 6 lines

In other words, the bump version patch was merged after tested, but MODULE_FIRMWARE was left behind because firmware blob took a while to get pulled into linux-firmware.git and we end up forgetting to add it there.
In my opinion it should be safe to add the MODULE_FIRMWARE there based on the tests from when the version was bumped.

Luis, Elio, can you guys confirm that this firmware is tested and healthy? And also, give a tested-by to this patch please?

Thanks,
Anusha

Quoted 17 lines

Quoted 17 lines
I'm not going to ack and take responsibility for the stable backports unless someone actually comes forward with credible Tested-bys.
BR,
Jani.
Quoted 10 lines
Anusha
Quoted 8 lines
BR,
Jani.
Quoted 5 lines
Quoted 4 lines
PS. How is this a "RESEND"? I haven't seen this before.

Quoted 19 lines

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
It is a 'RESEND' for that very reason. I initially sent the patch to the same people as a similar patch
(https://patchwork.kernel.org/patch/10143637/) however after realising this omitted required addresses I added them and resent the
patch.
Quoted 13 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Best regards,
Ian
--
Jani Nikula, Intel Open Source Technology Center
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Ian W MORRISON

author

2018-04-21 22:46 UTC #14 lore raw

Quoted 9 lines · Luis

Hi all:
We tested GLK DMC 1.04 FW in last week of September 2017, using the latest drm-tip version for that time (4.14.0-rc2) and according to our results we could declare this FW as acceptable and healthy to be used with kernel version 4.14 . However, we cannot guarantee quality and healthy of this FW if it is used in top of current drm-tip kernel (4.17-rc0).
Best Regards
Luis Botello

Your measured response is appreciated and raises at least four possible alternatives for this patch to proceed:

1. It is normal that firmware is *only* tested at a certain point in time with the drm-tip version of the mainline kernel so that the statement 'firmware X is acceptable and healthy to be used with kernel version Y but is not guaranteed with Y+1 or Y+n' always holds true for any microarchitecture codename's DMC firmware. Therefore it is appropriate for this patch to have a restricted 'Cc:
[email protected] # 4.14' tag together with an explicit 'Tested-by: (in 4.14)' tag.
2. As firmware testing was not performed on 4.15 and subsequent versions, testing is still required on versions 4.15 through to the current RC of version 4.17 for the patch to receive a 'Tested-by:' tag together with a 'Cc: [email protected] # 4.14' tag.
3. Further firmware testing will only be undertaken for the current RC of version 4.17 and on successful completion the patch will only receive a 'Tested-by:' tag. A 'Cc: [email protected]' tag is not applicable.
4. The firmware was not tested on 4.15 and subsequent versions as it's functionality was provided by alternative means and therefore the patch is only required in version 4.14 and should have a 'Cc:
[email protected] # 4.14 only' tag together with a restricted 'Tested-by: (only in 4.14)' tag.

Could you indicate which alternative is appropriate? If further firmware testing is required (as in points 2 or 3) then can an expected completion date be provided?

Best regards,
Ian
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Ian W MORRISON

author

2018-04-25 23:15 UTC #15 lore raw

Hi Anusha,

Can I ask if this is on anyone's radar as I'm concerned this patch will stall otherwise?

I see that the significance of testing with the 4.14 kernel enabled the firmware to be included in the latest Chrome OS kernel (
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-os-reviews/jtpHvZOfZ-Q).
It is important to similarly include in the mainline and stable kernels to facilitate various distros that are now raising bug reports (for example:
https://bugs.launchpad.net/intel/+bug/1760545).

Many thanks,
Ian

Quoted 5 lines · Ian W MORRISON

Quoted 3 lines · Luis
Hi all:
We tested GLK DMC 1.04 FW in last week of September 2017, using the

latest drm-tip version for that time (4.14.0-rc2) and according to our results we could declare this FW as acceptable and healthy to be used with kernel version 4.14 .

Quoted 1 line

Quoted 1 line
However, we cannot guarantee quality and healthy of this FW if it is

used in top of current drm-tip kernel (4.17-rc0).

Quoted 31 lines

Quoted 5 lines
Best Regards
Luis Botello
Your measured response is appreciated and raises at least four possible alternatives for this patch to proceed:
1. It is normal that firmware is *only* tested at a certain point in time with the drm-tip version of the mainline kernel so that the statement 'firmware X is acceptable and healthy to be used with kernel version Y but is not guaranteed with Y+1 or Y+n' always holds true for any microarchitecture codename's DMC firmware. Therefore it is appropriate for this patch to have a restricted 'Cc:
[email protected] # 4.14' tag together with an explicit 'Tested-by: (in 4.14)' tag.
2. As firmware testing was not performed on 4.15 and subsequent versions, testing is still required on versions 4.15 through to the current RC of version 4.17 for the patch to receive a 'Tested-by:' tag together with a 'Cc: [email protected] # 4.14' tag.
3. Further firmware testing will only be undertaken for the current RC of version 4.17 and on successful completion the patch will only receive a 'Tested-by:' tag. A 'Cc: [email protected]' tag is not applicable.
4. The firmware was not tested on 4.15 and subsequent versions as it's functionality was provided by alternative means and therefore the patch is only required in version 4.14 and should have a 'Cc:
[email protected] # 4.14 only' tag together with a restricted 'Tested-by: (only in 4.14)' tag.

Quoted 6 lines

Could you indicate which alternative is appropriate? If further firmware testing is required (as in points 2 or 3) then can an expected completion date be provided?
Best regards,
Ian

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Jani Nikula

maintainer Applied

2018-04-27 09:20 UTC #16 lore raw

Quoted 2 lines · Ian W MORRISON

Can I ask if this is on anyone's radar as I'm concerned this patch will stall otherwise?

Pushed to drm-intel-next-queued, thanks for the patch.

I opted to drop the Cc: stable for now. This doesn't mean it can't be backported later on, I'm just punting on that call right now to make some forward progress here.

Joonas, please do pick f6d3e06f0747 ("drm/i915/glk: Add MODULE_FIRMWARE for Geminilake") to drm-intel-fixes to queue it to v4.17.

BR,
Jani.

Signature · 1 line

Jani Nikula, Intel Open Source Technology Center

Joonas Lahtinen

maintainer

2018-04-30 07:58 UTC #17 lore raw

Quoting Jani Nikula (2018-04-27 12:20:55)

Quoted 12 lines · Ian W MORRISON

Quoted 2 lines
Can I ask if this is on anyone's radar as I'm concerned this patch will stall otherwise?
Pushed to drm-intel-next-queued, thanks for the patch.
I opted to drop the Cc: stable for now. This doesn't mean it can't be backported later on, I'm just punting on that call right now to make some forward progress here.
Joonas, please do pick f6d3e06f0747 ("drm/i915/glk: Add MODULE_FIRMWARE for Geminilake") to drm-intel-fixes to queue it to v4.17.

Done. That's the only drm-intel-fixes patch there seems to be for -rc4.

Regards, Joonas

Quoted 6 lines

BR,
Jani.
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center

Patchwork

2018-04-11 10:54 UTC #18 lore raw

✓ Fi.CI.BAT: success for series starting with [RESEND,1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake

In reply to [email protected]

== Series Details ==

Series: series starting with [RESEND,1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
URL : https://patchwork.freedesktop.org/series/41533/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4043 -> Patchwork_8664 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8664/

== Known issues ==

Here are the changes found in Patchwork_8664 that come from known issues:

=== IGT changes ===

    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927

== Participating hosts (35 -> 32) ==

Missing (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq

== Build changes ==

* Linux: CI_DRM_4043 -> Patchwork_8664

CI_DRM_4043: 5fca09304f690a61408129c7ed166d7f1ddfa66c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4421: 27cd3793a3a183e4ec70c392f293e840642f2799 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8664: de9215d6a97175391aa3ef8a7f6b10bd5dda9a17 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4421: 45e115f293fd6acc0c9647cf2d3b76be78819ba5 @ git://anongit.freedesktop.org/piglit

== Patchwork commits ==

de9215d6a971 drm/i915/glk: Add MODULE_FIRMWARE for Geminilake

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8664/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2018-04-11 12:37 UTC #19 lore raw

✓ Fi.CI.IGT: success for series starting with [RESEND,1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake

In reply to [email protected]

== Series Details ==

Series: series starting with [RESEND,1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
URL : https://patchwork.freedesktop.org/series/41533/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4043_full -> Patchwork_8664_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_8664_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_8664_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8664/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_8664_full:

=== IGT changes ===

    ==== Warnings ====

    igt@gem_mocs_settings@mocs-rc6-blt:
      shard-kbl:          PASS -> SKIP

    igt@kms_vblank@pipe-a-ts-continuation-suspend:
      shard-snb:          PASS -> SKIP

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_8664_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@perf_pmu@busy-accuracy-50-bcs0:
      shard-kbl:          PASS -> FAIL (fdo#105157)

    
    ==== Possible fixes ====

    igt@kms_atomic_transition@plane-all-modeset-transition:
      shard-hsw:          DMESG-WARN (fdo#102614) -> PASS

    igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
      shard-hsw:          FAIL (fdo#100368) -> PASS +1

    igt@kms_flip@flip-vs-blocking-wf-vblank:
      shard-hsw:          FAIL (fdo#103928) -> PASS

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#105157 https://bugs.freedesktop.org/show_bug.cgi?id=105157

== Participating hosts (6 -> 4) ==

Missing (2): shard-glk shard-glkb

== Build changes ==

* Linux: CI_DRM_4043 -> Patchwork_8664

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8664/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx