Skip to contentSkip to conversation

mfd: mc13xxx: Add mc34708 adc support

PATCH In review Lukasz Majewski 2 participants 3 messages Apr 11, 2018 – Apr 12, 2018 Multifunction devices (MFD)

lore
Share & tools
lore

Lukasz Majewski

author
#0 lore raw

PATCH 1/1 mfd: mc13xxx: Add mc34708 adc support

From: Sascha Hauer <[email protected]>

The mc34708 has an improved adc. The older variants will always convert a fixed order of channels. The mc34708 can do up to eight conversions in arbitrary channel order. Currently this extended feature is not supported. We only support touchscreen conversions now, which will be sampled in a data format compatible to the older chips in order to keep the API between the mfd and the touchscreen driver.

Signed-off-by Sascha Hauer <[email protected]>
Signed-off-by Lukasz Majewski <[email protected]>

---
Changes from the original patches:
- ADC conversion functions prototypes added to fix build error
- Adjustments to make checkpatch clean (-ENOSYS, line over 80 char)

---
 drivers/mfd/mc13xxx-core.c | 118 ++++++++++++++++++++++++++++++++++++++++++++-
 drivers/mfd/mc13xxx.h      |   3 ++
 2 files changed, 120 insertions(+), 1 deletion(-)
drivers/mfd/mc13xxx-core.c +117 -1
index d7f54e492aa6..f48945c9be5b 100644
@@ -48,6 +48,25 @@
 
 #define MC13XXX_ADC2		45
 
+#define MC34708_ADC3		46
+#define MC34708_ADC4		47
+
+#define MC13XXX_ADC_WORKING		(1 << 0)
+#define	MC34708_IRQ_TSDONE		1
+
+#define MC34708_ADC0_TSEN		(1 << 12)
+#define MC34708_ADC0_TSSTART		(1 << 13)
+#define MC34708_ADC0_TSSTOP(x)		(((x) & 0x7) << 16)
+
+#define MC34708_ADC3_TSSEL(step, ch)	((ch) << (8 + 2 * (step)))
+#define MC34708_ADC1_TSDLY1(d)		((d) << 12)
+#define MC34708_ADC1_TSDLY2(d)		((d) << 16)
+#define MC34708_ADC1_TSDLY3(d)		((d) << 20)
+
+#define MC34708_TS_X			1
+#define MC34708_TS_Y			2
+#define MC34708_TS_R			3
+
 void mc13xxx_lock(struct mc13xxx *mc13xxx)
 {
 	if (!mutex_trylock(&mc13xxx->lock)) {

@@ -201,22 +220,30 @@ static void mc34708_print_revision(struct mc13xxx *mc13xxx, u32 revision)
 			maskval(revision, MC34708_REVISION_FAB));
 }
 
+static int mc13xxx_adc_conversion(struct mc13xxx *, unsigned int,
+				  unsigned int, u8, bool, unsigned int *);
+static int mc34708_adc_conversion(struct mc13xxx *, unsigned int,
+				  unsigned int, u8, bool, unsigned int *);
+
 /* These are only exported for mc13xxx-i2c and mc13xxx-spi */
 struct mc13xxx_variant mc13xxx_variant_mc13783 = {
 	.name = "mc13783",
 	.print_revision = mc13xxx_print_revision,
+	.adc_do_conversion = mc13xxx_adc_conversion,
 };
 EXPORT_SYMBOL_GPL(mc13xxx_variant_mc13783);
 
 struct mc13xxx_variant mc13xxx_variant_mc13892 = {
 	.name = "mc13892",
 	.print_revision = mc13xxx_print_revision,
+	.adc_do_conversion = mc13xxx_adc_conversion,
 };
 EXPORT_SYMBOL_GPL(mc13xxx_variant_mc13892);
 
 struct mc13xxx_variant mc13xxx_variant_mc34708 = {
 	.name = "mc34708",
 	.print_revision = mc34708_print_revision,
+	.adc_do_conversion = mc34708_adc_conversion,
 };
 EXPORT_SYMBOL_GPL(mc13xxx_variant_mc34708);
 

@@ -252,7 +279,7 @@ static irqreturn_t mc13xxx_handler_adcdone(int irq, void *data)
 
 #define MC13XXX_ADC_WORKING (1 << 0)
 
-int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode,
+static int mc13xxx_adc_conversion(struct mc13xxx *mc13xxx, unsigned int mode,
 		unsigned int channel, u8 ato, bool atox,
 		unsigned int *sample)
 {

@@ -345,6 +372,95 @@ int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode,
 
 	return ret;
 }
+
+static int mc34708_adc_conversion(struct mc13xxx *mc13xxx, unsigned int mode,
+		unsigned int channel, u8 ato, bool atox,
+		unsigned int *sample)
+{
+	int ret, i;
+	u32 adc0, adc3, adc1, old_adc0;
+	struct mc13xxx_adcdone_data adcdone_data = {
+		.mc13xxx = mc13xxx,
+	};
+
+	switch (mode) {
+	case MC13XXX_ADC_MODE_TS:
+		adc0 = MC34708_ADC0_TSEN | MC34708_ADC0_TSSTART |
+			MC34708_ADC0_TSSTOP(7);
+
+		adc1 = MC34708_ADC1_TSDLY1(0xf) |
+			MC34708_ADC1_TSDLY2(0xf) |
+			MC34708_ADC1_TSDLY3(0xf);
+
+		adc3 = MC34708_ADC3_TSSEL(0, MC34708_TS_X) |
+			MC34708_ADC3_TSSEL(1, MC34708_TS_Y) |
+			MC34708_ADC3_TSSEL(2, MC34708_TS_X) |
+			MC34708_ADC3_TSSEL(3, MC34708_TS_Y) |
+			MC34708_ADC3_TSSEL(4, MC34708_TS_X) |
+			MC34708_ADC3_TSSEL(5, MC34708_TS_R) |
+			MC34708_ADC3_TSSEL(6, MC34708_TS_Y) |
+			MC34708_ADC3_TSSEL(7, MC34708_TS_R);
+		break;
+
+	case MC13XXX_ADC_MODE_SINGLE_CHAN:
+	case MC13XXX_ADC_MODE_MULT_CHAN:
+	default:
+		return -EINVAL;
+	}
+
+	init_completion(&adcdone_data.done);
+
+	mc13xxx_lock(mc13xxx);
+
+	if (mc13xxx->adcflags & MC13XXX_ADC_WORKING) {
+		ret = -EBUSY;
+		goto out;
+	}
+
+	mc13xxx->adcflags |= MC13XXX_ADC_WORKING;
+
+	mc13xxx_reg_read(mc13xxx, MC13XXX_ADC0, &old_adc0);
+
+	mc13xxx_irq_request(mc13xxx, MC34708_IRQ_TSDONE,
+			mc13xxx_handler_adcdone, __func__, &adcdone_data);
+	mc13xxx_irq_ack(mc13xxx, MC34708_IRQ_TSDONE);
+
+	mc13xxx_reg_write(mc13xxx, MC34708_ADC3, adc3);
+	mc13xxx_reg_write(mc13xxx, MC13XXX_ADC1, adc1);
+	mc13xxx_reg_write(mc13xxx, MC13XXX_ADC0, adc0);
+
+	mc13xxx_unlock(mc13xxx);
+
+	ret = wait_for_completion_interruptible_timeout(&adcdone_data.done, HZ);
+
+	mc13xxx_lock(mc13xxx);
+
+	mc13xxx_irq_free(mc13xxx, MC34708_IRQ_TSDONE, &adcdone_data);
+
+	if (!ret) {
+		ret = -ETIMEDOUT;
+		goto out;
+	}
+
+	for (i = 0; i < 4; i++)
+		mc13xxx_reg_read(mc13xxx, MC34708_ADC4 + i, &sample[i]);
+
+out:
+	ret = mc13xxx_reg_write(mc13xxx, MC13XXX_ADC0, old_adc0);
+
+	mc13xxx->adcflags &= ~MC13XXX_ADC_WORKING;
+	mc13xxx_unlock(mc13xxx);
+
+	return ret;
+}
+
+int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode,
+		unsigned int channel, u8 ato, bool atox,
+		unsigned int *sample)
+{
+	return mc13xxx->variant->adc_do_conversion(mc13xxx, mode, channel, ato,
+			atox, sample);
+}
 EXPORT_SYMBOL_GPL(mc13xxx_adc_do_conversion);
 
 static int mc13xxx_add_subdevice_pdata(struct mc13xxx *mc13xxx,
drivers/mfd/mc13xxx.h +3 -0
index 33677d1dcf66..17001116d638 100644
@@ -22,6 +22,9 @@ struct mc13xxx;
 struct mc13xxx_variant {
 	const char *name;
 	void (*print_revision)(struct mc13xxx *mc13xxx, u32 revision);
+	int (*adc_do_conversion)(struct mc13xxx *mc13xxx, unsigned int mode,
+		unsigned int channel, u8 ato, bool atox,
+		unsigned int *sample);
 };
 
 extern struct mc13xxx_variant
Signature · 1 line
2.11.0
#1 lore raw
Quoted 8 lines · Lukasz Majewski

From: Sascha Hauer <[email protected]>

The mc34708 has an improved adc. The older variants will always convert a fixed order of channels. The mc34708 can do up to eight conversions in arbitrary channel order. Currently this extended feature is not supported. We only support touchscreen conversions now, which will be sampled in a data format compatible to the older chips in order to keep the API between the mfd and the touchscreen driver.

[]

drivers/mfd/mc13xxx-core.c

Quoted 1 line
drivers/mfd/mc13xxx-core.c +0 -0

[]

drivers/mfd/mc13xxx-core.c int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode, · line 380

Quoted 5 lines
drivers/mfd/mc13xxx-core.c +5 -0
+static int mc34708_adc_conversion(struct mc13xxx *mc13xxx, unsigned int mode,
+		unsigned int channel, u8 ato, bool atox,
+		unsigned int *sample)
+{
+	int ret, i;

[]

drivers/mfd/mc13xxx-core.c int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode, · line 418

Quoted 4 lines
drivers/mfd/mc13xxx-core.c +4 -0
+	if (mc13xxx->adcflags & MC13XXX_ADC_WORKING) {
+		ret = -EBUSY;
+		goto out;
+	}

This doesn't work.

drivers/mfd/mc13xxx-core.c int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode, · line 443

Quoted 7 lines

[]

drivers/mfd/mc13xxx-core.c +6 -0
+	mc13xxx_irq_free(mc13xxx, MC34708_IRQ_TSDONE, &adcdone_data);
+
+	if (!ret) {
+		ret = -ETIMEDOUT;
+		goto out;
+	}

[]

drivers/mfd/mc13xxx-core.c int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode, · line 449

Quoted 2 lines
drivers/mfd/mc13xxx-core.c +2 -0
+out:
+	ret = mc13xxx_reg_write(mc13xxx, MC13XXX_ADC0, old_adc0);

ret is reassigned here, so the ret = -<FOO>
uses above don't do what is expected.

Quoted 6 lines
drivers/mfd/mc13xxx-core.c +6 -0
+
+	mc13xxx->adcflags &= ~MC13XXX_ADC_WORKING;
+	mc13xxx_unlock(mc13xxx);
+
+	return ret;
+}
author
#2 lore raw

Hi Joe,

Quoted 36 lines · Lukasz Majewski
Quoted 9 lines

From: Sascha Hauer <[email protected]>

The mc34708 has an improved adc. The older variants will always convert a fixed order of channels. The mc34708 can do up to eight conversions in arbitrary channel order. Currently this extended feature is not supported. We only support touchscreen conversions now, which will be sampled in a data format compatible to the older chips in order to keep the API between the mfd and the touchscreen driver.

[]

drivers/mfd/mc13xxx-core.c

Quoted 2 lines
drivers/mfd/mc13xxx-core.c +0 -0

[]

drivers/mfd/mc13xxx-core.c int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode, · line 380

Quoted 6 lines

+static int mc34708_adc_conversion(struct mc13xxx *mc13xxx, unsigned int mode,

drivers/mfd/mc13xxx-core.c +4 -0
+		unsigned int channel, u8 ato, bool atox,
+		unsigned int *sample)
+{
+	int ret, i;

[]

drivers/mfd/mc13xxx-core.c int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode, · line 418

Quoted 4 lines
drivers/mfd/mc13xxx-core.c +4 -0
+	if (mc13xxx->adcflags & MC13XXX_ADC_WORKING) {
+		ret = -EBUSY;
+		goto out;
+	}

This doesn't work.

drivers/mfd/mc13xxx-core.c int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode, · line 443

Quoted 7 lines

[]

drivers/mfd/mc13xxx-core.c +1 -0
+	mc13xxx_irq_free(mc13xxx, MC34708_IRQ_TSDONE,

&adcdone_data); +

drivers/mfd/mc13xxx-core.c +4 -0
+	if (!ret) {
+		ret = -ETIMEDOUT;
+		goto out;
+	}

[]

Quoted 5 lines

drivers/mfd/mc13xxx-core.c int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode, · line 449

Quoted 2 lines
drivers/mfd/mc13xxx-core.c +2 -0
+out:
+	ret = mc13xxx_reg_write(mc13xxx, MC13XXX_ADC0, old_adc0);

ret is reassigned here, so the ret = -<FOO>
uses above don't do what is expected.

Right. Thanks for spotting this. I will fix it in v2.

Quoted 8 lines

drivers/mfd/mc13xxx-core.c int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode, · line 455

Quoted 7 lines
drivers/mfd/mc13xxx-core.c +6 -0
+
+	mc13xxx->adcflags &= ~MC13XXX_ADC_WORKING;
+	mc13xxx_unlock(mc13xxx);
+
+	return ret;
+}

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]