Skip to contentSkip to conversation

support/download/dl-wrapper: pass the correct -N option

PATCH New Thomas Petazzoni 2 participants 3 messages Apr 11, 2018 – Apr 12, 2018

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 support/download/dl-wrapper: pass the correct -N option

${raw_name} is never defined in dl-wrapper, and therefore the value passed to the -N option is always empty. This causes a problem for the 'cvs' backend, which uses the value of this option as the CVS module to be downloaded.

If the name of the CVS module is omitted, all the CVS modules from that CVS repository are downloaded, which creates a tarball with a lot more contents, and the actual useful contents in a sub-directory, obviously breaking patches that should be applied, and the entire build process that follows.

Fixes:

http://autobuild.buildroot.net/results/fcee0e3d7eeeb373313b1794092c729b1b052348/

Signed-off-by Thomas Petazzoni <[email protected]>
---
 support/download/dl-wrapper | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/download/dl-wrapper +1 -1
index 3d2118a4ef..8d6365e08d 100755
@@ -125,7 +125,7 @@ main() {
                 -c "${cset}" \
                 -d "${dl_dir}" \
                 -n "${raw_base_name}" \
-                -N "${raw_name}" \
+                -N "${base_name}" \
                 -f "${filename}" \
                 -u "${uri}" \
                 -o "${tmpf}" \
Signature · 1 line
2.14.3
#1 lore raw

PATCH 1/1 support/download/dl-wrapper: pass the correct -N option

On 2018-04-11 10:10 +0200, Thomas Petazzoni spake thusly:

Quoted 11 lines

${raw_name} is never defined in dl-wrapper, and therefore the value passed to the -N option is always empty. This causes a problem for the 'cvs' backend, which uses the value of this option as the CVS module to be downloaded.

If the name of the CVS module is omitted, all the CVS modules from that CVS repository are downloaded, which creates a tarball with a lot more contents, and the actual useful contents in a sub-directory, obviously breaking patches that should be applied, and the entire build process that follows.

Quoted 5 lines

Fixes:

http://autobuild.buildroot.net/results/fcee0e3d7eeeb373313b1794092c729b1b052348/

Signed-off-by Thomas Petazzoni <[email protected]>
Tested-by "Yann E. MORIN" <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

When can we eventually drop this cvs backend for good, now? ;-)

Regards,
Yann E. MORIN.

Quoted 20 lines
---
 support/download/dl-wrapper | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/download/dl-wrapper +1 -1
index 3d2118a4ef..8d6365e08d 100755
@@ -125,7 +125,7 @@ main() {
                 -c "${cset}" \
                 -d "${dl_dir}" \
                 -n "${raw_base_name}" \
-                -N "${raw_name}" \
+                -N "${base_name}" \
                 -f "${filename}" \
                 -u "${uri}" \
                 -o "${tmpf}" \
Signature · 1 line
2.14.3
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author Applied
#2 lore raw

PATCH 1/1 support/download/dl-wrapper: pass the correct -N option

In reply to Thomas Petazzoni

Hello,

Quoted 11 lines · Thomas Petazzoni

${raw_name} is never defined in dl-wrapper, and therefore the value passed to the -N option is always empty. This causes a problem for the 'cvs' backend, which uses the value of this option as the CVS module to be downloaded.

If the name of the CVS module is omitted, all the CVS modules from that CVS repository are downloaded, which creates a tarball with a lot more contents, and the actual useful contents in a sub-directory, obviously breaking patches that should be applied, and the entire build process that follows.

Quoted 8 lines

Fixes:

http://autobuild.buildroot.net/results/fcee0e3d7eeeb373313b1794092c729b1b052348/

Signed-off-by Thomas Petazzoni <[email protected]>
---
 support/download/dl-wrapper | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com