Skip to contentSkip to conversation

nvme: Use admin command effects for admin commands

PATCH New Keith Busch 2 participants 2 messages Apr 11, 2018 – Apr 12, 2018 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme: Use admin command effects for admin commands

Signed-off-by Keith Busch <keith.busch at intel.com>

---
This was correct in the first few versions of this patch, and goofed up on the last one somehow. Didn't notice until I tested a drive with the capability today.

 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/core.c +1 -1
index b70f02bafac6..6ed91ae7f740 100644
@@ -1102,7 +1102,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
 	}
 
 	if (ctrl->effects)
-		effects = le32_to_cpu(ctrl->effects->iocs[opcode]);
+		effects = le32_to_cpu(ctrl->effects->acs[opcode]);
 	else
 		effects = nvme_known_admin_effects(opcode);
 
Signature · 1 line
2.14.3
#1 lore raw

PATCH 1/1 nvme: Use admin command effects for admin commands

Quoted 8 lines · Keith Busch
Signed-off-by Keith Busch <keith.busch at intel.com>

---
This was correct in the first few versions of this patch, and goofed up on the last one somehow. Didn't notice until I tested a drive with the capability today.

 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Looks good!

Btw, time to send another nvme update to Jens?

Quoted 17 lines
drivers/nvme/host/core.c +1 -1
index b70f02bafac6..6ed91ae7f740 100644
@@ -1102,7 +1102,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
 	}
 
 	if (ctrl->effects)
-		effects = le32_to_cpu(ctrl->effects->iocs[opcode]);
+		effects = le32_to_cpu(ctrl->effects->acs[opcode]);
 	else
 		effects = nvme_known_admin_effects(opcode);
 
Signature · 1 line
2.14.3

---end quoted text---