Skip to contentSkip to conversation

staging: ks7010_sdio: fix memory leak

PATCH New Gustavo A. R. Silva 1 participant 1 message Apr 12, 2018 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: ks7010_sdio: fix memory leak

Memory allocated for netdev at line 854:
netdev = alloc_etherdev(sizeof(*priv));
is not being free'd before return, hence
there is a memory leak.

Fix this by freeing netdev before return.

Addresses-Coverity-ID: 1467844

---
Changes in v2:
- Update subject and commit changelog.
- Just directly free netdev. Thanks to Dan Carpenter for the feedback.

 drivers/staging/ks7010/ks7010_sdio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/ks7010/ks7010_sdio.c +1 -2
index b8f55a1..2c9b92c 100644
@@ -932,8 +932,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	return 0;
 
  err_free_netdev:
-	free_netdev(priv->net_dev);
-	card->priv = NULL;
+	free_netdev(netdev);
  err_release_irq:
 	sdio_claim_host(func);
 	sdio_release_irq(func);
Signature · 1 line
2.7.4