Skip to contentSkip to conversation

package/llvm: fix typo in llvm.mk

PATCH New Valentin Korenblit 2 participants 2 messages Apr 12, 2018

lore
Share & tools
lore

Valentin Korenblit

author
#0 lore raw

PATCH 1/1 package/llvm: fix typo in llvm.mk

"+=" was missing in -DLLVM_TARGETS_TO_BUILD, so LLVM_CONF_OPTS and HOST_LLVM_CONF_OPTS before this option weren't being considered.

Signed-off-by Valentin Korenblit <[email protected]>
---
 package/llvm/llvm.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/llvm/llvm.mk +2 -2
index 4b4f96e5f1..d19f8a0b87 100644
@@ -42,8 +42,8 @@ LLVM_TARGET_ARCH = $(call qstrip,$(BR2_PACKAGE_LLVM_TARGET_ARCH))
 
 # Build backend for target architecture. This include backends like AMDGPU.
 LLVM_TARGETS_TO_BUILD = $(LLVM_TARGET_ARCH)
-HOST_LLVM_CONF_OPTS = -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
-LLVM_CONF_OPTS = -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
+HOST_LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
+LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
 
 # LLVM target to use for native code generation. This is required for JIT generation.
 # It must be set to LLVM_TARGET_ARCH for host and target, otherwise we get
Signature · 1 line
2.14.3
Applied
#1 lore raw

PATCH 1/1 package/llvm: fix typo in llvm.mk

Hello,

Quoted 7 lines · Valentin Korenblit

"+=" was missing in -DLLVM_TARGETS_TO_BUILD, so LLVM_CONF_OPTS and HOST_LLVM_CONF_OPTS before this option weren't being considered.

Signed-off-by Valentin Korenblit <[email protected]>
---
 package/llvm/llvm.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com