Skip to contentSkip to conversation

pixiewps: new package

PATCH New Guillaume W. Bres 3 participants 4 messages Apr 12, 2018 – Apr 13, 2018

lore
Share & tools
lore

Guillaume W. Bres

author
#0 lore raw

PATCH 1/1 pixiewps: new package

Pixie WPS is a C based tool to audit networks
against so called "Pixie Dust" attacks.

Generic C package, easy to cross-compile,
build tests passed for the 7 default toolchains.

Sorry my previous submission was somehow corrupted. Tested on RPI1 & RPI3.

Signed-off-by Guillaume W. Bres <[email protected]>
---
 DEVELOPERS                     |  1 +
 package/Config.in              |  1 +
 package/pixiewps/Config.in     |  7 +++++++
 package/pixiewps/pixiewps.hash |  3 +++
 package/pixiewps/pixiewps.mk   | 21 +++++++++++++++++++++
 5 files changed, 33 insertions(+)
 create mode 100644 package/pixiewps/Config.in
 create mode 100644 package/pixiewps/pixiewps.hash
 create mode 100644 package/pixiewps/pixiewps.mk
DEVELOPERS +1 -0
index 00cbaef..054ed09 100644
@@ -794,6 +794,7 @@ F:	package/sdl2/
 
 N:	Guillaume William Brs <[email protected]>
 F:	package/liquid-dsp/
+F:	package/pixiewps/
 
 N:	Guo Ren <[email protected]>
 F:	arch/Config.in.csky
package/Config.in +1 -0
index e48d0b4..132372c 100644
@@ -1809,6 +1809,7 @@ endif
 	source "package/phidgetwebservice/Config.in"
 	source "package/phytool/Config.in"
 	source "package/pimd/Config.in"
+	source "package/pixiewps/Config.in"
 	source "package/pound/Config.in"
 	source "package/pppd/Config.in"
 	source "package/pptp-linux/Config.in"
package/pixiewps/Config.in new file +7 -0
new file mode 100644
index 0000000..d0b9b99
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_PIXIEWPS
+	bool "pixiewps"
+	help
+	  Pixie WPS is a C based tool to audit networks
+	  against the so called "Pixie Dust" attack.
+
+	  https://github.com/wiire-a/pixiewps/wiki
package/pixiewps/pixiewps.hash new file +3 -0
new file mode 100644
index 0000000..bb56630
@@ -0,0 +1,3 @@
+# locally computed
+sha256 d3d3cf57851e3e734fb1797aa078239ef161d1cbeffc4438497d58a425ef22a2  pixiewps-9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59.tar.gz
+sha256 ccb349b4132ed7737f25e5adebfe61f3d52dca33708df1e50352320438d1d4c2  LICENSE.md
package/pixiewps/pixiewps.mk new file +21 -0
new file mode 100644
index 0000000..746fa71
@@ -0,0 +1,21 @@
+################################################################################
+#
+# pixiewps
+#
+################################################################################
+
+PIXIEWPS_VERSION = 9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59
+PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,$(PIXIEWPS_VERSION))
+PIXIEWPS_LICENSE = GPL-2.0+
+PIXIEWPS_LICENSE_FILES = LICENSE.md
+
+define PIXIEWPS_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) CC=$(TARGET_CC) -C $(@D)
+endef
+
+define PIXIEWPS_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(TARGET_DIR) \
+		prefix=/usr -C $(@D)/$(PIXIEWPS_SUBDIR) install
+endef
+
+$(eval $(generic-package))
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 pixiewps: new package

Hi Guillaume,

Quoted 14 lines · Guillaume W. Bres
package/pixiewps/pixiewps.mk new file +8 -0
new file mode 100644
index 0000000..746fa71
@@ -0,0 +1,21 @@
+################################################################################
+#
+# pixiewps
+#
+################################################################################
+
+PIXIEWPS_VERSION = 9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59
+PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,$(PIXIEWPS_VERSION))

package/pixiewps/pixiewps.mk line 18

Quoted 10 lines
package/pixiewps/pixiewps.mk new file +10 -0
+PIXIEWPS_LICENSE = GPL-2.0+
+PIXIEWPS_LICENSE_FILES = LICENSE.md
+
+define PIXIEWPS_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) CC=$(TARGET_CC) -C $(@D)
+endef
+
+define PIXIEWPS_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(TARGET_DIR) \
+		prefix=/usr -C $(@D)/$(PIXIEWPS_SUBDIR) install

Where is PIXIEWPS_SUBDIR defined?

package/pixiewps/pixiewps.mk line 21

Quoted 3 lines
package/pixiewps/pixiewps.mk new file +3 -0
+endef
+
+$(eval $(generic-package))

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 pixiewps: new package

In reply to Guillaume W. Bres

Hello,

Thanks for this new version. I applied it, but after doing a number of changes.

Quoted 8 lines · Guillaume W. Bres

Pixie WPS is a C based tool to audit networks
against so called "Pixie Dust" attacks.

Generic C package, easy to cross-compile,
build tests passed for the 7 default toolchains.

Sorry my previous submission was somehow corrupted. Tested on RPI1 & RPI3.

Changelog information should not go in the commit log, but...

Quoted 2 lines
Signed-off-by Guillaume W. Bres <[email protected]>

---

... here.

Quoted 6 lines
package/pixiewps/pixiewps.mk new file +0 -0
new file mode 100644
index 0000000..746fa71

package/pixiewps/pixiewps.mk line 9

Quoted 9 lines
package/pixiewps/pixiewps.mk new file +9 -0
@@ -0,0 +1,21 @@
+################################################################################
+#
+# pixiewps
+#
+################################################################################
+
+PIXIEWPS_VERSION = 9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59
+PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,$(PIXIEWPS_VERSION))
+PIXIEWPS_LICENSE = GPL-2.0+

This was not correct, the license is GPL-3.0+

package/pixiewps/pixiewps.mk line 18

Quoted 9 lines
package/pixiewps/pixiewps.mk new file +9 -0
+PIXIEWPS_LICENSE_FILES = LICENSE.md
+
+define PIXIEWPS_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) CC=$(TARGET_CC) -C $(@D)
+endef
+
+define PIXIEWPS_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(TARGET_DIR) \
+		prefix=/usr -C $(@D)/$(PIXIEWPS_SUBDIR) install

prefix= doesn't have any effect, and the binary was installed in usr/local/bin because of this. You should have used PREFIX= instead.

PIXIEWPS_SUBDIR was never defined anywhere, and in fact was not needed at all.

I've fixed those issues and applied to master. Thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#3 lore raw

PATCH 1/1 pixiewps: new package

Thank you Thomas,

Le 12/04/2018 ? 23:42, Thomas Petazzoni a ?crit?:

Quoted 2 lines

IXIEWPS_SUBDIR was never defined anywhere, and in fact was not needed at all.

yes that was faulty, worked ok but produced an error message, my bad. Thank you for removing the non needed line

Quoted 1 line · Thomas Petazzoni

Changelog information should not go in the commit log, but...

ok I will keep that in mind for next time

Signature · 4 lines
Guillaume W. Bres,
Software engineer,
NoiseXT,
Elancourt - France