Skip to contentSkip to conversation

fs: f2fs: Adding new return type vm_fault_t

PATCH In review Souptick Joarder 3 participants 6 messages Apr 14, 2018 – May 14, 2018 F2FS file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: f2fs: Adding new return type vm_fault_t

Use new return type vm_fault_t for page_mkwrite
and fault handler.

---
 fs/f2fs/file.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
fs/f2fs/file.c +5 -5
index 672a542..045337a 100644
@@ -33,19 +33,19 @@
 #include "trace.h"
 #include <trace/events/f2fs.h>
 
-static int f2fs_filemap_fault(struct vm_fault *vmf)
+static vm_fault_t f2fs_filemap_fault(struct vm_fault *vmf)
 {
 	struct inode *inode = file_inode(vmf->vma->vm_file);
-	int err;
+	vm_fault_t ret;
 
 	down_read(&F2FS_I(inode)->i_mmap_sem);
-	err = filemap_fault(vmf);
+	ret = filemap_fault(vmf);
 	up_read(&F2FS_I(inode)->i_mmap_sem);
 
-	return err;
+	return ret;
 }
 
-static int f2fs_vm_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
 {
 	struct page *page = vmf->page;
 	struct inode *inode = file_inode(vmf->vma->vm_file);
Signature · 6 lines
1.9.1


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Souptick Joarder

Use new return type vm_fault_t for page_mkwrite
and fault handler.

Thanks,

Quoted 24 lines
---
 fs/f2fs/file.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
fs/f2fs/file.c +3 -3
index 672a542..045337a 100644
@@ -33,19 +33,19 @@
 #include "trace.h"
 #include <trace/events/f2fs.h>
 
-static int f2fs_filemap_fault(struct vm_fault *vmf)
+static vm_fault_t f2fs_filemap_fault(struct vm_fault *vmf)
 {
 	struct inode *inode = file_inode(vmf->vma->vm_file);
-	int err;
+	vm_fault_t ret;
 
 	down_read(&F2FS_I(inode)->i_mmap_sem);
-	err = filemap_fault(vmf);
+	ret = filemap_fault(vmf);
 	up_read(&F2FS_I(inode)->i_mmap_sem);

fs/f2fs/file.c line 51

Quoted 10 lines
fs/f2fs/file.c +2 -2
 
-	return err;
+	return ret;
 }
 
-static int f2fs_vm_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
 {
 	struct page *page = vmf->page;
 	struct inode *inode = file_inode(vmf->vma->vm_file);

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot

#2 lore raw
Quoted 9 lines · Chao Yu
Quoted 5 lines · Souptick Joarder

Use new return type vm_fault_t for page_mkwrite
and fault handler.

Chao, If no further comment, we would like to get this patch queued for 4.18.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot

maintainer
#3 lore raw
Quoted 5 lines · Souptick Joarder
Quoted 4 lines · Chao Yu
Quoted 3 lines · Souptick Joarder

Use new return type vm_fault_t for page_mkwrite
and fault handler.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Chao, If no further comment, we would like to get this patch queued for 4.18.

Hi Souptick,

Is this one of your patch series?
I already queued it towards 4.18:

https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=f8fcb679cfbeb2076c547364929182babdd69a50

Thanks,

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot

#4 lore raw
Quoted 15 lines · Jaegeuk Kim
Quoted 5 lines · Souptick Joarder
Quoted 4 lines · Chao Yu
Quoted 3 lines · Souptick Joarder

Use new return type vm_fault_t for page_mkwrite
and fault handler.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Chao, If no further comment, we would like to get this patch queued for 4.18.

Quoted 8 lines

Hi Souptick,

Is this one of your patch series?
I already queued it towards 4.18:

https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=f8fcb679cfbeb2076c547364929182babdd69a50

Thanks,

Thanks.
Not exactly part of patch series. But we are trickling patches to individual maintainers of each drivers/ filesystems to merge it in linus tree.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot

#5 lore raw
Quoted 7 lines · Souptick Joarder
Quoted 6 lines · Jaegeuk Kim
Quoted 5 lines · Souptick Joarder
Quoted 4 lines · Chao Yu
Quoted 3 lines · Souptick Joarder

Use new return type vm_fault_t for page_mkwrite
and fault handler.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Chao, If no further comment, we would like to get this patch

No further comment, no matter queuing in Jaegeuk's tree or other one's tree is OK to me. ;)

Thanks,

Quoted 7 lines
Quoted 7 lines
Quoted 1 line

queued for 4.18.

Hi Souptick,

Is this one of your patch series?
I already queued it towards 4.18:

Quoted 10 lines
Quoted 3 lines

https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=f8fcb679cfbeb2076c547364929182babdd69a50

Thanks,

Thanks.
Not exactly part of patch series. But we are trickling patches to individual maintainers of each drivers/ filesystems to merge it in linus tree.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot