Enabling content-type setting for external HDMI displays.
Subsystems (4)
cover Enabling content-type setting for external HDMI displays.
From: Stanislav Lisovskiy <[email protected]>
Added content type setting property to drm_connector(part 1) and enabled transmitting it with HDMI AVI infoframes for i915(part 2).
Stanislav Lisovskiy (2):
drm: content-type property for HDMI connector
i915: content-type property for HDMI connector
Documentation/gpu/kms-properties.csv | 1 + drivers/gpu/drm/drm_atomic.c | 4 ++++ drivers/gpu/drm/drm_connector.c | 34 ++++++++++++++++++++++++++++ drivers/gpu/drm/drm_edid.c | 1 + drivers/gpu/drm/i915/intel_atomic.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_hdmi.c | 4 ++++ drivers/gpu/drm/i915/intel_modes.c | 10 ++++++++ include/drm/drm_connector.h | 10 ++++++++ include/drm/drm_mode_config.h | 5 ++++ include/uapi/drm/drm_mode.h | 5 ++++ 11 files changed, 76 insertions(+)
Signature · 6 lines
2.17.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for Enabling content-type setting for external HDMI displays. (rev2)
== Series Details ==
== Series Details ==
Series: Enabling content-type setting for external HDMI displays. (rev2)
URL : https://patchwork.freedesktop.org/series/41744/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip ff3a198613ab drm: content-type property for HDMI connector -:84: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #84: FILE: drivers/gpu/drm/drm_connector.c:1287: + drm_property_create_enum(dev, 0, "content type", + drm_content_type_enum_list,
-:87: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!dev->mode_config.content_type_property" #87: FILE: drivers/gpu/drm/drm_connector.c:1290:
+ if (dev->mode_config.content_type_property == NULL)
total: 0 errors, 0 warnings, 2 checks, 120 lines checked a21e5056a6f9 i915: content-type property for HDMI connector -:73: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #73: FILE: drivers/gpu/drm/i915/intel_modes.c:142:
+ drm_object_attach_property(&connector->base,
+ connector->dev->mode_config.content_type_property,
total: 0 errors, 0 warnings, 1 checks, 44 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for Enabling content-type setting for external HDMI displays. (rev2)
In reply to StanLis== Series Details ==
== Series Details ==
Series: Enabling content-type setting for external HDMI displays. (rev2)
URL : https://patchwork.freedesktop.org/series/41744/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4054 -> Patchwork_8696 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41744/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_8696 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-no-display:
fi-cnl-psr: NOTRUN -> DMESG-WARN (fdo#105395) +2
igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence:
fi-cnl-psr: NOTRUN -> FAIL (fdo#103481)
==== Possible fixes ====
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: FAIL (fdo#104008) -> PASS fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#105395 https://bugs.freedesktop.org/show_bug.cgi?id=105395
== Participating hosts (35 -> 21) ==
Additional (1): fi-cnl-psr
Missing (15): fi-ilk-m540 fi-bxt-dsi fi-skl-gvtdvm fi-bsw-n3050 fi-byt-j1900 fi-skl-6770hq fi-bdw-gvtdvm fi-skl-6260u fi-bwr-2160 fi-cfl-s3 fi-bxt-j4205 fi-gdg-551 fi-pnv-d510 fi-skl-6700hq fi-skl-6600u
== Build changes ==
* Linux: CI_DRM_4054 -> Patchwork_8696
CI_DRM_4054: a0e39233b88795009de32094efa8a2135f34338f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4430: 8b77704db49167f7ebfd1c470d9c129d3b862cb6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8696: a21e5056a6f99d399a7f76fa8d02094cd8224538 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4430: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit
== Linux commits ==
a21e5056a6f9 i915: content-type property for HDMI connector ff3a198613ab drm: content-type property for HDMI connector
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8696/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for Enabling content-type setting for external HDMI displays. (rev2)
In reply to StanLis== Series Details ==
== Series Details ==
Series: Enabling content-type setting for external HDMI displays. (rev2)
URL : https://patchwork.freedesktop.org/series/41744/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4054_full -> Patchwork_8696_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_8696_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_8696_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41744/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8696_full:
=== IGT changes ===
==== Possible regressions ====
igt@kms_cursor_crc@cursor-256x256-suspend:
shard-snb: PASS -> DMESG-WARN
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-ctx-dirty-render:
shard-kbl: SKIP -> PASS +1== Known issues ==
Here are the changes found in Patchwork_8696_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@fence-restore-untiled:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@kms_rotation_crc@sprite-rotation-180:
shard-snb: PASS -> FAIL (fdo#103925)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@kms_sysfs_edid_timing:
shard-apl: PASS -> WARN (fdo#100047)
==== Possible fixes ====
igt@kms_cursor_legacy@flip-vs-cursor-toggle:
shard-hsw: FAIL (fdo#102670) -> PASS
igt@kms_flip@2x-plain-flip-ts-check:
shard-hsw: FAIL (fdo#100368) -> PASS
igt@kms_flip@wf_vblank-ts-check:
shard-hsw: FAIL (fdo#103928) -> PASS fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 4) ==
Missing (2): shard-glk shard-glkb
== Build changes ==
* Linux: CI_DRM_4054 -> Patchwork_8696
CI_DRM_4054: a0e39233b88795009de32094efa8a2135f34338f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4430: 8b77704db49167f7ebfd1c470d9c129d3b862cb6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8696: a21e5056a6f99d399a7f76fa8d02094cd8224538 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4430: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8696/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/2 drm: content-type property for HDMI connector
In reply to StanLisFrom: Stanislav Lisovskiy <[email protected]>
Added content_type property todrm_connector_state in order to properly handle
external HDMI TV content-type setting.
--- Documentation/gpu/kms-properties.csv | 1 + drivers/gpu/drm/drm_atomic.c | 4 ++++ drivers/gpu/drm/drm_connector.c | 34 ++++++++++++++++++++++++++++ drivers/gpu/drm/drm_edid.c | 1 + include/drm/drm_connector.h | 10 ++++++++ include/drm/drm_mode_config.h | 5 ++++ include/uapi/drm/drm_mode.h | 5 ++++ 7 files changed, 60 insertions(+)
Documentation/gpu/kms-properties.csv +1 -0
@@ -17,6 +17,7 @@ Owner Module/Drivers,Group,Property Name,Type,Property Values,Object attached,De ,Virtual GPU,“suggested X”,RANGE,"Min=0, Max=0xffffffff",Connector,property to suggest an X offset for a connector ,,“suggested Y”,RANGE,"Min=0, Max=0xffffffff",Connector,property to suggest an Y offset for a connector ,Optional,"""aspect ratio""",ENUM,"{ ""None"", ""4:3"", ""16:9"" }",Connector,TDB +,Optional,"""content type""",ENUM,"{ ""Graphics"", ""Photo"", ""Cinema"", ""Game"" }",Connector,TDB i915,Generic,"""Broadcast RGB""",ENUM,"{ ""Automatic"", ""Full"", ""Limited 16:235"" }",Connector,"When this property is set to Limited 16:235 and CTM is set, the hardware will be programmed with the result of the multiplication of CTM by the limited range matrix to ensure the pixels normaly in the range 0..1.0 are remapped to the range 16/255..235/255." ,,“audio”,ENUM,"{ ""force-dvi"", ""off"", ""auto"", ""on"" }",Connector,TBD ,SDVO-TV,“mode”,ENUM,"{ ""NTSC_M"", ""NTSC_J"", ""NTSC_443"", ""PAL_B"" } etc.",Connector,TBD
drivers/gpu/drm/drm_atomic.c +4 -0
@@ -1266,6 +1266,8 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector, state->link_status = val; }else if (property == config->aspect_ratio_property) { state->picture_aspect_ratio = val; + }else if (property == config->content_type_property) { + state->content_type = val; }else if (property == connector->scaling_mode_property) { state->scaling_mode = val; }else if (property == connector->content_protection_property) {
@@ -1351,6 +1353,8 @@ drm_atomic_connector_get_property(struct drm_connector *connector, *val = state->link_status; }else if (property == config->aspect_ratio_property) { *val = state->picture_aspect_ratio; + }else if (property == config->content_type_property) { + *val = state->content_type; }else if (property == connector->scaling_mode_property) { *val = state->scaling_mode; }else if (property == connector->content_protection_property) {
drivers/gpu/drm/drm_connector.c +34 -0
@@ -720,6 +720,13 @@ static const struct drm_prop_enum_list drm_aspect_ratio_enum_list[] = { { DRM_MODE_PICTURE_ASPECT_16_9, "16:9" }, }; +static const struct drm_prop_enum_list drm_content_type_enum_list[] = { + {DRM_MODE_CONTENT_TYPE_GRAPHICS ,"GRAPHICS" }, + {DRM_MODE_CONTENT_TYPE_PHOTO ,"PHOTO" }, + {DRM_MODE_CONTENT_TYPE_CINEMA ,"CINEMA" }, + {DRM_MODE_CONTENT_TYPE_GAME ,"GAME" }, +}; +static const struct drm_prop_enum_list drm_panel_orientation_enum_list[] = { {DRM_MODE_PANEL_ORIENTATION_NORMAL ,"Normal" }, { DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP, "Upside Down" },
@@ -1260,6 +1267,33 @@ int drm_mode_create_aspect_ratio_property(struct drm_device *dev) }EXPORT_SYMBOL (drm_mode_create_aspect_ratio_property); +/** +* drm_mode_create_content_type_property - create content type property +* @dev: DRM device +* +* Called by a driver the first time it's needed, must be attached to desired +* connectors. +* +* Returns: +* Zero on success, negative errno on failure. +*/ +int drm_mode_create_content_type_property (struct drm_device *dev) +{ +if (dev->mode_config.content_type_property) +return 0 ; + + dev->mode_config.content_type_property = +drm_property_create_enum (dev,0 ,"content type" , + drm_content_type_enum_list, +ARRAY_SIZE (drm_content_type_enum_list)); + +if (dev->mode_config.content_type_property ==NULL ) +return -ENOMEM ; + +return 0 ; +} +EXPORT_SYMBOL (drm_mode_create_content_type_property); +/** * drm_mode_create_suggested_offset_properties - create suggests offset properties * @dev: DRM device
drivers/gpu/drm/drm_edid.c +1 -0
@@ -4867,6 +4867,7 @@ drm_hdmi_avi_infoframe_from_display_mode(struct hdmi_avi_infoframe *frame, } frame->picture_aspect =HDMI_PICTURE_ASPECT_NONE ; + frame->content_type =HDMI_CONTENT_TYPE_GRAPHICS ;/* * Populate picture aspect ratio from either
include/drm/drm_connector.h +10 -0
@@ -418,6 +418,15 @@ struct drm_connector_state {*/ enum hdmi_picture_aspect picture_aspect_ratio; +/** +* @content_type: Connector property to control the +* HDMI infoframe content type setting. +* +* The %DRM_MODE_CONTENT_TYPE_\* values much match the +* values for &enum hdmi_content_type +*/ +enum hdmi_content_type content_type; +/** * @scaling_mode: Connector property to control the * upscaling, mostly used for built-in panels.
@@ -1094,6 +1103,7 @@ int drm_connector_attach_scaling_mode_property(struct drm_connector *connector,int drm_connector_attach_content_protection_property (struct drm_connector *connector);int drm_mode_create_aspect_ratio_property (struct drm_device *dev); +int drm_mode_create_content_type_property (struct drm_device *dev);int drm_mode_create_suggested_offset_properties (struct drm_device *dev); int drm_mode_connector_set_path_property(struct drm_connector *connector,
include/drm/drm_mode_config.h +5 -0
@@ -726,6 +726,11 @@ struct drm_mode_config {* HDMI infoframe aspect ratio setting. */ struct drm_property *aspect_ratio_property; +/** +* @content_type_property: Optional connector property to control the +* HDMI infoframe content type setting. +*/ +struct drm_property *content_type_property;/** * @degamma_lut_property: Optional CRTC property to set the LUT used to * convert the framebuffer's colors to linear gamma.
include/uapi/drm/drm_mode.h +5 -0
@@ -94,6 +94,11 @@ extern "C" {#define DRM_MODE_PICTURE_ASPECT_4_3 1#define DRM_MODE_PICTURE_ASPECT_16_9 2 +#define DRM_MODE_CONTENT_TYPE_GRAPHICS 0 +#define DRM_MODE_CONTENT_TYPE_PHOTO 1 +#define DRM_MODE_CONTENT_TYPE_CINEMA 2 +#define DRM_MODE_CONTENT_TYPE_GAME 3 +/* Aspect ratio flag bitmask (4 bits 22:19) */ #define DRM_MODE_FLAG_PIC_AR_MASK (0x0F<<19)#define DRM_MODE_FLAG_PIC_AR_NONE \
Signature · 6 lines
2.17.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 i915: content-type property for HDMI connector
In reply to StanLisFrom: Stanislav Lisovskiy <[email protected]>
Added encoding of drm content_type property from drm_connector_state within AVI infoframe in order to properly handle external HDMI TV content-type setting.
--- drivers/gpu/drm/i915/intel_atomic.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_hdmi.c | 4 ++++ drivers/gpu/drm/i915/intel_modes.c | 10 ++++++++++ 4 files changed, 16 insertions(+)
drivers/gpu/drm/i915/intel_atomic.c +1 -0
@@ -124,6 +124,7 @@ int intel_digital_connector_atomic_check(struct drm_connector *conn,if (new_conn_state->force_audio != old_conn_state->force_audio || new_conn_state->broadcast_rgb != old_conn_state->broadcast_rgb || new_conn_state->base.picture_aspect_ratio != old_conn_state->base.picture_aspect_ratio || + new_conn_state->base.content_type != old_conn_state->base.content_type || new_conn_state->base.scaling_mode != old_conn_state->base.scaling_mode) crtc_state->mode_changed = true;
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -1818,6 +1818,7 @@ int intel_ddc_get_modes(struct drm_connector *c, struct i2c_adapter *adapter);void intel_attach_force_audio_property (struct drm_connector *connector);void intel_attach_broadcast_rgb_property (struct drm_connector *connector);void intel_attach_aspect_ratio_property (struct drm_connector *connector); +void intel_attach_content_type_property (struct drm_connector *connector);/* intel_overlay.c */
drivers/gpu/drm/i915/intel_hdmi.c +4 -0
@@ -491,6 +491,8 @@ static void intel_hdmi_set_avi_infoframe(struct drm_encoder *encoder, intel_hdmi->rgb_quant_range_selectable, is_hdmi2_sink); + frame.avi.content_type = connector->state->content_type; +/* TODO: handle pixel repetition for YCBCR420 outputs */ intel_write_infoframe (encoder, crtc_state, &frame); }
@@ -2065,7 +2067,9 @@ intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *cintel_attach_force_audio_property (connector);intel_attach_broadcast_rgb_property (connector);intel_attach_aspect_ratio_property (connector); +intel_attach_content_type_property (connector); connector->state->picture_aspect_ratio =HDMI_PICTURE_ASPECT_NONE ; + connector->state->content_type =HDMI_CONTENT_TYPE_GRAPHICS ; }/*
drivers/gpu/drm/i915/intel_modes.c +10 -0
@@ -133,3 +133,13 @@ intel_attach_aspect_ratio_property(struct drm_connector *connector) connector->dev->mode_config.aspect_ratio_property, DRM_MODE_PICTURE_ASPECT_NONE); } + +void +intel_attach_content_type_property (struct drm_connector *connector) +{ +if (!drm_mode_create_content_type_property (connector->dev)) +drm_object_attach_property (&connector->base, + connector->dev->mode_config.content_type_property, +DRM_MODE_CONTENT_TYPE_GRAPHICS ); +} +
Signature · 6 lines
2.17.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v1 2/2] i915: content-type property for HDMI connector
Quoted 7 lines · StanLis
From: Stanislav Lisovskiy <[email protected]>
Added encoding of drm
content_typeproperty fromdrm_connector_statewithin AVI infoframe in order to properly handle external HDMI TV content-type setting.Signed-off-by Stanislav Lisovskiy <[email protected]>
Hi Stanislav,
Thank you for your patch.
Quoted 45 lines
--- drivers/gpu/drm/i915/intel_atomic.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_hdmi.c | 4 ++++ drivers/gpu/drm/i915/intel_modes.c | 10 ++++++++++ 4 files changed, 16 insertions(+)drivers/gpu/drm/i915/intel_atomic.c +1
-0@@ -124,6 +124,7 @@ int intel_digital_connector_atomic_check(struct drm_connector *conn,if (new_conn_state->force_audio != old_conn_state->force_audio || new_conn_state->broadcast_rgb != old_conn_state->broadcast_rgb || new_conn_state->base.picture_aspect_ratio != old_conn_state->base.picture_aspect_ratio || + new_conn_state->base.content_type != old_conn_state->base.content_type || new_conn_state->base.scaling_mode != old_conn_state->base.scaling_mode) crtc_state->mode_changed = true;drivers/gpu/drm/i915/intel_drv.h +1
-0@@ -1818,6 +1818,7 @@ int intel_ddc_get_modes(struct drm_connector *c, struct i2c_adapter *adapter);void intel_attach_force_audio_property (struct drm_connector *connector);void intel_attach_broadcast_rgb_property (struct drm_connector *connector);void intel_attach_aspect_ratio_property (struct drm_connector *connector); +void intel_attach_content_type_property (struct drm_connector *connector);/* intel_overlay.c */ drivers/gpu/drm/i915/intel_hdmi.c +2
-0@@ -491,6 +491,8 @@ static void intel_hdmi_set_avi_infoframe(struct drm_encoder *encoder, intel_hdmi->rgb_quant_range_selectable, is_hdmi2_sink); + frame.avi.content_type = connector->state->content_type; +/* TODO: handle pixel repetition for YCBCR420 outputs */ intel_write_infoframe (encoder, crtc_state, &frame); }
drivers/gpu/drm/i915/intel_hdmi.c intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *c · line 2072
Quoted 6 lines
drivers/gpu/drm/i915/intel_hdmi.c +2
-0@@ -2065,7 +2067,9 @@ intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *cintel_attach_force_audio_property (connector);intel_attach_broadcast_rgb_property (connector);intel_attach_aspect_ratio_property (connector); +intel_attach_content_type_property (connector); connector->state->picture_aspect_ratio =HDMI_PICTURE_ASPECT_NONE ; + connector->state->content_type =HDMI_CONTENT_TYPE_GRAPHICS ;
This is redudant, the attach function already sets this.
Quoted 10 lines
drivers/gpu/drm/i915/intel_hdmi.c +0
-0}/* drivers/gpu/drm/i915/intel_modes.c +0
-0@@ -133,3 +133,13 @@ intel_attach_aspect_ratio_property(struct drm_connector *connector) connector->dev->mode_config.aspect_ratio_property, DRM_MODE_PICTURE_ASPECT_NONE);
drivers/gpu/drm/i915/intel_modes.c intel_attach_aspect_ratio_property(struct drm_connector *connector) · line 144
Quoted 10 lines
drivers/gpu/drm/i915/intel_modes.c +9
-0} + +void +intel_attach_content_type_property (struct drm_connector *connector) +{ +if (!drm_mode_create_content_type_property (connector->dev)) +drm_object_attach_property (&connector->base, + connector->dev->mode_config.content_type_property, +DRM_MODE_CONTENT_TYPE_GRAPHICS ); +}
I think the "in" thing to do is to add this helper to the core, since this is a core property.
Sean
Quoted 8 lines
drivers/gpu/drm/i915/intel_modes.c +1
-0+Signature · 6 lines
2.17.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RE: [Intel-gfx] [PATCH v1 2/2] i915: content-type property for HDMI connector
Hi Sean,
Thank you for comments!
Could you please clarify a bit more here, as I've just started recently working on drm side, so I took an aspect ratio property as an example.
Quoted 16 lines
(quoted diff) +5
-0@@ -491,6 +491,8 @@ static void intel_hdmi_set_avi_infoframe(struct drm_encoder *encoder, intel_hdmi->rgb_quant_range_selectable, is_hdmi2_sink); + frame.avi.content_type = connector->state->content_type; + /* TODO: handle pixel repetition for YCBCR420 outputs */ intel_write_infoframe(encoder, crtc_state, &frame); } @@ -2065,7 +2067,9 @@ intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *c intel_attach_force_audio_property(connector); intel_attach_broadcast_rgb_property(connector); intel_attach_aspect_ratio_property(connector); + intel_attach_content_type_property(connector); connector->state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE; + connector->state->content_type = HDMI_CONTENT_TYPE_GRAPHICS;
Quoted 1 line
This is redudant, the attach function already sets this.
As you can see aspect ratio is set exactly same way, which is also an HDMI avi info frame property.
Also there are actually two different enums: HDMI_CONTENT_TYPE_* and DRM_MODE_CONTENT_TYPE_* i.e:
there are one in drm_connector.c:
static const struct drm_prop_enum_list drm_aspect_ratio_enum_list[] = {
{ DRM_MODE_PICTURE_ASPECT_NONE, "Automatic" },
{ DRM_MODE_PICTURE_ASPECT_4_3, "4:3" },
{ DRM_MODE_PICTURE_ASPECT_16_9, "16:9" },
};so I added
static const struct drm_prop_enum_list drm_content_type_enum_list[] = {
{ DRM_MODE_CONTENT_TYPE_GRAPHICS, "GRAPHICS" },
{ DRM_MODE_CONTENT_TYPE_PHOTO, "PHOTO" },
{ DRM_MODE_CONTENT_TYPE_CINEMA, "CINEMA" },
{ DRM_MODE_CONTENT_TYPE_GAME, "GAME" },
};
and the one in linux/hdmi.h:
enum hdmi_picture_aspect {
HDMI_PICTURE_ASPECT_NONE,
HDMI_PICTURE_ASPECT_4_3,
HDMI_PICTURE_ASPECT_16_9,
HDMI_PICTURE_ASPECT_64_27,
HDMI_PICTURE_ASPECT_256_135,
HDMI_PICTURE_ASPECT_RESERVED,
};enum hdmi_content_type {
HDMI_CONTENT_TYPE_GRAPHICS,
HDMI_CONTENT_TYPE_PHOTO,
HDMI_CONTENT_TYPE_CINEMA,
HDMI_CONTENT_TYPE_GAME,
};
For some reason the latter enums are used in drm_connector_state, but not the drm_content_type_enum_list(those are actually defined values which simply match):
From drm_connector.c:
/**
* @picture_aspect_ratio: Connector property to control the
* HDMI infoframe aspect ratio setting.
*
* The %DRM_MODE_PICTURE_ASPECT_\* values much match the
* values for &enum hdmi_picture_aspect
*/
enum hdmi_picture_aspect picture_aspect_ratio;
/**
* @content_type: Connector property to control the
* HDMI infoframe content type setting.
*
* The %DRM_MODE_CONTENT_TYPE_\* values much match the
* values for &enum hdmi_content_type
*/
enum hdmi_content_type content_type;
That's why I did it exactly as it is done with aspect ratio. Just want to clarify, as I was assuming this was done for reason.
Quoted 21 lines
}
/*
drivers/gpu/drm/i915/intel_modes.c +8
-0@@ -133,3 +133,13 @@ intel_attach_aspect_ratio_property(struct drm_connector *connector) connector->dev->mode_config.aspect_ratio_property, DRM_MODE_PICTURE_ASPECT_NONE); } + +void +intel_attach_content_type_property (struct drm_connector *connector) { +if (!drm_mode_create_content_type_property (connector->dev)) +drm_object_attach_property (&connector->base, + connector->dev->mode_config.content_type_property, +DRM_MODE_CONTENT_TYPE_GRAPHICS ); +}
Quoted 1 line
I think the "in" thing to do is to add this helper to the core, since this is a core property.
Could you please explain a bit more, what do you mean by core here?
I just thought it is one of HDMI infoframe properties, as stated in spec:
https://www.hdmi.org/manufacturer/hdmi_1_4/content_type.aspx
Best Regards,
Lisovskiy Stanislav
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel