Skip to contentSkip to conversation

uio: Change return type to vm_fault_t

PATCH Superseded Souptick Joarder 2 participants 3 messages Apr 16, 2018 Userspace I/O (UIO)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Souptick Joarder

author
#0 lore raw

PATCH v2 1/1 uio: Change return type to vm_fault_t

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference commit id->
1c8f422059ae5da07db7406ab916203f9417e396

Signed-off-by Souptick Joarder <[email protected]>
Reviewed-by Matthew Wilcox <[email protected]>

---
v2: Modified the change log

 drivers/uio/uio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/uio/uio.c +1 -1
index fd48483..d9235f3 100644
@@ -597,7 +597,7 @@ static int uio_find_mem_index(struct vm_area_struct *vma)
 	return -1;
 }
 
-static int uio_vma_fault(struct vm_fault *vmf)
+static vm_fault_t uio_vma_fault(struct vm_fault *vmf)
 {
 	struct uio_device *idev = vmf->vma->vm_private_data;
 	struct page *page;

--
1.9.1

maintainer
#1 lore raw
Quoted 6 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Odd line length to wrap at, your editor should have told you to use 72 columns, right?

Quoted 2 lines

Reference commit id->
1c8f422059ae5da07db7406ab916203f9417e396

1c8f422059ae ("mm: change return type to vm_fault_t")

Is the "canonical" way to reference git commit ids, it's easy to set up an alias for this:

	alias gsr='git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"'
Quoted 4 lines
Signed-off-by Souptick Joarder <[email protected]>
Reviewed-by Matthew Wilcox <[email protected]>

---
v2: Modified the change log

3rd time's the charm?

thanks,

greg k-h

author
#2 lore raw
Quoted 10 lines · Greg KH
Quoted 6 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Odd line length to wrap at, your editor should have told you to use 72 columns, right?

Not clear about this.