Skip to contentSkip to conversation

qt5: qt5websockets: install missing qml modules

PATCH New Manfred Schlaegl 3 participants 5 messages Apr 11, 2018 – May 1, 2018

lore
Share & tools
lore

Manfred Schlaegl

author
#0 lore raw

PATCH 1/1 qt5: qt5websockets: install missing qml modules

QML modules for QtWebSockets are located in /usr/qml/QtWebSockets since Qt 5.5.

/usr/qml/Qt/WebSockets still exists for compatibility reasons, but it contains only a qmldir file which points to ../../QtWebSockets/.

see also: http://doc.qt.io/qt-5.6/qtwebsockets-qmlmodule.html

Signed-off-by Manfred Schlaegl <[email protected]>
---
 package/qt5/qt5websockets/qt5websockets.mk | 1 +
 1 file changed, 1 insertion(+)
package/qt5/qt5websockets/qt5websockets.mk +1 -0
index 4d9df9257b..c67db198db 100644
@@ -41,6 +41,7 @@ endef
 ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
 define QT5WEBSOCKETS_INSTALL_TARGET_QMLS
 	cp -dpfr $(STAGING_DIR)/usr/qml/Qt/WebSockets $(TARGET_DIR)/usr/qml/Qt/
+	cp -dpfr $(STAGING_DIR)/usr/qml/QtWebSockets $(TARGET_DIR)/usr/qml/
 endef
 endif
Signature · 1 line
2.11.0
Applied
#1 lore raw

PATCH 1/1 qt5: qt5websockets: install missing qml modules

Hello,

Thanks for your contribution!

Quoted 5 lines · Manfred Schlaegl

QML modules for QtWebSockets are located in /usr/qml/QtWebSockets since Qt 5.5.

/usr/qml/Qt/WebSockets still exists for compatibility reasons, but it contains only a qmldir file which points to ../../QtWebSockets/.

Does this mean we should remove the installation
of /usr/qml/Qt/WebSockets ?

I've applied your patch to master as-is, anyway. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH 1/1 qt5: qt5websockets: install missing qml modules

Hi,

Quoted 3 lines · Thomas Petazzoni

Hello,

Thanks for your contribution!

Thanks for maintaining ;-)

Quoted 10 lines · Manfred Schlaegl
Quoted 5 lines

QML modules for QtWebSockets are located in /usr/qml/QtWebSockets since Qt 5.5.

/usr/qml/Qt/WebSockets still exists for compatibility reasons, but it contains only a qmldir file which points to ../../QtWebSockets/.

Does this mean we should remove the installation
of /usr/qml/Qt/WebSockets ?

Newer projects (since Qt5.5) use
{{{
import QtWebSockets 1.0
}}}
which translates to /usr/qml/QtWebSockets
-> This is, what was missing.

Older projects (prior Qt5.5) use
{{{
import Qt.WebSockets 1.0
}}}
which resolves to /usr/qml/Qt/WebSockets
-> We don't want to break them, so we have to keep /usr/qml/Qt/WebSockets.

In short: We have to keep it. ;-)

Quoted 5 lines

I've applied your patch to master as-is, anyway. Thanks!

Thomas

Thanks!

Best regards,
Manfred

#3 lore raw

PATCH 1/1 qt5: qt5websockets: install missing qml modules

Hello,

Quoted 3 lines · Manfred Schlaegl

-> We don't want to break them, so we have to keep /usr/qml/Qt/WebSockets.

In short: We have to keep it. ;-)

ACK, thanks for the confirmation!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 qt5: qt5websockets: install missing qml modules

In reply to Manfred Schlaegl
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Manfred" == Manfred Schlaegl <[email protected]> writes:

QML modules for QtWebSockets are located in /usr/qml/QtWebSockets since Qt 5.5.

/usr/qml/Qt/WebSockets still exists for compatibility reasons, but it contains only a qmldir file which points to ../../QtWebSockets/.

see also: http://doc.qt.io/qt-5.6/qtwebsockets-qmlmodule.html

Signed-off-by Manfred Schlaegl <[email protected]>

Committed to 2018.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard