Skip to contentSkip to conversation

commands: i2c_write: enable reg == 0 too

PATCH Applied Antony Pavlov 2 participants 2 messages Apr 17, 2018

lore
Share & tools
lore

Antony Pavlov

author
#0 lore raw

PATCH 1/1 commands: i2c_write: enable reg == 0 too

This commit fixes the mistake introduced in the commit 34fadb685905 ('commands: i2c_write: enable raw write to address'). The intended behaviour for i2c_write command is
"use raw i2c write only if reg address is not defined". Before the commit 34fadb685905 reg address == 0
was acceptable. After the commit 34fadb685905 reg address == 0 became unacceptable ("undefined") and will lead to raw i2c write.

Signed-off-by Antony Pavlov <[email protected]>
---
 commands/i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
commands/i2c.c +1 -1
index 21c39fe5af..f0d16af0cb 100644
@@ -131,7 +131,7 @@ static int do_i2c_write(int argc, char *argv[])
 	for (i = 0; i < count; i++)
 		*(buf + i) = (char) simple_strtol(argv[optind+i], NULL, 0);
 
-	if (reg > 0) {
+	if (reg >= 0) {
 		ret = i2c_write_reg(&client, reg | wide, buf, count);
 	} else {
 		ret = i2c_master_send(&client, buf, count);
Signature · 7 lines
2.17.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Applied
#1 lore raw
Quoted 8 lines · Antony Pavlov

This commit fixes the mistake introduced in the commit 34fadb685905 ('commands: i2c_write: enable raw write to address'). The intended behaviour for i2c_write command is
"use raw i2c write only if reg address is not defined". Before the commit 34fadb685905 reg address == 0
was acceptable. After the commit 34fadb685905 reg address == 0 became unacceptable ("undefined") and will lead to raw i2c write.

Quoted 4 lines
Signed-off-by Antony Pavlov <[email protected]>
---
 commands/i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

Quoted 18 lines
commands/i2c.c +1 -1
index 21c39fe5af..f0d16af0cb 100644
@@ -131,7 +131,7 @@ static int do_i2c_write(int argc, char *argv[])
 	for (i = 0; i < count; i++)
 		*(buf + i) = (char) simple_strtol(argv[optind+i], NULL, 0);
 
-	if (reg > 0) {
+	if (reg >= 0) {
 		ret = i2c_write_reg(&client, reg | wide, buf, count);
 	} else {
 		ret = i2c_master_send(&client, buf, count);
Signature · 1 line
2.17.0
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox