Skip to contentSkip to conversation

hwtracing: intel_th: Change return type to vm_fault_t

PATCH In review Souptick Joarder 2 participants 4 messages Apr 17, 2018 – Jun 17, 2018 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwtracing: intel_th: Change return type to vm_fault_t

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 drivers/hwtracing/intel_th/msu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwtracing/intel_th/msu.c +1 -1
index dfb57ea..0ac84eb 100644
@@ -1190,7 +1190,7 @@ static void msc_mmap_close(struct vm_area_struct *vma)
 	mutex_unlock(&msc->buf_mutex);
 }
 
-static int msc_mmap_fault(struct vm_fault *vmf)
+static vm_fault_t msc_mmap_fault(struct vm_fault *vmf)
 {
 	struct msc_iter *iter = vmf->vma->vm_file->private_data;
 	struct msc *msc = iter->msc;

--
1.9.1

#1 lore raw

Any comment for this patch ?

Quoted 29 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 drivers/hwtracing/intel_th/msu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwtracing/intel_th/msu.c +1 -2
index dfb57ea..0ac84eb 100644
@@ -1190,7 +1190,7 @@ static void msc_mmap_close(struct vm_area_struct *vma)
        mutex_unlock(&msc->buf_mutex);
 }
 
-static int msc_mmap_fault(struct vm_fault *vmf)
+static vm_fault_t msc_mmap_fault(struct vm_fault *vmf)
 {
        struct msc_iter *iter = vmf->vma->vm_file->private_data;
        struct msc *msc = iter->msc;
--

1.9.1

#2 lore raw
Quoted 1 line · Souptick Joarder

Any comment for this patch ?

Looks good, I'm queuing this one for the next merge window.

Thanks you!

A message that is not in the archive (sent off-list or not yet received): CAFqt6zbSuVZjH0W6o7fMLpytk28y_4tZ7Mt1B36SX=+LkaUP3A@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAFqt6zbyCvknqkwnhQiyY1j32zufVk0rkPfxgKbytZcXY=xTVQ@mail.gmail.com

#5 lore raw
Quoted 8 lines · Souptick Joarder
Quoted 6 lines · Alexander Shishkin
Quoted 1 line · Souptick Joarder

Any comment for this patch ?

Looks good, I'm queuing this one for the next merge window.

This patch is not merged in 4.18-rc-1.