Skip to contentSkip to conversation

gpu: drm: i915: Change return type to vm_fault_t

PATCH Superseded Souptick Joarder 6 participants 13 messages Apr 17, 2018 – Apr 20, 2018

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu: drm: i915: Change return type to vm_fault_t

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 drivers/gpu/drm/i915/i915_drv.h |  3 ++-
 drivers/gpu/drm/i915/i915_gem.c | 15 ++++++++-------
 2 files changed, 10 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -1
index a42deeb..95b0d50 100644
@@ -51,6 +51,7 @@
 #include <drm/drm_gem.h>
 #include <drm/drm_auth.h>
 #include <drm/drm_cache.h>
+#include <linux/mm_types.h>
 
 #include "i915_params.h"
 #include "i915_reg.h"
@@ -3363,7 +3364,7 @@ int i915_gem_wait_for_idle(struct drm_i915_private *dev_priv,
 			   unsigned int flags);
 int __must_check i915_gem_suspend(struct drm_i915_private *dev_priv);
 void i915_gem_resume(struct drm_i915_private *dev_priv);
-int i915_gem_fault(struct vm_fault *vmf);
+vm_fault_t i915_gem_fault(struct vm_fault *vmf);
 int i915_gem_object_wait(struct drm_i915_gem_object *obj,
 			 unsigned int flags,
 			 long timeout,
drivers/gpu/drm/i915/i915_gem.c +8 -7
index dd89abd..bdac690 100644
@@ -1882,7 +1882,7 @@ int i915_gem_mmap_gtt_version(void)
  * The current feature set supported by i915_gem_fault() and thus GTT mmaps
  * is exposed via I915_PARAM_MMAP_GTT_VERSION (see i915_gem_mmap_gtt_version).
  */
-int i915_gem_fault(struct vm_fault *vmf)
+vm_fault_t i915_gem_fault(struct vm_fault *vmf)
 {
 #define MIN_CHUNK_PAGES ((1 << 20) >> PAGE_SHIFT) /* 1 MiB */
 	struct vm_area_struct *area = vmf->vma;
@@ -1895,6 +1895,7 @@ int i915_gem_fault(struct vm_fault *vmf)
 	pgoff_t page_offset;
 	unsigned int flags;
 	int ret;
+	vm_fault_t retval;
 
 	/* We don't use vmf->pgoff since that has the fake offset */
 	page_offset = (vmf->address - area->vm_start) >> PAGE_SHIFT;
@@ -2000,7 +2001,7 @@ int i915_gem_fault(struct vm_fault *vmf)
 		 * and so needs to be reported.
 		 */
 		if (!i915_terminally_wedged(&dev_priv->gpu_error)) {
-			ret = VM_FAULT_SIGBUS;
+			retval = VM_FAULT_SIGBUS;
 			break;
 		}
 	case -EAGAIN:
@@ -2017,21 +2018,21 @@ int i915_gem_fault(struct vm_fault *vmf)
 		 * EBUSY is ok: this just means that another thread
 		 * already did the job.
 		 */
-		ret = VM_FAULT_NOPAGE;
+		retval = VM_FAULT_NOPAGE;
 		break;
 	case -ENOMEM:
-		ret = VM_FAULT_OOM;
+		retval = VM_FAULT_OOM;
 		break;
 	case -ENOSPC:
 	case -EFAULT:
-		ret = VM_FAULT_SIGBUS;
+		retval = VM_FAULT_SIGBUS;
 		break;
 	default:
 		WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", ret);
-		ret = VM_FAULT_SIGBUS;
+		retval = VM_FAULT_SIGBUS;
 		break;
 	}
-	return ret;
+	return retval;
 }
 
 static void __i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)

--
1.9.1

maintainer
#1 lore raw
Quoted 49 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 drivers/gpu/drm/i915/i915_drv.h |  3 ++-
 drivers/gpu/drm/i915/i915_gem.c | 15 ++++++++-------
 2 files changed, 10 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -1
index a42deeb..95b0d50 100644
@@ -51,6 +51,7 @@
 #include <drm/drm_gem.h>
 #include <drm/drm_auth.h>
 #include <drm/drm_cache.h>
+#include <linux/mm_types.h>
 
 #include "i915_params.h"
 #include "i915_reg.h"
@@ -3363,7 +3364,7 @@ int i915_gem_wait_for_idle(struct drm_i915_private *dev_priv,
 			   unsigned int flags);
 int __must_check i915_gem_suspend(struct drm_i915_private *dev_priv);
 void i915_gem_resume(struct drm_i915_private *dev_priv);
-int i915_gem_fault(struct vm_fault *vmf);
+vm_fault_t i915_gem_fault(struct vm_fault *vmf);
 int i915_gem_object_wait(struct drm_i915_gem_object *obj,
 			 unsigned int flags,
 			 long timeout,
drivers/gpu/drm/i915/i915_gem.c +1 -1
index dd89abd..bdac690 100644
@@ -1882,7 +1882,7 @@ int i915_gem_mmap_gtt_version(void)
  * The current feature set supported by i915_gem_fault() and thus GTT mmaps
  * is exposed via I915_PARAM_MMAP_GTT_VERSION (see i915_gem_mmap_gtt_version).
  */
-int i915_gem_fault(struct vm_fault *vmf)
+vm_fault_t i915_gem_fault(struct vm_fault *vmf)
 {
 #define MIN_CHUNK_PAGES ((1 << 20) >> PAGE_SHIFT) /* 1 MiB */
 	struct vm_area_struct *area = vmf->vma;

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf) · line 1898

Quoted 4 lines
drivers/gpu/drm/i915/i915_gem.c +1 -0
@@ -1895,6 +1895,7 @@ int i915_gem_fault(struct vm_fault *vmf)
 	pgoff_t page_offset;
 	unsigned int flags;
 	int ret;
+	vm_fault_t retval;

What's the point of changing the name? An unnecessary change.

BR,
Jani.

Quoted 42 lines
drivers/gpu/drm/i915/i915_gem.c +6 -7
 	/* We don't use vmf->pgoff since that has the fake offset */
 	page_offset = (vmf->address - area->vm_start) >> PAGE_SHIFT;
@@ -2000,7 +2001,7 @@ int i915_gem_fault(struct vm_fault *vmf)
 		 * and so needs to be reported.
 		 */
 		if (!i915_terminally_wedged(&dev_priv->gpu_error)) {
-			ret = VM_FAULT_SIGBUS;
+			retval = VM_FAULT_SIGBUS;
 			break;
 		}
 	case -EAGAIN:
@@ -2017,21 +2018,21 @@ int i915_gem_fault(struct vm_fault *vmf)
 		 * EBUSY is ok: this just means that another thread
 		 * already did the job.
 		 */
-		ret = VM_FAULT_NOPAGE;
+		retval = VM_FAULT_NOPAGE;
 		break;
 	case -ENOMEM:
-		ret = VM_FAULT_OOM;
+		retval = VM_FAULT_OOM;
 		break;
 	case -ENOSPC:
 	case -EFAULT:
-		ret = VM_FAULT_SIGBUS;
+		retval = VM_FAULT_SIGBUS;
 		break;
 	default:
 		WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", ret);
-		ret = VM_FAULT_SIGBUS;
+		retval = VM_FAULT_SIGBUS;
 		break;
 	}
-	return ret;
+	return retval;
 }
 
 static void __i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)
--

1.9.1

Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
#2 lore raw

Not exactly. The plan for these patches is to introduce new vm_fault_t type in vm_operations_struct fault handlers. It's now available in 4.17-rc1. We will push all the required drivers/filesystem changes through different maintainers to linus tree. Once everything is converted into vm_fault_t type then Changing it from a signed to an unsigned int causes GCC to warn about an assignment from an incompatible type -- int foo(void) is incompatible with unsigned int foo(void).

Please refer 1c8f422059ae ("mm: change return type to vm_fault_t") in 4.17-rc1.

Quoted 105 lines · Jani Nikula
Quoted 49 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 drivers/gpu/drm/i915/i915_drv.h |  3 ++-
 drivers/gpu/drm/i915/i915_gem.c | 15 ++++++++-------
 2 files changed, 10 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -1
index a42deeb..95b0d50 100644
@@ -51,6 +51,7 @@
 #include <drm/drm_gem.h>
 #include <drm/drm_auth.h>
 #include <drm/drm_cache.h>
+#include <linux/mm_types.h>
 
 #include "i915_params.h"
 #include "i915_reg.h"
@@ -3363,7 +3364,7 @@ int i915_gem_wait_for_idle(struct drm_i915_private *dev_priv,
                         unsigned int flags);
 int __must_check i915_gem_suspend(struct drm_i915_private *dev_priv);
 void i915_gem_resume(struct drm_i915_private *dev_priv);
-int i915_gem_fault(struct vm_fault *vmf);
+vm_fault_t i915_gem_fault(struct vm_fault *vmf);
 int i915_gem_object_wait(struct drm_i915_gem_object *obj,
                       unsigned int flags,
                       long timeout,
drivers/gpu/drm/i915/i915_gem.c +1 -1
index dd89abd..bdac690 100644
@@ -1882,7 +1882,7 @@ int i915_gem_mmap_gtt_version(void)
  * The current feature set supported by i915_gem_fault() and thus GTT mmaps
  * is exposed via I915_PARAM_MMAP_GTT_VERSION (see i915_gem_mmap_gtt_version).
  */
-int i915_gem_fault(struct vm_fault *vmf)
+vm_fault_t i915_gem_fault(struct vm_fault *vmf)
 {
 #define MIN_CHUNK_PAGES ((1 << 20) >> PAGE_SHIFT) /* 1 MiB */
      struct vm_area_struct *area = vmf->vma;

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf) · line 1898

Quoted 4 lines
drivers/gpu/drm/i915/i915_gem.c +1 -0
@@ -1895,6 +1895,7 @@ int i915_gem_fault(struct vm_fault *vmf)
      pgoff_t page_offset;
      unsigned int flags;
      int ret;
+     vm_fault_t retval;

What's the point of changing the name? An unnecessary change.

BR,
Jani.

Quoted 40 lines
drivers/gpu/drm/i915/i915_gem.c +6 -7
      /* We don't use vmf->pgoff since that has the fake offset */
      page_offset = (vmf->address - area->vm_start) >> PAGE_SHIFT;
@@ -2000,7 +2001,7 @@ int i915_gem_fault(struct vm_fault *vmf)
               * and so needs to be reported.
               */
              if (!i915_terminally_wedged(&dev_priv->gpu_error)) {
-                     ret = VM_FAULT_SIGBUS;
+                     retval = VM_FAULT_SIGBUS;
                      break;
              }
      case -EAGAIN:
@@ -2017,21 +2018,21 @@ int i915_gem_fault(struct vm_fault *vmf)
               * EBUSY is ok: this just means that another thread
               * already did the job.
               */
-             ret = VM_FAULT_NOPAGE;
+             retval = VM_FAULT_NOPAGE;
              break;
      case -ENOMEM:
-             ret = VM_FAULT_OOM;
+             retval = VM_FAULT_OOM;
              break;
      case -ENOSPC:
      case -EFAULT:
-             ret = VM_FAULT_SIGBUS;
+             retval = VM_FAULT_SIGBUS;
              break;
      default:
              WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", ret);
-             ret = VM_FAULT_SIGBUS;
+             retval = VM_FAULT_SIGBUS;
              break;
      }
-     return ret;
+     return retval;
 }
 
 static void __i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)
--
Quoted 2 lines

1.9.1

--
Jani Nikula, Intel Open Source Technology Center

#3 lore raw
Quoted 9 lines · Souptick Joarder

Not exactly. The plan for these patches is to introduce new vm_fault_t type in vm_operations_struct fault handlers. It's now available in 4.17-rc1. We will push all the required drivers/filesystem changes through different maintainers to linus tree. Once everything is converted into vm_fault_t type then Changing it from a signed to an unsigned int causes GCC to warn about an assignment from an incompatible type -- int foo(void) is incompatible with unsigned int foo(void).

Please refer 1c8f422059ae ("mm: change return type to vm_fault_t") in 4.17-rc1.

I think this patch would be clearer if you did

- int ret;
+ int err;
+ vm_fault_t ret;

Then it would be clearer to the maintainer that you're splitting apart the VM_FAULT and errno codes.

Sorry for not catching this during initial review.

Quoted 100 lines
Quoted 98 lines · Jani Nikula
Quoted 49 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 drivers/gpu/drm/i915/i915_drv.h |  3 ++-
 drivers/gpu/drm/i915/i915_gem.c | 15 ++++++++-------
 2 files changed, 10 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -1
index a42deeb..95b0d50 100644
@@ -51,6 +51,7 @@
 #include <drm/drm_gem.h>
 #include <drm/drm_auth.h>
 #include <drm/drm_cache.h>
+#include <linux/mm_types.h>
 
 #include "i915_params.h"
 #include "i915_reg.h"
@@ -3363,7 +3364,7 @@ int i915_gem_wait_for_idle(struct drm_i915_private *dev_priv,
                         unsigned int flags);
 int __must_check i915_gem_suspend(struct drm_i915_private *dev_priv);
 void i915_gem_resume(struct drm_i915_private *dev_priv);
-int i915_gem_fault(struct vm_fault *vmf);
+vm_fault_t i915_gem_fault(struct vm_fault *vmf);
 int i915_gem_object_wait(struct drm_i915_gem_object *obj,
                       unsigned int flags,
                       long timeout,
drivers/gpu/drm/i915/i915_gem.c +1 -1
index dd89abd..bdac690 100644
@@ -1882,7 +1882,7 @@ int i915_gem_mmap_gtt_version(void)
  * The current feature set supported by i915_gem_fault() and thus GTT mmaps
  * is exposed via I915_PARAM_MMAP_GTT_VERSION (see i915_gem_mmap_gtt_version).
  */
-int i915_gem_fault(struct vm_fault *vmf)
+vm_fault_t i915_gem_fault(struct vm_fault *vmf)
 {
 #define MIN_CHUNK_PAGES ((1 << 20) >> PAGE_SHIFT) /* 1 MiB */
      struct vm_area_struct *area = vmf->vma;

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf) · line 1898

Quoted 4 lines
drivers/gpu/drm/i915/i915_gem.c +1 -0
@@ -1895,6 +1895,7 @@ int i915_gem_fault(struct vm_fault *vmf)
      pgoff_t page_offset;
      unsigned int flags;
      int ret;
+     vm_fault_t retval;

What's the point of changing the name? An unnecessary change.

BR,
Jani.

Quoted 38 lines
drivers/gpu/drm/i915/i915_gem.c +6 -6
      /* We don't use vmf->pgoff since that has the fake offset */
      page_offset = (vmf->address - area->vm_start) >> PAGE_SHIFT;
@@ -2000,7 +2001,7 @@ int i915_gem_fault(struct vm_fault *vmf)
               * and so needs to be reported.
               */
              if (!i915_terminally_wedged(&dev_priv->gpu_error)) {
-                     ret = VM_FAULT_SIGBUS;
+                     retval = VM_FAULT_SIGBUS;
                      break;
              }
      case -EAGAIN:
@@ -2017,21 +2018,21 @@ int i915_gem_fault(struct vm_fault *vmf)
               * EBUSY is ok: this just means that another thread
               * already did the job.
               */
-             ret = VM_FAULT_NOPAGE;
+             retval = VM_FAULT_NOPAGE;
              break;
      case -ENOMEM:
-             ret = VM_FAULT_OOM;
+             retval = VM_FAULT_OOM;
              break;
      case -ENOSPC:
      case -EFAULT:
-             ret = VM_FAULT_SIGBUS;
+             retval = VM_FAULT_SIGBUS;
              break;
      default:
              WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", ret);
-             ret = VM_FAULT_SIGBUS;
+             retval = VM_FAULT_SIGBUS;
              break;
      }
-     return ret;
+     return retval;
 }
 
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
drivers/gpu/drm/i915/i915_gem.c +0 -1
 static void __i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)
--

1.9.1

--
Jani Nikula, Intel Open Source Technology Center

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 3 lines · Matthew Wilcox
Quoted 1 line · Souptick Joarder

Not exactly. The plan for these patches is to introduce new vm_fault_t

type

Quoted 1 line
Quoted 1 line

in vm_operations_struct fault handlers. It's now available in 4.17-rc1.

We will

Quoted 1 line
Quoted 1 line

push all the required drivers/filesystem changes through different

maintainers

Quoted 1 line
Quoted 1 line

to linus tree. Once everything is converted into vm_fault_t type then

Changing

Quoted 1 line
Quoted 1 line

it from a signed to an unsigned int causes GCC to warn about an

assignment

Quoted 4 lines
Quoted 4 lines

from an incompatible type -- int foo(void) is incompatible with unsigned int foo(void).

Please refer 1c8f422059ae ("mm: change return type to vm_fault_t") in

4.17-rc1.

Quoted 11 lines

I think this patch would be clearer if you did

(quoted diff) +2 -1
-       int ret;
+       int err;
+       vm_fault_t ret;

Then it would be clearer to the maintainer that you're splitting apart the VM_FAULT and errno codes.

Sorry for not catching this during initial review.

Ok, I will make required changes and send v2. Sorry, even I missed this :)

Quoted 12 lines
Quoted 12 lines
Quoted 9 lines · Jani Nikula
Quoted 8 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines
---
 drivers/gpu/drm/i915/i915_drv.h |  3 ++-
 drivers/gpu/drm/i915/i915_gem.c | 15 ++++++++-------
 2 files changed, 10 insertions(+), 8 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_drv.h

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

index a42deeb..95b0d50 100644

drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -51,6 +51,7 @@
 #include <drm/drm_gem.h>
 #include <drm/drm_auth.h>
 #include <drm/drm_cache.h>
+#include <linux/mm_types.h>
 
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

drivers/gpu/drm/i915/i915_drv.h int i915_gem_wait_for_idle(struct

Quoted 3 lines
drivers/gpu/drm/i915/i915_drv.h +0 -0
 #include "i915_params.h"
 #include "i915_reg.h"
@@ -3363,7 +3364,7 @@ int i915_gem_wait_for_idle(struct

drm_i915_private *dev_priv,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

drivers/gpu/drm/i915/i915_drv.h int i915_gem_wait_for_idle(struct · line 3365

Quoted 2 lines
drivers/gpu/drm/i915/i915_drv.h +0 -0
                         unsigned int flags);
 int __must_check i915_gem_suspend(struct drm_i915_private

*dev_priv);

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines
drivers/gpu/drm/i915/i915_drv.h +1 -1
 void i915_gem_resume(struct drm_i915_private *dev_priv);
-int i915_gem_fault(struct vm_fault *vmf);
+vm_fault_t i915_gem_fault(struct vm_fault *vmf);
 int i915_gem_object_wait(struct drm_i915_gem_object *obj,
                       unsigned int flags,
                       long timeout,
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_gem.c

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/i915/i915_gem.c int i915_gem_mmap_gtt_version(void) · line 1882

Quoted 5 lines

index dd89abd..bdac690 100644

drivers/gpu/drm/i915/i915_gem.c +0 -0
@@ -1882,7 +1882,7 @@ int i915_gem_mmap_gtt_version(void)
  * The current feature set supported by i915_gem_fault() and thus

GTT mmaps

Quoted 1 line
Quoted 1 line
Quoted 1 line

drivers/gpu/drm/i915/i915_gem.c int i915_gem_mmap_gtt_version(void) · line 1883

Quoted 1 line
drivers/gpu/drm/i915/i915_gem.c +0 -0
  * is exposed via I915_PARAM_MMAP_GTT_VERSION (see

i915_gem_mmap_gtt_version).

Quoted 39 lines
Quoted 39 lines
Quoted 39 lines

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf) · line 1898

Quoted 11 lines
drivers/gpu/drm/i915/i915_gem.c +2 -1
  */
-int i915_gem_fault(struct vm_fault *vmf)
+vm_fault_t i915_gem_fault(struct vm_fault *vmf)
 {
 #define MIN_CHUNK_PAGES ((1 << 20) >> PAGE_SHIFT) /* 1 MiB */
      struct vm_area_struct *area = vmf->vma;
@@ -1895,6 +1895,7 @@ int i915_gem_fault(struct vm_fault *vmf)
      pgoff_t page_offset;
      unsigned int flags;
      int ret;
+     vm_fault_t retval;

What's the point of changing the name? An unnecessary change.

BR,
Jani.

Quoted 22 lines
drivers/gpu/drm/i915/i915_gem.c +3 -3
      /* We don't use vmf->pgoff since that has the fake offset */
      page_offset = (vmf->address - area->vm_start) >> PAGE_SHIFT;
@@ -2000,7 +2001,7 @@ int i915_gem_fault(struct vm_fault *vmf)
               * and so needs to be reported.
               */
              if (!i915_terminally_wedged(&dev_priv->gpu_error)) {
-                     ret = VM_FAULT_SIGBUS;
+                     retval = VM_FAULT_SIGBUS;
                      break;
              }
      case -EAGAIN:
@@ -2017,21 +2018,21 @@ int i915_gem_fault(struct vm_fault *vmf)
               * EBUSY is ok: this just means that another thread
               * already did the job.
               */
-             ret = VM_FAULT_NOPAGE;
+             retval = VM_FAULT_NOPAGE;
              break;
      case -ENOMEM:
-             ret = VM_FAULT_OOM;
+             retval = VM_FAULT_OOM;
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf)

Quoted 8 lines
drivers/gpu/drm/i915/i915_gem.c +1 -1
              break;
      case -ENOSPC:
      case -EFAULT:
-             ret = VM_FAULT_SIGBUS;
+             retval = VM_FAULT_SIGBUS;
              break;
      default:
              WARN_ONCE(ret, "unhandled error in i915_gem_fault:

%i\n", ret);

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf)

Quoted 9 lines
drivers/gpu/drm/i915/i915_gem.c +2 -2
-             ret = VM_FAULT_SIGBUS;
+             retval = VM_FAULT_SIGBUS;
              break;
      }
-     return ret;
+     return retval;
 }
 
 static void __i915_gem_object_release_mmap(struct

drm_i915_gem_object *obj)

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines

--
1.9.1

--
Jani Nikula, Intel Open Source Technology Center

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#5 lore raw
Quoted 25 lines · Souptick Joarder
Quoted 3 lines · Matthew Wilcox
Quoted 1 line · Souptick Joarder

Not exactly. The plan for these patches is to introduce new vm_fault_t

type

Quoted 1 line
Quoted 1 line

in vm_operations_struct fault handlers. It's now available in 4.17-rc1.

We will

Quoted 1 line
Quoted 1 line

push all the required drivers/filesystem changes through different

maintainers

Quoted 1 line
Quoted 1 line

to linus tree. Once everything is converted into vm_fault_t type then

Changing

Quoted 1 line
Quoted 1 line

it from a signed to an unsigned int causes GCC to warn about an

assignment

Quoted 4 lines
Quoted 4 lines

from an incompatible type -- int foo(void) is incompatible with unsigned int foo(void).

Please refer 1c8f422059ae ("mm: change return type to vm_fault_t") in

4.17-rc1.

Quoted 7 lines

I think this patch would be clearer if you did

(quoted diff) +2 -1
-       int ret;
+       int err;
+       vm_fault_t ret;
Quoted 6 lines
Quoted 4 lines

Then it would be clearer to the maintainer that you're splitting apart the VM_FAULT and errno codes.

Sorry for not catching this during initial review.

Ok, I will make required changes and send v2. Sorry, even I missed this :)

I'm afraid Daniel is closer to the truth. My bad, sorry for the noise.

BR,
Jani.

Quoted 116 lines
Quoted 12 lines
Quoted 12 lines
Quoted 9 lines · Jani Nikula
Quoted 8 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines
---
 drivers/gpu/drm/i915/i915_drv.h |  3 ++-
 drivers/gpu/drm/i915/i915_gem.c | 15 ++++++++-------
 2 files changed, 10 insertions(+), 8 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_drv.h

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

index a42deeb..95b0d50 100644

drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -51,6 +51,7 @@
 #include <drm/drm_gem.h>
 #include <drm/drm_auth.h>
 #include <drm/drm_cache.h>
+#include <linux/mm_types.h>
 
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

drivers/gpu/drm/i915/i915_drv.h int i915_gem_wait_for_idle(struct

Quoted 3 lines
drivers/gpu/drm/i915/i915_drv.h +0 -0
 #include "i915_params.h"
 #include "i915_reg.h"
@@ -3363,7 +3364,7 @@ int i915_gem_wait_for_idle(struct

drm_i915_private *dev_priv,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

drivers/gpu/drm/i915/i915_drv.h int i915_gem_wait_for_idle(struct · line 3365

Quoted 2 lines
drivers/gpu/drm/i915/i915_drv.h +0 -0
                         unsigned int flags);
 int __must_check i915_gem_suspend(struct drm_i915_private

*dev_priv);

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines
drivers/gpu/drm/i915/i915_drv.h +1 -1
 void i915_gem_resume(struct drm_i915_private *dev_priv);
-int i915_gem_fault(struct vm_fault *vmf);
+vm_fault_t i915_gem_fault(struct vm_fault *vmf);
 int i915_gem_object_wait(struct drm_i915_gem_object *obj,
                       unsigned int flags,
                       long timeout,
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_gem.c

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/i915/i915_gem.c int i915_gem_mmap_gtt_version(void) · line 1882

Quoted 5 lines

index dd89abd..bdac690 100644

drivers/gpu/drm/i915/i915_gem.c +0 -0
@@ -1882,7 +1882,7 @@ int i915_gem_mmap_gtt_version(void)
  * The current feature set supported by i915_gem_fault() and thus

GTT mmaps

Quoted 1 line
Quoted 1 line
Quoted 1 line

drivers/gpu/drm/i915/i915_gem.c int i915_gem_mmap_gtt_version(void) · line 1883

Quoted 1 line
drivers/gpu/drm/i915/i915_gem.c +0 -0
  * is exposed via I915_PARAM_MMAP_GTT_VERSION (see

i915_gem_mmap_gtt_version).

Quoted 39 lines
Quoted 39 lines
Quoted 39 lines

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf) · line 1898

Quoted 11 lines
drivers/gpu/drm/i915/i915_gem.c +2 -1
  */
-int i915_gem_fault(struct vm_fault *vmf)
+vm_fault_t i915_gem_fault(struct vm_fault *vmf)
 {
 #define MIN_CHUNK_PAGES ((1 << 20) >> PAGE_SHIFT) /* 1 MiB */
      struct vm_area_struct *area = vmf->vma;
@@ -1895,6 +1895,7 @@ int i915_gem_fault(struct vm_fault *vmf)
      pgoff_t page_offset;
      unsigned int flags;
      int ret;
+     vm_fault_t retval;

What's the point of changing the name? An unnecessary change.

BR,
Jani.

Quoted 22 lines
drivers/gpu/drm/i915/i915_gem.c +3 -3
      /* We don't use vmf->pgoff since that has the fake offset */
      page_offset = (vmf->address - area->vm_start) >> PAGE_SHIFT;
@@ -2000,7 +2001,7 @@ int i915_gem_fault(struct vm_fault *vmf)
               * and so needs to be reported.
               */
              if (!i915_terminally_wedged(&dev_priv->gpu_error)) {
-                     ret = VM_FAULT_SIGBUS;
+                     retval = VM_FAULT_SIGBUS;
                      break;
              }
      case -EAGAIN:
@@ -2017,21 +2018,21 @@ int i915_gem_fault(struct vm_fault *vmf)
               * EBUSY is ok: this just means that another thread
               * already did the job.
               */
-             ret = VM_FAULT_NOPAGE;
+             retval = VM_FAULT_NOPAGE;
              break;
      case -ENOMEM:
-             ret = VM_FAULT_OOM;
+             retval = VM_FAULT_OOM;
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf)

Quoted 8 lines
drivers/gpu/drm/i915/i915_gem.c +1 -1
              break;
      case -ENOSPC:
      case -EFAULT:
-             ret = VM_FAULT_SIGBUS;
+             retval = VM_FAULT_SIGBUS;
              break;
      default:
              WARN_ONCE(ret, "unhandled error in i915_gem_fault:

%i\n", ret);

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf)

Quoted 9 lines
drivers/gpu/drm/i915/i915_gem.c +2 -2
-             ret = VM_FAULT_SIGBUS;
+             retval = VM_FAULT_SIGBUS;
              break;
      }
-     return ret;
+     return retval;
 }
 
 static void __i915_gem_object_release_mmap(struct

drm_i915_gem_object *obj)

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines

--
1.9.1

--
Jani Nikula, Intel Open Source Technology Center

Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
maintainer
#6 lore raw
Quoted 26 lines · Jani Nikula
Quoted 25 lines · Souptick Joarder
Quoted 3 lines · Matthew Wilcox
Quoted 1 line · Souptick Joarder

Not exactly. The plan for these patches is to introduce new vm_fault_t

type

Quoted 1 line
Quoted 1 line

in vm_operations_struct fault handlers. It's now available in 4.17-rc1.

We will

Quoted 1 line
Quoted 1 line

push all the required drivers/filesystem changes through different

maintainers

Quoted 1 line
Quoted 1 line

to linus tree. Once everything is converted into vm_fault_t type then

Changing

Quoted 1 line
Quoted 1 line

it from a signed to an unsigned int causes GCC to warn about an

assignment

Quoted 4 lines
Quoted 4 lines

from an incompatible type -- int foo(void) is incompatible with unsigned int foo(void).

Please refer 1c8f422059ae ("mm: change return type to vm_fault_t") in

4.17-rc1.

Quoted 7 lines

I think this patch would be clearer if you did

(quoted diff) +2 -1
-       int ret;
+       int err;
+       vm_fault_t ret;
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

Then it would be clearer to the maintainer that you're splitting apart the VM_FAULT and errno codes.

Sorry for not catching this during initial review.

Ok, I will make required changes and send v2. Sorry, even I missed this :)

I'm afraid Daniel is closer to the truth.

+1.

Quoted 1 line

My bad, sorry for the noise.

I opened this thread to add exactly question/noise ;).

So my recommendation for some next time is to make the intention clear on the commit message itself from the begin.

Quoted 114 lines

BR,
Jani.

Quoted 108 lines
Quoted 12 lines
Quoted 12 lines
Quoted 9 lines · Jani Nikula
Quoted 8 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines
---
 drivers/gpu/drm/i915/i915_drv.h |  3 ++-
 drivers/gpu/drm/i915/i915_gem.c | 15 ++++++++-------
 2 files changed, 10 insertions(+), 8 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_drv.h

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

index a42deeb..95b0d50 100644

drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -51,6 +51,7 @@
 #include <drm/drm_gem.h>
 #include <drm/drm_auth.h>
 #include <drm/drm_cache.h>
+#include <linux/mm_types.h>
 
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

drivers/gpu/drm/i915/i915_drv.h int i915_gem_wait_for_idle(struct

Quoted 3 lines
drivers/gpu/drm/i915/i915_drv.h +0 -0
 #include "i915_params.h"
 #include "i915_reg.h"
@@ -3363,7 +3364,7 @@ int i915_gem_wait_for_idle(struct

drm_i915_private *dev_priv,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

drivers/gpu/drm/i915/i915_drv.h int i915_gem_wait_for_idle(struct · line 3365

Quoted 2 lines
drivers/gpu/drm/i915/i915_drv.h +0 -0
                         unsigned int flags);
 int __must_check i915_gem_suspend(struct drm_i915_private

*dev_priv);

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines
drivers/gpu/drm/i915/i915_drv.h +1 -1
 void i915_gem_resume(struct drm_i915_private *dev_priv);
-int i915_gem_fault(struct vm_fault *vmf);
+vm_fault_t i915_gem_fault(struct vm_fault *vmf);
 int i915_gem_object_wait(struct drm_i915_gem_object *obj,
                       unsigned int flags,
                       long timeout,
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_gem.c

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/i915/i915_gem.c int i915_gem_mmap_gtt_version(void) · line 1882

Quoted 5 lines

index dd89abd..bdac690 100644

drivers/gpu/drm/i915/i915_gem.c +0 -0
@@ -1882,7 +1882,7 @@ int i915_gem_mmap_gtt_version(void)
  * The current feature set supported by i915_gem_fault() and thus

GTT mmaps

Quoted 1 line
Quoted 1 line
Quoted 1 line

drivers/gpu/drm/i915/i915_gem.c int i915_gem_mmap_gtt_version(void) · line 1883

Quoted 1 line
drivers/gpu/drm/i915/i915_gem.c +0 -0
  * is exposed via I915_PARAM_MMAP_GTT_VERSION (see

i915_gem_mmap_gtt_version).

Quoted 39 lines
Quoted 39 lines
Quoted 39 lines

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf) · line 1898

Quoted 11 lines
drivers/gpu/drm/i915/i915_gem.c +2 -1
  */
-int i915_gem_fault(struct vm_fault *vmf)
+vm_fault_t i915_gem_fault(struct vm_fault *vmf)
 {
 #define MIN_CHUNK_PAGES ((1 << 20) >> PAGE_SHIFT) /* 1 MiB */
      struct vm_area_struct *area = vmf->vma;
@@ -1895,6 +1895,7 @@ int i915_gem_fault(struct vm_fault *vmf)
      pgoff_t page_offset;
      unsigned int flags;
      int ret;
+     vm_fault_t retval;

What's the point of changing the name? An unnecessary change.

BR,
Jani.

Quoted 22 lines
drivers/gpu/drm/i915/i915_gem.c +3 -3
      /* We don't use vmf->pgoff since that has the fake offset */
      page_offset = (vmf->address - area->vm_start) >> PAGE_SHIFT;
@@ -2000,7 +2001,7 @@ int i915_gem_fault(struct vm_fault *vmf)
               * and so needs to be reported.
               */
              if (!i915_terminally_wedged(&dev_priv->gpu_error)) {
-                     ret = VM_FAULT_SIGBUS;
+                     retval = VM_FAULT_SIGBUS;
                      break;
              }
      case -EAGAIN:
@@ -2017,21 +2018,21 @@ int i915_gem_fault(struct vm_fault *vmf)
               * EBUSY is ok: this just means that another thread
               * already did the job.
               */
-             ret = VM_FAULT_NOPAGE;
+             retval = VM_FAULT_NOPAGE;
              break;
      case -ENOMEM:
-             ret = VM_FAULT_OOM;
+             retval = VM_FAULT_OOM;
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf)

Quoted 8 lines
drivers/gpu/drm/i915/i915_gem.c +1 -1
              break;
      case -ENOSPC:
      case -EFAULT:
-             ret = VM_FAULT_SIGBUS;
+             retval = VM_FAULT_SIGBUS;
              break;
      default:
              WARN_ONCE(ret, "unhandled error in i915_gem_fault:

%i\n", ret);

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/i915_gem.c +2 -2
-             ret = VM_FAULT_SIGBUS;
+             retval = VM_FAULT_SIGBUS;
              break;
      }
-     return ret;
+     return retval;
 }
 
Quoted 15 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf) · line 2038

Quoted 1 line
drivers/gpu/drm/i915/i915_gem.c +0 -0
 static void __i915_gem_object_release_mmap(struct

drm_i915_gem_object *obj)

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines

--
1.9.1

--
Jani Nikula, Intel Open Source Technology Center

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#7 lore raw
In reply to Jani Nikula
Quoted 48 lines · Jani Nikula
Quoted 47 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 drivers/gpu/drm/i915/i915_drv.h |  3 ++-
 drivers/gpu/drm/i915/i915_gem.c | 15 ++++++++-------
 2 files changed, 10 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -1
index a42deeb..95b0d50 100644
@@ -51,6 +51,7 @@
 #include <drm/drm_gem.h>
 #include <drm/drm_auth.h>
 #include <drm/drm_cache.h>
+#include <linux/mm_types.h>
 
 #include "i915_params.h"
 #include "i915_reg.h"
@@ -3363,7 +3364,7 @@ int i915_gem_wait_for_idle(struct drm_i915_private *dev_priv,
                         unsigned int flags);
 int __must_check i915_gem_suspend(struct drm_i915_private *dev_priv);
 void i915_gem_resume(struct drm_i915_private *dev_priv);
-int i915_gem_fault(struct vm_fault *vmf);
+vm_fault_t i915_gem_fault(struct vm_fault *vmf);
 int i915_gem_object_wait(struct drm_i915_gem_object *obj,
                       unsigned int flags,
                       long timeout,
drivers/gpu/drm/i915/i915_gem.c +1 -1
index dd89abd..bdac690 100644
@@ -1882,7 +1882,7 @@ int i915_gem_mmap_gtt_version(void)
  * The current feature set supported by i915_gem_fault() and thus GTT mmaps
  * is exposed via I915_PARAM_MMAP_GTT_VERSION (see i915_gem_mmap_gtt_version).
  */
-int i915_gem_fault(struct vm_fault *vmf)
+vm_fault_t i915_gem_fault(struct vm_fault *vmf)
 {
 #define MIN_CHUNK_PAGES ((1 << 20) >> PAGE_SHIFT) /* 1 MiB */
Quoted 8 lines

drivers/gpu/drm/i915/i915_gem.c int i915_gem_fault(struct vm_fault *vmf) · line 1898

Quoted 6 lines
drivers/gpu/drm/i915/i915_gem.c +1 -0
      struct vm_area_struct *area = vmf->vma;
@@ -1895,6 +1895,7 @@ int i915_gem_fault(struct vm_fault *vmf)
      pgoff_t page_offset;
      unsigned int flags;
      int ret;
+     vm_fault_t retval;

What's the point of changing the name? An unnecessary change.

int ret;

already exists and is used. You can't also have a vm_fault_t ret; on top of that :-)
-Daniel

Quoted 53 lines

BR,
Jani.

Quoted 40 lines
drivers/gpu/drm/i915/i915_gem.c +6 -7
      /* We don't use vmf->pgoff since that has the fake offset */
      page_offset = (vmf->address - area->vm_start) >> PAGE_SHIFT;
@@ -2000,7 +2001,7 @@ int i915_gem_fault(struct vm_fault *vmf)
               * and so needs to be reported.
               */
              if (!i915_terminally_wedged(&dev_priv->gpu_error)) {
-                     ret = VM_FAULT_SIGBUS;
+                     retval = VM_FAULT_SIGBUS;
                      break;
              }
      case -EAGAIN:
@@ -2017,21 +2018,21 @@ int i915_gem_fault(struct vm_fault *vmf)
               * EBUSY is ok: this just means that another thread
               * already did the job.
               */
-             ret = VM_FAULT_NOPAGE;
+             retval = VM_FAULT_NOPAGE;
              break;
      case -ENOMEM:
-             ret = VM_FAULT_OOM;
+             retval = VM_FAULT_OOM;
              break;
      case -ENOSPC:
      case -EFAULT:
-             ret = VM_FAULT_SIGBUS;
+             retval = VM_FAULT_SIGBUS;
              break;
      default:
              WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", ret);
-             ret = VM_FAULT_SIGBUS;
+             retval = VM_FAULT_SIGBUS;
              break;
      }
-     return ret;
+     return retval;
 }
 
 static void __i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)
--
Quoted 2 lines

1.9.1

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#8 lore raw

✗ Fi.CI.CHECKPATCH: warning for gpu: drm: i915: Change return type to vm_fault_t (rev2)

In reply to Souptick Joarder
== Series Details ==

== Series Details ==

Series: gpu: drm: i915: Change return type to vm_fault_t (rev2)
URL : https://patchwork.freedesktop.org/series/41893/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
045e647f1204 gpu: drm: i915: Change return type to vm_fault_t
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 1c8f422059ae ("mm: change return type to vm_fault_t")'
#11: 
Reference id -> 1c8f422059ae ("mm: change return type to

total: 1 errors, 0 warnings, 0 checks, 64 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

Re: ✗ Fi.CI.CHECKPATCH: warning for gpu: drm: i915: Change return type to vm_fault_t (rev2)

Quoted 11 lines · Patchwork

== Series Details ==

Series: gpu: drm: i915: Change return type to vm_fault_t (rev2)
URL : https://patchwork.freedesktop.org/series/41893/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
045e647f1204 gpu: drm: i915: Change return type to vm_fault_t
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 1c8f422059ae ("mm: change return type to vm_fault_t")'

Does it mean I need to send v3 with correction ?
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

✗ Fi.CI.SPARSE: warning for gpu: drm: i915: Change return type to vm_fault_t (rev2)

In reply to Souptick Joarder
== Series Details ==

== Series Details ==

Series: gpu: drm: i915: Change return type to vm_fault_t (rev2)
URL : https://patchwork.freedesktop.org/series/41893/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Commit: gpu: drm: i915: Change return type to vm_fault_t
-drivers/gpu/drm/i915/selftests/../i915_drv.h:2207:33: warning: constant 0xffffea0000000000 is so big it is unsigned long
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3655:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/selftests/../i915_drv.h:2208:33: warning: constant 0xffffea0000000000 is so big it is unsigned long
+drivers/gpu/drm/i915/selftests/../i915_drv.h:3656:16: warning: expression using sizeof(void)

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

✓ Fi.CI.BAT: success for gpu: drm: i915: Change return type to vm_fault_t (rev2)

In reply to Souptick Joarder
== Series Details ==

== Series Details ==

Series: gpu: drm: i915: Change return type to vm_fault_t (rev2)
URL : https://patchwork.freedesktop.org/series/41893/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4066 -> Patchwork_8736 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/41893/revisions/2/mbox/

== Known issues ==

Here are the changes found in Patchwork_8736 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_frontbuffer_tracking@basic:
      fi-cnl-y3:          PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-bxt-dsi:         NOTRUN -> INCOMPLETE (fdo#103927)

fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927

== Participating hosts (33 -> 32) ==

Additional (2): fi-glk-j4005 fi-bxt-dsi
Missing (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq

== Build changes ==

* Linux: CI_DRM_4066 -> Patchwork_8736

CI_DRM_4066: e1fbca4821d0700551df233285a5c28db09fd0f6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4441: 83ba5b7d3bde48b383df41792fc9c955a5a23bdb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8736: 045e647f1204c28a28882560da315568d838e3ea @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4441: e60d247eb359f044caf0c09904da14e39d7adca1 @ git://anongit.freedesktop.org/piglit

== Linux commits ==

045e647f1204 gpu: drm: i915: Change return type to vm_fault_t

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8736/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#12 lore raw

✓ Fi.CI.IGT: success for gpu: drm: i915: Change return type to vm_fault_t (rev2)

In reply to Souptick Joarder
== Series Details ==

== Series Details ==

Series: gpu: drm: i915: Change return type to vm_fault_t (rev2)
URL : https://patchwork.freedesktop.org/series/41893/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4066_full -> Patchwork_8736_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_8736_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_8736_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/41893/revisions/2/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_8736_full:

=== IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-bsd1:
      shard-kbl:          PASS -> SKIP +1

    igt@gem_mocs_settings@mocs-rc6-bsd2:
      shard-kbl:          SKIP -> PASS

    igt@kms_vblank@pipe-a-query-forked-busy:
      shard-snb:          PASS -> SKIP

== Known issues ==

Here are the changes found in Patchwork_8736_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_flip@plain-flip-ts-check:
      shard-hsw:          PASS -> FAIL (fdo#100368)

    igt@kms_setmode@basic:
      shard-hsw:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
      shard-hsw:          FAIL (fdo#105767) -> PASS

    igt@kms_flip@2x-dpms-vs-vblank-race:
      shard-hsw:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-hsw:          FAIL (fdo#102887) -> PASS

    igt@kms_flip@flip-vs-blocking-wf-vblank:
      shard-hsw:          FAIL (fdo#100368) -> PASS

    igt@kms_frontbuffer_tracking@fbc-farfromfence:
      shard-kbl:          DMESG-WARN (fdo#103558, fdo#105602) -> PASS +2

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@kms_sysfs_edid_timing:
      shard-apl:          WARN (fdo#100047) -> PASS

fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105767 https://bugs.freedesktop.org/show_bug.cgi?id=105767
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (9 -> 4) ==

Missing (5): shard-glk8 shard-glk6 shard-glk7 shard-glk shard-glkb

== Build changes ==

* Linux: CI_DRM_4066 -> Patchwork_8736

CI_DRM_4066: e1fbca4821d0700551df233285a5c28db09fd0f6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4441: 83ba5b7d3bde48b383df41792fc9c955a5a23bdb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8736: 045e647f1204c28a28882560da315568d838e3ea @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4441: e60d247eb359f044caf0c09904da14e39d7adca1 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8736/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx