Skip to contentSkip to conversation

net/i40e: fix I40e start failing for missing JUMBO_FRAME offload

PATCH Superseded Yanglong Wu 3 participants 7 messages Apr 17, 2018 – Apr 27, 2018 Network drivers

lore
Share & tools
lore

Yanglong Wu

author
#0 lore raw

PATCH 1/1 net/i40e: fix I40e start failing for missing JUMBO_FRAME offload

JUMBO_FRAME offload should be set as default,
missing it will lead to start failing for I40e.

Signed-off-by Yanglong Wu <[email protected]>
---
 drivers/net/i40e/i40e_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +2 -1
index 180ac7449..c3bd254ae 100644
@@ -3228,7 +3228,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
 		DEV_RX_OFFLOAD_VLAN_EXTEND |
-		DEV_RX_OFFLOAD_VLAN_FILTER;
+		DEV_RX_OFFLOAD_VLAN_FILTER |
+		DEV_RX_OFFLOAD_JUMBO_FRAME;
 
 	dev_info->tx_queue_offload_capa = 0;
 	dev_info->tx_offload_capa =
Signature · 1 line
2.11.0
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: Wu, Yanglong
Sent: Tuesday, April 17, 2018 3:29 PM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Dai, Wei <[email protected]>; Yao, Lei A <[email protected]>; Wu, Yanglong <[email protected]>
Subject: [PATCH] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload

Quoted 3 lines

JUMBO_FRAME offload should be set as default, missing it will lead to start failing for I40e.

Please add fixed commit here.

Quoted 22 lines
Signed-off-by Yanglong Wu <[email protected]>
---
 drivers/net/i40e/i40e_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +2 -1
index 180ac7449..c3bd254ae 100644
@@ -3228,7 +3228,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct
 rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
 		DEV_RX_OFFLOAD_VLAN_EXTEND |
-		DEV_RX_OFFLOAD_VLAN_FILTER;
+		DEV_RX_OFFLOAD_VLAN_FILTER |
+		DEV_RX_OFFLOAD_JUMBO_FRAME;
 
 	dev_info->tx_queue_offload_capa = 0;

dev_info->tx_offload_capa =
--
2.11.0

author
#2 lore raw

PATCH v2 1/1 net/i40e: fix I40e start failing for missing JUMBO_FRAME offload

In reply to Yanglong Wu

JUMBO_FRAME offload should be set as default,
missing it will lead to start failing for I40e.

Fixes fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
Signed-off-by Yanglong Wu <[email protected]>

---
v2:
add fix commit

---
 drivers/net/i40e/i40e_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +2 -1
index 180ac7449..c3bd254ae 100644
@@ -3228,7 +3228,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
 		DEV_RX_OFFLOAD_VLAN_EXTEND |
-		DEV_RX_OFFLOAD_VLAN_FILTER;
+		DEV_RX_OFFLOAD_VLAN_FILTER |
+		DEV_RX_OFFLOAD_JUMBO_FRAME;
 
 	dev_info->tx_queue_offload_capa = 0;
 	dev_info->tx_offload_capa =
Signature · 1 line
2.11.0
Acked-by on v2 1/1
#3 lore raw
Quoted 9 lines

-----Original Message-----
From: Wu, Yanglong
Sent: Wednesday, April 18, 2018 9:42 AM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Dai, Wei <[email protected]>; Yao, Lei A <[email protected]>; Wu, Yanglong <[email protected]>
Subject: [PATCH v2] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload

Quoted 5 lines

JUMBO_FRAME offload should be set as default, missing it will lead to start failing for I40e.

Fixes fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
Signed-off-by Yanglong Wu <[email protected]>
Acked-by Qi Zhang <[email protected]>

Title and commit log could be changed to

net/i40e: fix missing jumbo frame offload capability

JUMBO_FRAME offload capability should be exposed since i40e does support it.

author
#4 lore raw

PATCH 1/1 net/i40e: fix I40e start failing for missing JUMBO_FRAME offload

In reply to Yanglong Wu

JUMBO_FRAME offload should be set as default,
missing it will lead to start failing for I40e.

Fixes fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
Signed-off-by Yanglong Wu <[email protected]>

---
v2:
add fix commit

---
 drivers/net/i40e/i40e_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +2 -1
index 180ac7449..c3bd254ae 100644
@@ -3228,7 +3228,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
 		DEV_RX_OFFLOAD_VLAN_EXTEND |
-		DEV_RX_OFFLOAD_VLAN_FILTER;
+		DEV_RX_OFFLOAD_VLAN_FILTER |
+		DEV_RX_OFFLOAD_JUMBO_FRAME;
 
 	dev_info->tx_queue_offload_capa = 0;
 	dev_info->tx_offload_capa =
Signature · 1 line
2.11.0
author
#5 lore raw

PATCH v3 1/1 net/i40e:fix missing jumbo frame offload capability

In reply to Yanglong Wu

JUMBO_FRAME offload capability should
be exposed since i40e does support it.

Fixes fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
Signed-off-by Yanglong Wu <[email protected]>
Acked-by Qi Zhang <[email protected]>

---
v2:
add fix commit
---
v3:
rework commit log

---
 drivers/net/i40e/i40e_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +2 -1
index 180ac7449..c3bd254ae 100644
@@ -3228,7 +3228,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
 		DEV_RX_OFFLOAD_VLAN_EXTEND |
-		DEV_RX_OFFLOAD_VLAN_FILTER;
+		DEV_RX_OFFLOAD_VLAN_FILTER |
+		DEV_RX_OFFLOAD_JUMBO_FRAME;
 
 	dev_info->tx_queue_offload_capa = 0;
 	dev_info->tx_offload_capa =
Signature · 1 line
2.11.0
Applied
#6 lore raw

Re: [PATCH v3] net/i40e:fix missing jumbo frame offload capability

Quoted 10 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Yanglong Wu
Sent: Thursday, April 19, 2018 10:19 AM
To: [email protected]
Cc: Zhang, Qi Z; Dai, Wei; Yao, Lei A; Wu, Yanglong
Subject: [dpdk-dev] [PATCH v3] net/i40e:fix missing jumbo frame offload capability

Quoted 6 lines

JUMBO_FRAME offload capability should
be exposed since i40e does support it.

Fixes fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
Signed-off-by Yanglong Wu <[email protected]>
Acked-by Qi Zhang <[email protected]>

Applied to dpdk-next-net-intel, thanks!

/Helin