tracing/x86: Update syscall trace events to handle new prefixed syscall func names
Steven Rostedt
maintainerPATCH v3 1/1 tracing/x86: Update syscall trace events to handle new prefixed syscall func names
From: "Steven Rostedt (VMware)" <[email protected]>
Arnaldo noticed that the latest kernel is missing the syscall event system directory in x86. I bisected it down to d5a00528b58c ("syscalls/core, syscalls/x86: Rename struct pt_regs-based sys_*() to __x64_sys_*()").
The system call trace events are special, as there is only one trace event for all system calls (the raw_syscalls). But a macro that wraps the system calls creates meta data for them that copies the name to find the system call that maps to the system call table (the number). At boot up, it does a kallsyms lookup of the system call table to find the function that maps to the meta data of the system call. If it does not find a function, then that system call is ignored.
Because the x86 system calls had "__x64_", or "__ia32_" prefixed to the "sys" for the names, they do not match the default compare algorithm. As this was a problem for power pc, the algorithm can be overwritten by the architecture. The solution is to have x86 have its own algorithm to do the compare and this brings back the system call trace events.
---
Changes from v2:
Included check for "__ia32_" as well.
arch/x86/include/asm/ftrace.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/x86/include/asm/ftrace.h +12 -0
@@ -31,6 +31,18 @@ static inline unsigned long ftrace_call_adjust(unsigned long addr)return addr; } +#define ARCH_HAS_SYSCALL_MATCH_SYM_NAME +static inline bool arch_syscall_match_sym_name (const char *sym,const char *name) +{ +/* +* Compare the symbol name with the system call name. Skip the +* "__x64_sys", "__ia32_sys" or simple "sys" prefix. +*/ +return !strcmp (sym +3 , name +3 ) || + (!strncmp (sym,"__x64_" ,6 ) && !strcmp (sym +9 , name +3 )) || + (!strncmp (sym,"__ia32_" ,7 ) && !strcmp (sym +10 , name +3 )); +} +#ifdef CONFIG_DYNAMIC_FTRACE struct dyn_arch_ftrace {
Signature · 1 line
2.13.6
Quoted 20 lines · Steven Rostedt
From: "Steven Rostedt (VMware)" <[email protected]>
Arnaldo noticed that the latest kernel is missing the syscall event system directory in x86. I bisected it down to
d5a00528b58c("syscalls/core, syscalls/x86: Rename struct pt_regs-based sys_*() to __x64_sys_*()").The system call trace events are special, as there is only one trace event for all system calls (the
raw_syscalls). But a macro that wraps the system calls creates meta data for them that copies the name to find the system call that maps to the system call table (the number). At boot up, it does a kallsyms lookup of the system call table to find the function that maps to the meta data of the system call. If it does not find a function, then that system call is ignored.Because the x86 system calls had "
__x64_", or "__ia32_" prefixed to the "sys" for the names, they do not match the default compare algorithm. As this was a problem for power pc, the algorithm can be overwritten by the architecture. The solution is to have x86 have its own algorithm to do the compare and this brings back the system call trace events.
Quoted 6 lines
Reported-by Arnaldo Carvalho de Melo <[email protected]>Fixes d5a00528b58c ("syscalls/core, syscalls/x86: Rename struct pt_regs-based sys_*() to __x64_sys_*()")Signed-off-by Steven Rostedt (VMware) <[email protected]>
Steven Rostedt
maintainerQuoted 1 line · On Wed, 18 Apr 2018 20:17:29 +0200 Dominik Brodowski…
Thanks!
Ingo, Thomas, Peter,
I can take this in my tree, as I have a couple of patches that need to go mainline as well.
OK with you if I do?
-- Steve
Thomas Gleixner
Acked-byQuoted 5 lines · Steven Rostedt
Quoted 1 line · On Wed, 18 Apr 2018 20:17:29 +0200 Dominik Brodowski…
Quoted 8 lines
Thanks!
Ingo, Thomas, Peter,
I can take this in my tree, as I have a couple of patches that need to go mainline as well.
OK with you if I do?